Title: [266763] trunk
- Revision
- 266763
- Author
- [email protected]
- Date
- 2020-09-08 17:23:42 -0700 (Tue, 08 Sep 2020)
Log Message
Drop non-standard name / units attributes from AudioParam
https://bugs.webkit.org/show_bug.cgi?id=216290
Reviewed by Geoffrey Garen.
Source/WebCore:
Drop non-standard name / units attributes from AudioParam:
- https://www.w3.org/TR/webaudio/#AudioParam
Blink does not have them either.
Test: webaudio/audioparam-obsolete-api.html
* Modules/webaudio/AudioParam.h:
* Modules/webaudio/AudioParam.idl:
LayoutTests:
Add layout test coverage.
* webaudio/audioparam-obsolete-api-expected.txt: Added.
* webaudio/audioparam-obsolete-api.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (266762 => 266763)
--- trunk/LayoutTests/ChangeLog 2020-09-09 00:16:16 UTC (rev 266762)
+++ trunk/LayoutTests/ChangeLog 2020-09-09 00:23:42 UTC (rev 266763)
@@ -1,3 +1,15 @@
+2020-09-08 Chris Dumez <[email protected]>
+
+ Drop non-standard name / units attributes from AudioParam
+ https://bugs.webkit.org/show_bug.cgi?id=216290
+
+ Reviewed by Geoffrey Garen.
+
+ Add layout test coverage.
+
+ * webaudio/audioparam-obsolete-api-expected.txt: Added.
+ * webaudio/audioparam-obsolete-api.html: Added.
+
2020-09-08 Ryan Haddad <[email protected]>
Update imported/w3c/web-platform-tests/css/css-text/line-break/line-break-{strict,normal}-015.xht
Added: trunk/LayoutTests/webaudio/audioparam-obsolete-api-expected.txt (0 => 266763)
--- trunk/LayoutTests/webaudio/audioparam-obsolete-api-expected.txt (rev 0)
+++ trunk/LayoutTests/webaudio/audioparam-obsolete-api-expected.txt 2020-09-09 00:23:42 UTC (rev 266763)
@@ -0,0 +1,11 @@
+Checks that obsolete API is no longer present on AudioParam.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS AudioParam.prototype.name is undefined.
+PASS AudioParam.prototype.units is undefined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/webaudio/audioparam-obsolete-api.html (0 => 266763)
--- trunk/LayoutTests/webaudio/audioparam-obsolete-api.html (rev 0)
+++ trunk/LayoutTests/webaudio/audioparam-obsolete-api.html 2020-09-09 00:23:42 UTC (rev 266763)
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Checks that obsolete API is no longer present on AudioParam.");
+
+shouldBeUndefined("AudioParam.prototype.name");
+shouldBeUndefined("AudioParam.prototype.units");
+</script>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (266762 => 266763)
--- trunk/Source/WebCore/ChangeLog 2020-09-09 00:16:16 UTC (rev 266762)
+++ trunk/Source/WebCore/ChangeLog 2020-09-09 00:23:42 UTC (rev 266763)
@@ -1,5 +1,22 @@
2020-09-08 Chris Dumez <[email protected]>
+ Drop non-standard name / units attributes from AudioParam
+ https://bugs.webkit.org/show_bug.cgi?id=216290
+
+ Reviewed by Geoffrey Garen.
+
+ Drop non-standard name / units attributes from AudioParam:
+ - https://www.w3.org/TR/webaudio/#AudioParam
+
+ Blink does not have them either.
+
+ Test: webaudio/audioparam-obsolete-api.html
+
+ * Modules/webaudio/AudioParam.h:
+ * Modules/webaudio/AudioParam.idl:
+
+2020-09-08 Chris Dumez <[email protected]>
+
Drop unnecessary AudioParam::m_smoothingConstant data member
https://bugs.webkit.org/show_bug.cgi?id=216291
Modified: trunk/Source/WebCore/Modules/webaudio/AudioParam.h (266762 => 266763)
--- trunk/Source/WebCore/Modules/webaudio/AudioParam.h 2020-09-09 00:16:16 UTC (rev 266762)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParam.h 2020-09-09 00:23:42 UTC (rev 266763)
@@ -85,9 +85,6 @@
float maxValue() const { return m_maxValue; }
float defaultValue() const { return m_defaultValue; }
- // FIXME: Remove this once it is no longer exposed to the Web.
- static unsigned units() { return 0; }
-
// Value smoothing:
// When a new value is set with setValue(), in our internal use of the parameter we don't immediately jump to it.
Modified: trunk/Source/WebCore/Modules/webaudio/AudioParam.idl (266762 => 266763)
--- trunk/Source/WebCore/Modules/webaudio/AudioParam.idl 2020-09-09 00:16:16 UTC (rev 266762)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParam.idl 2020-09-09 00:23:42 UTC (rev 266763)
@@ -60,8 +60,4 @@
// Cancels all scheduled parameter changes with times greater than or equal to startTime.
[MayThrowException] AudioParam cancelScheduledValues(double cancelTime);
[MayThrowException] AudioParam cancelAndHoldAtTime(double cancelTime);
-
- // FIXME: These are not standard.
- [EnabledBySetting=PrefixedWebAudio] readonly attribute DOMString name;
- [EnabledBySetting=PrefixedWebAudio] readonly attribute unsigned short units;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
