Title: [266768] trunk/Source/WebCore
Revision
266768
Author
[email protected]
Date
2020-09-08 20:14:35 -0700 (Tue, 08 Sep 2020)

Log Message

WebCore UnifiedSource81 builds for upwards of 10 minutes
https://bugs.webkit.org/show_bug.cgi?id=216297

Reviewed by Simon Fraser.

* bindings/js/WebCoreBuiltinNames.h:
(WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):
Work around an LLVM regression by disabling debugging in the
WebCoreBuiltinNames constructor. This is tracked by <rdar://68246686>.

This drops the WebCore release build time on my iMac Pro from 14 minutes to 6.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (266767 => 266768)


--- trunk/Source/WebCore/ChangeLog	2020-09-09 01:35:19 UTC (rev 266767)
+++ trunk/Source/WebCore/ChangeLog	2020-09-09 03:14:35 UTC (rev 266768)
@@ -1,3 +1,17 @@
+2020-09-08  Tim Horton  <[email protected]>
+
+        WebCore UnifiedSource81 builds for upwards of 10 minutes
+        https://bugs.webkit.org/show_bug.cgi?id=216297
+
+        Reviewed by Simon Fraser.
+
+        * bindings/js/WebCoreBuiltinNames.h:
+        (WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):
+        Work around an LLVM regression by disabling debugging in the
+        WebCoreBuiltinNames constructor. This is tracked by <rdar://68246686>.
+
+        This drops the WebCore release build time on my iMac Pro from 14 minutes to 6.
+
 2020-09-08  Chris Dumez  <[email protected]>
 
         Drop non-standard name / units attributes from AudioParam

Modified: trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h (266767 => 266768)


--- trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2020-09-09 01:35:19 UTC (rev 266767)
+++ trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h	2020-09-09 03:14:35 UTC (rev 266768)
@@ -460,6 +460,10 @@
 
 class WebCoreBuiltinNames {
 public:
+    // FIXME: Remove the __attribute__((nodebug)) when <rdar://68246686> is fixed.
+#if COMPILER(CLANG)
+    __attribute__((nodebug))
+#endif
     explicit WebCoreBuiltinNames(JSC::VM& vm)
         : m_vm(vm)
         WEBCORE_COMMON_PRIVATE_IDENTIFIERS_EACH_PROPERTY_NAME(INITIALIZE_BUILTIN_NAMES)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to