Diff
Modified: trunk/Source/WebCore/ChangeLog (267068 => 267069)
--- trunk/Source/WebCore/ChangeLog 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/ChangeLog 2020-09-15 02:55:10 UTC (rev 267069)
@@ -1,3 +1,24 @@
+2020-09-14 Sam Weinig <[email protected]>
+
+ Remove runtime setting for enabling/disabling ShadowDOM
+ https://bugs.webkit.org/show_bug.cgi?id=216511
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove runtime setting for enabling/disabling ShadowDOM. There is no
+ reason one need to disable it now, and it has been on by default for
+ a long enough time.
+
+ * dom/Element.idl:
+ * dom/Event.idl:
+ * dom/Node.idl:
+ * dom/ShadowRoot.idl:
+ * dom/Slotable.idl:
+ * html/HTMLSlotElement.idl:
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::shadowDOMEnabled const): Deleted.
+
2020-09-14 Simon Fraser <[email protected]>
REGRESSION (Async overflow scroll): Code snippets on getkirby.com appear and disappear as content is scrolled
Modified: trunk/Source/WebCore/dom/Element.idl (267068 => 267069)
--- trunk/Source/WebCore/dom/Element.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/dom/Element.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -33,7 +33,7 @@
[CEReactions, Reflect] attribute DOMString id;
[CEReactions, Reflect=class] attribute DOMString className;
[PutForwards=value] readonly attribute DOMTokenList classList; // FIXME: Should be [SameObject].
- [CEReactions, EnabledAtRuntime=ShadowDOM, Reflect, Unscopable] attribute DOMString slot;
+ [CEReactions, Reflect, Unscopable] attribute DOMString slot;
[EnabledAtRuntime=CSSShadowParts, SameObject, PutForwards=value] readonly attribute DOMTokenList part;
[DOMJIT=ReadDOM] boolean hasAttributes();
@@ -55,8 +55,8 @@
[CEReactions, MayThrowException] Attr? setAttributeNodeNS(Attr attr);
[CEReactions, MayThrowException] Attr removeAttributeNode(Attr attr);
- [EnabledAtRuntime=ShadowDOM, MayThrowException] ShadowRoot attachShadow(ShadowRootInit init);
- [EnabledAtRuntime=ShadowDOM, ImplementedAs=shadowRootForBindings, CallWith=GlobalObject] readonly attribute ShadowRoot? shadowRoot;
+ [MayThrowException] ShadowRoot attachShadow(ShadowRootInit init);
+ [ImplementedAs=shadowRootForBindings, CallWith=GlobalObject] readonly attribute ShadowRoot? shadowRoot;
[MayThrowException] Element? closest(DOMString selectors);
[MayThrowException] boolean matches(DOMString selectors);
Modified: trunk/Source/WebCore/dom/Event.idl (267068 => 267069)
--- trunk/Source/WebCore/dom/Event.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/dom/Event.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -32,7 +32,7 @@
readonly attribute DOMString type;
readonly attribute EventTarget? target;
readonly attribute EventTarget? currentTarget;
- [EnabledAtRuntime=ShadowDOM] sequence<EventTarget> composedPath();
+ sequence<EventTarget> composedPath();
const unsigned short NONE = 0;
const unsigned short CAPTURING_PHASE = 1;
@@ -48,7 +48,7 @@
readonly attribute boolean cancelable;
undefined preventDefault();
readonly attribute boolean defaultPrevented;
- [EnabledAtRuntime=ShadowDOM] readonly attribute boolean composed;
+ readonly attribute boolean composed;
[LegacyUnforgeable] readonly attribute boolean isTrusted;
[CallWith=ScriptExecutionContext, ImplementedAs=timeStampForBindings] readonly attribute DOMHighResTimeStamp timeStamp;
Modified: trunk/Source/WebCore/dom/Node.idl (267068 => 267069)
--- trunk/Source/WebCore/dom/Node.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/dom/Node.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -44,9 +44,9 @@
readonly attribute USVString baseURI;
- [EnabledAtRuntime=ShadowDOM] readonly attribute boolean isConnected;
+ readonly attribute boolean isConnected;
[DOMJIT=Getter] readonly attribute Document? ownerDocument;
- [EnabledAtRuntime=ShadowDOM] Node getRootNode(optional GetRootNodeOptions options);
+ Node getRootNode(optional GetRootNodeOptions options);
[DOMJIT=Getter] readonly attribute Node? parentNode;
readonly attribute Element? parentElement;
boolean hasChildNodes();
Modified: trunk/Source/WebCore/dom/ShadowRoot.idl (267068 => 267069)
--- trunk/Source/WebCore/dom/ShadowRoot.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/dom/ShadowRoot.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -24,7 +24,6 @@
*/
[
- EnabledAtRuntime=ShadowDOM,
JSGenerateToJSObject
] interface ShadowRoot : DocumentFragment {
readonly attribute ShadowRootMode mode;
Modified: trunk/Source/WebCore/dom/Slotable.idl (267068 => 267069)
--- trunk/Source/WebCore/dom/Slotable.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/dom/Slotable.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -25,8 +25,6 @@
*/
// https://dom.spec.whatwg.org/#slotable
-[
- EnabledAtRuntime=ShadowDOM,
-] interface mixin Slotable {
+interface mixin Slotable {
[ImplementedAs=assignedSlotForBindings] readonly attribute HTMLSlotElement? assignedSlot;
};
Modified: trunk/Source/WebCore/html/HTMLSlotElement.idl (267068 => 267069)
--- trunk/Source/WebCore/html/HTMLSlotElement.idl 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/html/HTMLSlotElement.idl 2020-09-15 02:55:10 UTC (rev 267069)
@@ -24,7 +24,6 @@
*/
[
- EnabledAtRuntime=ShadowDOM,
JSGenerateToNativeObject
] interface HTMLSlotElement : HTMLElement {
[CEReactions=NotNeeded, Reflect] attribute DOMString name;
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (267068 => 267069)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2020-09-15 02:55:10 UTC (rev 267069)
@@ -55,9 +55,6 @@
bool performanceTimelineEnabled() const { return resourceTimingEnabled() || userTimingEnabled(); }
- void setShadowDOMEnabled(bool isEnabled) { m_isShadowDOMEnabled = isEnabled; }
- bool shadowDOMEnabled() const { return m_isShadowDOMEnabled; }
-
void setMenuItemElementEnabled(bool isEnabled) { m_isMenuItemElementEnabled = isEnabled; }
bool menuItemElementEnabled() const { return m_isMenuItemElementEnabled; }
@@ -303,7 +300,6 @@
bool m_isResourceTimingEnabled { false };
bool m_isUserTimingEnabled { false };
bool m_isSecureContextAttributeEnabled { false };
- bool m_isShadowDOMEnabled { true };
bool m_isMenuItemElementEnabled { false };
bool m_isDirectoryUploadEnabled { false };
bool m_isCustomPasteboardDataEnabled { false };
Modified: trunk/Source/WebKit/ChangeLog (267068 => 267069)
--- trunk/Source/WebKit/ChangeLog 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKit/ChangeLog 2020-09-15 02:55:10 UTC (rev 267069)
@@ -1,3 +1,16 @@
+2020-09-14 Sam Weinig <[email protected]>
+
+ Remove runtime setting for enabling/disabling ShadowDOM
+ https://bugs.webkit.org/show_bug.cgi?id=216511
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove runtime setting for enabling/disabling ShadowDOM. There is no
+ reason one need to disable it now, and it has been on by default for
+ a long enough time.
+
+ * Shared/WebPreferences.yaml:
+
2020-09-14 Aditya Keerthi <[email protected]>
[macOS] Do not dismiss date picker when a value is selected
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (267068 => 267069)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-09-15 02:55:10 UTC (rev 267069)
@@ -774,13 +774,6 @@
defaultValue: false
webcoreBinding: none
-ShadowDOMEnabled:
- type: bool
- defaultValue: true
- humanReadableName: "Shadow DOM"
- humanReadableDescription: "HTML Shadow DOM prototype"
- webcoreBinding: RuntimeEnabledFeatures
-
FetchAPIEnabled:
type: bool
defaultValue: true
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (267068 => 267069)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2020-09-15 02:55:10 UTC (rev 267069)
@@ -1,3 +1,28 @@
+2020-09-14 Sam Weinig <[email protected]>
+
+ Remove runtime setting for enabling/disabling ShadowDOM
+ https://bugs.webkit.org/show_bug.cgi?id=216511
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove runtime setting for enabling/disabling ShadowDOM. There is no
+ reason one need to disable it now, and it has been on by default for
+ a long enough time.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (+[WebPreferences initialize]):
+ (-[WebPreferences setShadowDOMEnabled:]):
+ (-[WebPreferences shadowDOMEnabled]):
+ (-[WebPreferences setVideoPluginProxyEnabled:]):
+ (-[WebPreferences isVideoPluginProxyEnabled]):
+ (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
+ (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
+ (-[WebPreferences setDiskImageCacheEnabled:]):
+ * WebView/WebPreferencesPrivate.h:
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2020-09-14 Dean Jackson <[email protected]>
Enable WebGL2 by default
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (267068 => 267069)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2020-09-15 02:55:10 UTC (rev 267069)
@@ -135,7 +135,6 @@
#define WebKitHyperlinkAuditingEnabledPreferenceKey @"WebKitHyperlinkAuditingEnabled"
#define WebKitAVFoundationEnabledKey @"WebKitAVFoundationEnabled"
#define WebKitAVFoundationNSURLSessionEnabledKey @"WebKitAVFoundationNSURLSessionEnabled"
-#define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled"
#define WebKitRequiresUserGestureForMediaPlaybackPreferenceKey @"WebKitMediaPlaybackRequiresUserGesture"
#define WebKitRequiresUserGestureForVideoPlaybackPreferenceKey @"WebKitVideoPlaybackRequiresUserGesture"
#define WebKitRequiresUserGestureForAudioPlaybackPreferenceKey @"WebKitAudioPlaybackRequiresUserGesture"
@@ -178,7 +177,6 @@
#define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled"
#define WebKitServiceControlsEnabledPreferenceKey @"WebKitServiceControlsEnabled"
#define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"
-#define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
#define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
#define WebKitDataTransferItemsEnabledPreferenceKey @"WebKitDataTransferItemsEnabled"
#define WebKitCustomPasteboardDataEnabledPreferenceKey @"WebKitCustomPasteboardDataEnabled"
@@ -291,3 +289,9 @@
#define WebKitLinkPreloadResponsiveImagesEnabledPreferenceKey @"WebKitLinkPreloadResponsiveImagesEnabled"
#define WebKitDebugInAppBrowserPrivacyEnabledPreferenceKey @"WebKitDebugInAppBrowserPrivacyEnabled"
#define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey @"WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
+
+
+// The preference keys below this point are deprecated and have no effect. They should
+// be removed when it is considered safe to do so.
+#define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
+#define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (267068 => 267069)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2020-09-15 02:55:10 UTC (rev 267069)
@@ -631,7 +631,6 @@
@YES, WebKitMockCaptureDevicesPromptEnabledPreferenceKey,
@YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey,
#endif
- @YES, WebKitShadowDOMEnabledPreferenceKey,
@YES, WebKitCustomElementsEnabledPreferenceKey,
@YES, WebKitDataTransferItemsEnabledPreferenceKey,
@NO, WebKitCustomPasteboardDataEnabledPreferenceKey,
@@ -2231,11 +2230,6 @@
[self _setBoolValue:enabled forKey:WebKitAccelerated2dCanvasEnabledPreferenceKey];
}
-- (void)setDiskImageCacheEnabled:(BOOL)enabled
-{
- // Staging. Can be removed once there are no more callers.
-}
-
- (BOOL)isFrameFlatteningEnabled
{
return [self _unsignedIntValueForKey:WebKitFrameFlatteningPreferenceKey] != WebKitFrameFlatteningDisabled;
@@ -2382,25 +2376,6 @@
return [self _boolValueForKey:WebKitAVFoundationNSURLSessionEnabledKey];
}
-- (void)setVideoPluginProxyEnabled:(BOOL)flag
-{
- // No-op, left for SPI compatibility.
-}
-
-- (BOOL)isVideoPluginProxyEnabled
-{
- return NO;
-}
-
-- (void)setHixie76WebSocketProtocolEnabled:(BOOL)flag
-{
-}
-
-- (BOOL)isHixie76WebSocketProtocolEnabled
-{
- return false;
-}
-
- (BOOL)isInheritURIQueryComponentEnabled
{
return [self _boolValueForKey: WebKitEnableInheritURIQueryComponentPreferenceKey];
@@ -3073,16 +3048,6 @@
[self _setBoolValue:flag forKey:WebKitMediaCaptureRequiresSecureConnectionPreferenceKey];
}
-- (BOOL)shadowDOMEnabled
-{
- return [self _boolValueForKey:WebKitShadowDOMEnabledPreferenceKey];
-}
-
-- (void)setShadowDOMEnabled:(BOOL)flag
-{
- [self _setBoolValue:flag forKey:WebKitShadowDOMEnabledPreferenceKey];
-}
-
- (BOOL)customElementsEnabled
{
return [self _boolValueForKey:WebKitCustomElementsEnabledPreferenceKey];
@@ -3743,3 +3708,41 @@
}
@end
+
+@implementation WebPreferences (WebPrivateObsolete)
+
+// The preferences in this category are deprecated and have no effect. They should
+// be removed when it is considered safe to do so.
+
+- (void)setShadowDOMEnabled:(BOOL)flag
+{
+}
+
+- (BOOL)shadowDOMEnabled
+{
+ return YES;
+}
+
+- (void)setVideoPluginProxyEnabled:(BOOL)flag
+{
+}
+
+- (BOOL)isVideoPluginProxyEnabled
+{
+ return NO;
+}
+
+- (void)setHixie76WebSocketProtocolEnabled:(BOOL)flag
+{
+}
+
+- (BOOL)isHixie76WebSocketProtocolEnabled
+{
+ return NO;
+}
+
+- (void)setDiskImageCacheEnabled:(BOOL)enabled
+{
+}
+
+@end
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (267068 => 267069)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2020-09-15 02:55:10 UTC (rev 267069)
@@ -361,9 +361,6 @@
- (void)_setMinimumZoomFontSize:(float)size;
- (float)_minimumZoomFontSize;
-// Deprecated. Has no effect.
-- (void)setDiskImageCacheEnabled:(BOOL)enabled;
-
- (void)setMediaPlaybackAllowsAirPlay:(BOOL)flag;
- (BOOL)mediaPlaybackAllowsAirPlay;
@@ -442,13 +439,6 @@
- (void)setAVFoundationNSURLSessionEnabled:(BOOL)flag;
- (BOOL)isAVFoundationNSURLSessionEnabled;
-// Deprecated, has no effect.
-- (void)setVideoPluginProxyEnabled:(BOOL)flag;
-- (BOOL)isVideoPluginProxyEnabled;
-
-- (void)setHixie76WebSocketProtocolEnabled:(BOOL)flag;
-- (BOOL)isHixie76WebSocketProtocolEnabled;
-
#if TARGET_OS_IPHONE
- (void)_invalidateCachedPreferences;
- (void)_synchronizeWebStoragePolicyWithCookiePolicy;
@@ -547,9 +537,6 @@
- (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag;
- (BOOL)mediaCaptureRequiresSecureConnection;
-- (void)setShadowDOMEnabled:(BOOL)flag;
-- (BOOL)shadowDOMEnabled;
-
- (void)setCustomElementsEnabled:(BOOL)flag;
- (BOOL)customElementsEnabled;
@@ -711,3 +698,18 @@
@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes;
@end
+
+// The preferences in this category are deprecated and have no effect. They should
+// be removed when it is considered safe to do so.
+@interface WebPreferences (WebPrivateDeprecated)
+- (void)setShadowDOMEnabled:(BOOL)flag;
+- (BOOL)shadowDOMEnabled;
+
+- (void)setVideoPluginProxyEnabled:(BOOL)flag;
+- (BOOL)isVideoPluginProxyEnabled;
+
+- (void)setHixie76WebSocketProtocolEnabled:(BOOL)flag;
+- (BOOL)isHixie76WebSocketProtocolEnabled;
+
+- (void)setDiskImageCacheEnabled:(BOOL)enabled;
+@end
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (267068 => 267069)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2020-09-15 02:55:10 UTC (rev 267069)
@@ -3325,7 +3325,6 @@
RuntimeEnabledFeatures::sharedFeatures().setHighlightAPIEnabled([preferences highlightAPIEnabled]);
- RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled([preferences shadowDOMEnabled]);
settings.setCustomElementsEnabled([preferences customElementsEnabled]);
settings.setDataTransferItemsEnabled([preferences dataTransferItemsEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setCustomPasteboardDataEnabled([preferences customPasteboardDataEnabled]);
Modified: trunk/Source/WebKitLegacy/win/ChangeLog (267068 => 267069)
--- trunk/Source/WebKitLegacy/win/ChangeLog 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/win/ChangeLog 2020-09-15 02:55:10 UTC (rev 267069)
@@ -1,3 +1,21 @@
+2020-09-14 Sam Weinig <[email protected]>
+
+ Remove runtime setting for enabling/disabling ShadowDOM
+ https://bugs.webkit.org/show_bug.cgi?id=216511
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove runtime setting for enabling/disabling ShadowDOM. There is no
+ reason one need to disable it now, and it has been on by default for
+ a long enough time.
+
+ * WebPreferences.cpp:
+ (WebPreferences::initializeDefaultSettings):
+ (WebPreferences::shadowDOMEnabled):
+ (WebPreferences::setShadowDOMEnabled):
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
2020-09-02 Darin Adler <[email protected]>
Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
Modified: trunk/Source/WebKitLegacy/win/WebPreferences.cpp (267068 => 267069)
--- trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/win/WebPreferences.cpp 2020-09-15 02:55:10 UTC (rev 267069)
@@ -311,8 +311,6 @@
CFDictionaryAddValue(defaults, CFSTR(WebKitFetchAPIEnabledPreferenceKey), kCFBooleanFalse);
- CFDictionaryAddValue(defaults, CFSTR(WebKitShadowDOMEnabledPreferenceKey), kCFBooleanFalse);
-
CFDictionaryAddValue(defaults, CFSTR(WebKitCustomElementsEnabledPreferenceKey), kCFBooleanFalse);
CFDictionaryAddValue(defaults, CFSTR(WebKitWebAnimationsEnabledPreferenceKey), kCFBooleanTrue);
@@ -2066,13 +2064,12 @@
{
if (!enabled)
return E_POINTER;
- *enabled = boolValueForKey(WebKitShadowDOMEnabledPreferenceKey);
+ *enabled = true;
return S_OK;
}
-HRESULT WebPreferences::setShadowDOMEnabled(BOOL enabled)
+HRESULT WebPreferences::setShadowDOMEnabled(BOOL)
{
- setBoolValue(WebKitShadowDOMEnabledPreferenceKey, enabled);
return S_OK;
}
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (267068 => 267069)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2020-09-15 02:55:10 UTC (rev 267069)
@@ -5234,11 +5234,6 @@
return hr;
RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled);
- hr = prefsPrivate->shadowDOMEnabled(&enabled);
- if (FAILED(hr))
- return hr;
- RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(!!enabled);
-
hr = prefsPrivate->customElementsEnabled(&enabled);
if (FAILED(hr))
return hr;
Modified: trunk/Tools/ChangeLog (267068 => 267069)
--- trunk/Tools/ChangeLog 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Tools/ChangeLog 2020-09-15 02:55:10 UTC (rev 267069)
@@ -1,3 +1,19 @@
+2020-09-14 Sam Weinig <[email protected]>
+
+ Remove runtime setting for enabling/disabling ShadowDOM
+ https://bugs.webkit.org/show_bug.cgi?id=216511
+
+ Reviewed by Ryosuke Niwa.
+
+ Remove runtime setting for enabling/disabling ShadowDOM. There is no
+ reason one need to disable it now, and it has been on by default for
+ a long enough time.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (resetWebPreferencesToConsistentValues):
+ * DumpRenderTree/win/DumpRenderTree.cpp:
+ (resetWebPreferencesToConsistentValues):
+
2020-09-14 Jonathan Bedard <[email protected]>
[webkitcorepy] AutoInstaller should work with HomeBrew Python
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (267068 => 267069)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2020-09-15 02:55:10 UTC (rev 267069)
@@ -935,7 +935,6 @@
[preferences setMediaSourceEnabled:YES];
[preferences setSourceBufferChangeTypeEnabled:YES];
- [preferences setShadowDOMEnabled:YES];
[preferences setCustomElementsEnabled:YES];
[preferences setDataTransferItemsEnabled:YES];
Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (267068 => 267069)
--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-09-15 02:48:20 UTC (rev 267068)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp 2020-09-15 02:55:10 UTC (rev 267069)
@@ -898,7 +898,6 @@
preferences->setFontSmoothing(FontSmoothingTypeStandard);
prefsPrivate->setFetchAPIEnabled(TRUE);
- prefsPrivate->setShadowDOMEnabled(TRUE);
prefsPrivate->setCustomElementsEnabled(TRUE);
prefsPrivate->setResourceTimingEnabled(TRUE);
prefsPrivate->setUserTimingEnabled(TRUE);
