Title: [267269] branches/safari-610-branch
- Revision
- 267269
- Author
- [email protected]
- Date
- 2020-09-18 12:36:14 -0700 (Fri, 18 Sep 2020)
Log Message
Cherry-pick r266232. rdar://problem/68178664
Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>
Reviewed by Antoine Quint.
Source/WebCore:
Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateAcceleratedActions):
Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.
LayoutTests:
* animations/steps-transform-rendering-updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610-branch/LayoutTests/ChangeLog (267268 => 267269)
--- branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-18 19:36:11 UTC (rev 267268)
+++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-09-18 19:36:14 UTC (rev 267269)
@@ -1,5 +1,42 @@
2020-09-17 Alan Coon <[email protected]>
+ Cherry-pick r266232. rdar://problem/68178664
+
+ Step animations invalidate style on every rendering update whether or not they need to
+ https://bugs.webkit.org/show_bug.cgi?id=215229
+ <rdar://problem/66636153>
+
+ Reviewed by Antoine Quint.
+
+ Source/WebCore:
+
+ Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
+
+ * animation/KeyframeEffect.cpp:
+ (WebCore::KeyframeEffect::updateAcceleratedActions):
+
+ Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
+ This is similar to treatmeant of unaccelerated properties.
+
+ LayoutTests:
+
+ * animations/steps-transform-rendering-updates-expected.txt:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-08-27 Antti Koivisto <[email protected]>
+
+ Step animations invalidate style on every rendering update whether or not they need to
+ https://bugs.webkit.org/show_bug.cgi?id=215229
+ <rdar://problem/66636153>
+
+ Reviewed by Antoine Quint.
+
+ * animations/steps-transform-rendering-updates-expected.txt:
+
+2020-09-17 Alan Coon <[email protected]>
+
Cherry-pick r267057. rdar://problem/69101182
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Modified: branches/safari-610-branch/LayoutTests/animations/steps-transform-rendering-updates-expected.txt (267268 => 267269)
--- branches/safari-610-branch/LayoutTests/animations/steps-transform-rendering-updates-expected.txt 2020-09-18 19:36:11 UTC (rev 267268)
+++ branches/safari-610-branch/LayoutTests/animations/steps-transform-rendering-updates-expected.txt 2020-09-18 19:36:14 UTC (rev 267269)
@@ -1,5 +1,5 @@
PASS count is 0
-FAIL count < 6 should be true. Was false.
+PASS count < 6 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (267268 => 267269)
--- branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-18 19:36:11 UTC (rev 267268)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog 2020-09-18 19:36:14 UTC (rev 267269)
@@ -1,5 +1,48 @@
2020-09-17 Alan Coon <[email protected]>
+ Cherry-pick r266232. rdar://problem/68178664
+
+ Step animations invalidate style on every rendering update whether or not they need to
+ https://bugs.webkit.org/show_bug.cgi?id=215229
+ <rdar://problem/66636153>
+
+ Reviewed by Antoine Quint.
+
+ Source/WebCore:
+
+ Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
+
+ * animation/KeyframeEffect.cpp:
+ (WebCore::KeyframeEffect::updateAcceleratedActions):
+
+ Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
+ This is similar to treatmeant of unaccelerated properties.
+
+ LayoutTests:
+
+ * animations/steps-transform-rendering-updates-expected.txt:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-08-27 Antti Koivisto <[email protected]>
+
+ Step animations invalidate style on every rendering update whether or not they need to
+ https://bugs.webkit.org/show_bug.cgi?id=215229
+ <rdar://problem/66636153>
+
+ Reviewed by Antoine Quint.
+
+ Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
+
+ * animation/KeyframeEffect.cpp:
+ (WebCore::KeyframeEffect::updateAcceleratedActions):
+
+ Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
+ This is similar to treatmeant of unaccelerated properties.
+
+2020-09-17 Alan Coon <[email protected]>
+
Cherry-pick r267057. rdar://problem/69101182
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
Modified: branches/safari-610-branch/Source/WebCore/animation/KeyframeEffect.cpp (267268 => 267269)
--- branches/safari-610-branch/Source/WebCore/animation/KeyframeEffect.cpp 2020-09-18 19:36:11 UTC (rev 267268)
+++ branches/safari-610-branch/Source/WebCore/animation/KeyframeEffect.cpp 2020-09-18 19:36:14 UTC (rev 267269)
@@ -1495,7 +1495,7 @@
void KeyframeEffect::updateAcceleratedActions()
{
- if (m_acceleratedPropertiesState == AcceleratedProperties::None)
+ if (m_acceleratedPropertiesState == AcceleratedProperties::None || m_someKeyframesUseStepsTimingFunction || is<StepsTimingFunction>(timingFunction()))
return;
auto computedTiming = getComputedTiming();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
