Title: [267385] trunk/Source/WebKit
Revision
267385
Author
[email protected]
Date
2020-09-21 16:49:41 -0700 (Mon, 21 Sep 2020)

Log Message

Make accessibility isolated tree a non-experimental feature.
https://bugs.webkit.org/show_bug.cgi?id=216792

Reviewed by Chris Fleizach.

Promote accessibility isolated tree from an experimental feature to a
non-experimental one. This avoids the problem where a user can turn off
the feature through the Safari > Develop > Experimental Features submenu,
while the accessibility request are still coming on a secondary thread,
which leads to random crashes.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesExperimental.yaml:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (267384 => 267385)


--- trunk/Source/WebKit/ChangeLog	2020-09-21 23:42:29 UTC (rev 267384)
+++ trunk/Source/WebKit/ChangeLog	2020-09-21 23:49:41 UTC (rev 267385)
@@ -1,3 +1,19 @@
+2020-09-21  Andres Gonzalez  <[email protected]>
+
+        Make accessibility isolated tree a non-experimental feature.
+        https://bugs.webkit.org/show_bug.cgi?id=216792
+
+        Reviewed by Chris Fleizach.
+
+        Promote accessibility isolated tree from an experimental feature to a
+        non-experimental one. This avoids the problem where a user can turn off
+        the feature through the Safari > Develop > Experimental Features submenu,
+        while the accessibility request are still coming on a secondary thread,
+        which leads to random crashes.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesExperimental.yaml:
+
 2020-09-21  Basuke Suzuki  <[email protected]>
 
         [WinCairo][PlayStation] Support different instances of listener client.

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (267384 => 267385)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-09-21 23:42:29 UTC (rev 267384)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-09-21 23:49:41 UTC (rev 267385)
@@ -987,6 +987,14 @@
   defaultValue: true
   condition: ENABLE(PICTURE_IN_PICTURE_API)
 
+IsAccessibilityIsolatedTreeEnabled:
+  type: bool
+  defaultValue: false
+  humanReadableName: "Isolated Accessibility Tree Mode"
+  humanReadableDescription: "Enable an accessibility hierarchy for VoiceOver that can be accessed on a secondary thread for improved performance"
+  webcoreBinding: RuntimeEnabledFeatures
+  condition: ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+
 # Deprecated
 
 ICECandidateFilteringEnabled:

Modified: trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml (267384 => 267385)


--- trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml	2020-09-21 23:42:29 UTC (rev 267384)
+++ trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml	2020-09-21 23:49:41 UTC (rev 267385)
@@ -495,14 +495,6 @@
   humanReadableDescription: "Enable the Dialog Element"
   webcoreBinding: RuntimeEnabledFeatures
 
-IsAccessibilityIsolatedTreeEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Isolated Accessibility Tree Mode"
-  humanReadableDescription: "Enable an accessibility hierarchy for VoiceOver that can be accessed on a secondary thread for improved performance"
-  webcoreBinding: RuntimeEnabledFeatures
-  condition: ENABLE(ACCESSIBILITY_ISOLATED_TREE)
-
 WebShareFileAPIEnabled:
   type: bool
   defaultValue: false
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to