Title: [267403] trunk
- Revision
- 267403
- Author
- [email protected]
- Date
- 2020-09-22 05:10:58 -0700 (Tue, 22 Sep 2020)
Log Message
Move Media in GPU Process flag from internal to experimental
https://bugs.webkit.org/show_bug.cgi?id=216473
<rdar://problem/69318786>
Reviewed by Eric Carlson.
Source/WebKit:
No change of behavior.
* Shared/WebPreferencesExperimental.yaml:
* Shared/WebPreferencesInternal.yaml:
Tools:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Disable Media in GPU Process flag and WebRTC codec experimental features by default.
This can be overriden by WebKitTestRunner options.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267402 => 267403)
--- trunk/Source/WebKit/ChangeLog 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Source/WebKit/ChangeLog 2020-09-22 12:10:58 UTC (rev 267403)
@@ -1,3 +1,16 @@
+2020-09-22 Youenn Fablet <[email protected]>
+
+ Move Media in GPU Process flag from internal to experimental
+ https://bugs.webkit.org/show_bug.cgi?id=216473
+ <rdar://problem/69318786>
+
+ Reviewed by Eric Carlson.
+
+ No change of behavior.
+
+ * Shared/WebPreferencesExperimental.yaml:
+ * Shared/WebPreferencesInternal.yaml:
+
2020-09-21 Youenn Fablet <[email protected]>
Enable MediaRecorder by default on iOS
Modified: trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml (267402 => 267403)
--- trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml 2020-09-22 12:10:58 UTC (rev 267403)
@@ -85,6 +85,14 @@
humanReadableName: "requestIdleCallback"
humanReadableDescription: "Enable requestIdleCallback support"
+UseGPUProcessForMedia:
+ type: bool
+ defaultValue: defaultUseGPUProcessForMedia()
+ condition: ENABLE(GPU_PROCESS)
+ humanReadableName: "Use GPU Process for media"
+ humanReadableDescription: "Do all media loading and playback in the GPU Process"
+ webcoreName: useGPUProcessForMedia
+
MediaRecorderEnabled:
type: bool
defaultValue: defaultMediaRecorderEnabled()
Modified: trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml (267402 => 267403)
--- trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml 2020-09-22 12:10:58 UTC (rev 267403)
@@ -402,14 +402,6 @@
humanReadableName: "[ITP Repro] 30 Second Timeout For Non-Cookie Data Removal"
humanReadableDescription: "Remove all non-cookie website data after just 30 seconds of no user interaction when Intelligent Tracking Prevention is enabled"
-UseGPUProcessForMedia:
- type: bool
- defaultValue: defaultUseGPUProcessForMedia()
- condition: ENABLE(GPU_PROCESS)
- humanReadableName: "Use GPU Process for media"
- humanReadableDescription: "Do all media loading and playback in the GPU Process"
- webcoreName: useGPUProcessForMedia
-
LiveRangeSelectionEnabled:
type: bool
defaultValue: false
Modified: trunk/Tools/ChangeLog (267402 => 267403)
--- trunk/Tools/ChangeLog 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Tools/ChangeLog 2020-09-22 12:10:58 UTC (rev 267403)
@@ -1,3 +1,18 @@
+2020-09-22 Youenn Fablet <[email protected]>
+
+ Move Media in GPU Process flag from internal to experimental
+ https://bugs.webkit.org/show_bug.cgi?id=216473
+ <rdar://problem/69318786>
+
+ Reviewed by Eric Carlson.
+
+ * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+ (parse_args):
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+ Disable Media in GPU Process flag and WebRTC codec experimental features by default.
+ This can be overriden by WebKitTestRunner options.
+
2020-09-21 Adrian Perez de Castro <[email protected]>
[CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (267402 => 267403)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-09-22 12:10:58 UTC (rev 267403)
@@ -381,7 +381,7 @@
options.additional_expectations.insert(0, host.filesystem.join(host.scm().checkout_root, 'LayoutTests/gpu-process/TestExpectations'))
if not options.internal_feature:
options.internal_feature = []
- options.internal_feature.append('UseGPUProcessForMedia')
+ options.experimental_feature.append('UseGPUProcessForMedia')
options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
options.internal_feature.append('RenderCanvasInGPUProcessEnabled')
if options.result_report_flavor:
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (267402 => 267403)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-22 08:46:36 UTC (rev 267402)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-22 12:10:58 UTC (rev 267403)
@@ -837,6 +837,11 @@
WKPreferencesResetTestRunnerOverrides(preferences);
WKPreferencesEnableAllExperimentalFeatures(preferences);
+ // All experimental features except:
+ static WKStringRef webKitUseGPUProcessForMedia = WKStringCreateWithUTF8CString("UseGPUProcessForMedia");
+ WKPreferencesSetExperimentalFeatureForKey(preferences, false, webKitUseGPUProcessForMedia);
+ static WKStringRef webRTCPlatformCodecsInGPUProcessEnabled = WKStringCreateWithUTF8CString("WebRTCPlatformCodecsInGPUProcessEnabled");
+ WKPreferencesSetExperimentalFeatureForKey(preferences, false, webRTCPlatformCodecsInGPUProcessEnabled);
for (const auto& experimentalFeature : options.experimentalFeatures)
WKPreferencesSetExperimentalFeatureForKey(preferences, experimentalFeature.value, toWK(experimentalFeature.key).get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
