Title: [267412] trunk/Source/WebKit
- Revision
- 267412
- Author
- [email protected]
- Date
- 2020-09-22 09:22:33 -0700 (Tue, 22 Sep 2020)
Log Message
Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
Reviewed by Tim Horton.
To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.
This is a speculative fix due to the aforementioned reproducibility issue.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
checks. So put an explicit check here followed by an explicit release assert.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267411 => 267412)
--- trunk/Source/WebKit/ChangeLog 2020-09-22 16:14:08 UTC (rev 267411)
+++ trunk/Source/WebKit/ChangeLog 2020-09-22 16:22:33 UTC (rev 267412)
@@ -1,3 +1,22 @@
+2020-09-22 Brady Eidson <[email protected]>
+
+ Crashtracer inside PDFPlugin::createScrollbar.
+ <rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
+
+ Reviewed by Tim Horton.
+
+ To quote Tim from r264945:
+ No new tests; timing is such that I can't reproduce without inserting
+ intentional delays into the main thread hops, which is further than
+ I'm willing to go for a test.
+
+ This is a speculative fix due to the aforementioned reproducibility issue.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
+ the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
+ checks. So put an explicit check here followed by an explicit release assert.
+
2020-09-22 Brian Burg <[email protected]>
[Cocoa] _WKInspectorDelegate should handle showing external resources
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (267411 => 267412)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-09-22 16:14:08 UTC (rev 267411)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-09-22 16:22:33 UTC (rev 267412)
@@ -1585,6 +1585,12 @@
ASSERT(isMainThread());
LOG(IncrementalPDF, "Installing PDF document");
+ if (m_hasBeenDestroyed)
+ return;
+
+ // If we haven't been destroyed yet, there must still be a PluginController
+ RELEASE_ASSERT(controller());
+
#if HAVE(INCREMENTAL_PDF_APIS)
maybeClearHighLatencyDataProviderFlag();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
