- Revision
- 267454
- Author
- [email protected]
- Date
- 2020-09-22 18:57:35 -0700 (Tue, 22 Sep 2020)
Log Message
[JSC] Enable Intl.DateTimeFormat dayPeriod
https://bugs.webkit.org/show_bug.cgi?id=216845
Reviewed by Mark Lam.
JSTests:
* stress/intl-datetimeformat.js:
Source/_javascript_Core:
Since we already have consensus, let's enable it.
For now, we keep this flag since it is possible that something
happens before the change is integrated into the spec.
* runtime/OptionsList.h:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (267453 => 267454)
--- trunk/JSTests/ChangeLog 2020-09-23 01:49:31 UTC (rev 267453)
+++ trunk/JSTests/ChangeLog 2020-09-23 01:57:35 UTC (rev 267454)
@@ -1,3 +1,12 @@
+2020-09-22 Yusuke Suzuki <[email protected]>
+
+ [JSC] Enable Intl.DateTimeFormat dayPeriod
+ https://bugs.webkit.org/show_bug.cgi?id=216845
+
+ Reviewed by Mark Lam.
+
+ * stress/intl-datetimeformat.js:
+
2020-09-22 HyeockJin Kim <[email protected]>
Coerce computed property before adding to |excludedList|
Modified: trunk/JSTests/stress/intl-datetimeformat.js (267453 => 267454)
--- trunk/JSTests/stress/intl-datetimeformat.js 2020-09-23 01:49:31 UTC (rev 267453)
+++ trunk/JSTests/stress/intl-datetimeformat.js 2020-09-23 01:57:35 UTC (rev 267454)
@@ -697,7 +697,7 @@
{
let dtf = new Intl.DateTimeFormat("en", {hour: "numeric", minute: "numeric", second: "numeric", fractionalSecondDigits: 1});
shouldBe(dtf.format(t), `7:00:23.1 AM`);
- shouldBe(JSON.stringify(dtf.resolvedOptions()), `{"locale":"en","calendar":"gregory","numberingSystem":"latn","timeZone":"America/Los_Angeles","hourCycle":"h12","hour12":true,"hour":"numeric","minute":"2-digit","second":"2-digit","fractionalSecondDigits":1}`);
+ shouldBe(JSON.stringify(dtf.resolvedOptions()), `{"locale":"en","calendar":"gregory","numberingSystem":"latn","timeZone":"America/Los_Angeles","hourCycle":"h12","hour12":true,"dayPeriod":"short","hour":"numeric","minute":"2-digit","second":"2-digit","fractionalSecondDigits":1}`);
}
shouldThrow(() => {
new Intl.DateTimeFormat("en", {hour: "numeric", minute: "numeric", second: "numeric", fractionalSecondDigits: 0});
Modified: trunk/Source/_javascript_Core/ChangeLog (267453 => 267454)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-23 01:49:31 UTC (rev 267453)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-23 01:57:35 UTC (rev 267454)
@@ -1,3 +1,16 @@
+2020-09-22 Yusuke Suzuki <[email protected]>
+
+ [JSC] Enable Intl.DateTimeFormat dayPeriod
+ https://bugs.webkit.org/show_bug.cgi?id=216845
+
+ Reviewed by Mark Lam.
+
+ Since we already have consensus, let's enable it.
+ For now, we keep this flag since it is possible that something
+ happens before the change is integrated into the spec.
+
+ * runtime/OptionsList.h:
+
2020-09-22 HyeockJin Kim <[email protected]>
Coerce computed property before adding to |excludedList|
Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (267453 => 267454)
--- trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-09-23 01:49:31 UTC (rev 267453)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-09-23 01:57:35 UTC (rev 267454)
@@ -489,7 +489,7 @@
v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \
/* FIXME: We should make sure finalizers don't run for detached windows before enabling WeakRefs by default. https://bugs.webkit.org/show_bug.cgi?id=214508 */ \
v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
- v(Bool, useIntlDateTimeFormatDayPeriod, false, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
+ v(Bool, useIntlDateTimeFormatDayPeriod, true, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
v(Bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.") \
v(Bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.") \
v(Bool, forceMiniVMMode, false, Normal, "If true, it will force mini VM mode on.") \
