Title: [267457] trunk/Source/WebCore
- Revision
- 267457
- Author
- [email protected]
- Date
- 2020-09-22 20:36:13 -0700 (Tue, 22 Sep 2020)
Log Message
[GTK] REGRESSION(r267329): imported/blink/editing/undo/crash-redo-with-iframes.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=216778
Reviewed by Darin Adler.
Covered by existing tests.
* editing/markup.cpp:
(WebCore::serializePreservingVisualAppearanceInternal): Return early
also for "negative" ranges to avoid hitting an assertion inside
serializeNodes, as suggested by Darin.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (267456 => 267457)
--- trunk/Source/WebCore/ChangeLog 2020-09-23 02:38:23 UTC (rev 267456)
+++ trunk/Source/WebCore/ChangeLog 2020-09-23 03:36:13 UTC (rev 267457)
@@ -1,3 +1,17 @@
+2020-09-22 Lauro Moura <[email protected]>
+
+ [GTK] REGRESSION(r267329): imported/blink/editing/undo/crash-redo-with-iframes.html is crashing
+ https://bugs.webkit.org/show_bug.cgi?id=216778
+
+ Reviewed by Darin Adler.
+
+ Covered by existing tests.
+
+ * editing/markup.cpp:
+ (WebCore::serializePreservingVisualAppearanceInternal): Return early
+ also for "negative" ranges to avoid hitting an assertion inside
+ serializeNodes, as suggested by Darin.
+
2020-09-22 Chris Dumez <[email protected]>
Slightly improve AudioBufferSourceNode resampling
Modified: trunk/Source/WebCore/editing/markup.cpp (267456 => 267457)
--- trunk/Source/WebCore/editing/markup.cpp 2020-09-23 02:38:23 UTC (rev 267456)
+++ trunk/Source/WebCore/editing/markup.cpp 2020-09-23 03:36:13 UTC (rev 267457)
@@ -839,7 +839,7 @@
{
static NeverDestroyed<const String> interchangeNewlineString(MAKE_STATIC_STRING_IMPL("<br class=\"" AppleInterchangeNewline "\">"));
- if (start == end)
+ if (!(start < end))
return emptyString();
auto commonAncestor = commonInclusiveAncestor(start, end);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
