Diff
Modified: trunk/LayoutTests/ChangeLog (267473 => 267474)
--- trunk/LayoutTests/ChangeLog 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/LayoutTests/ChangeLog 2020-09-23 14:44:24 UTC (rev 267474)
@@ -1,3 +1,15 @@
+2020-09-23 Philippe Normand <[email protected]>
+
+ media/can-play-av1.html is not spec compliant
+ https://bugs.webkit.org/show_bug.cgi?id=216873
+
+ Reviewed by Eric Carlson.
+
+ * media/media-can-play-av1-expected.txt: Update baseline.
+ * media/media-can-play-av1.html: Update test and add another few testing invalid codecs.
+ * platform/glib/TestExpectations: Unflag passing test.
+ * platform/mac/media/media-can-play-av1-expected.txt: Added. This test is expected to fail on mac.
+
2020-09-23 Youenn Fablet <[email protected]>
Add support for HTMLMediaElement.setSinkId
Modified: trunk/LayoutTests/media/media-can-play-av1-expected.txt (267473 => 267474)
--- trunk/LayoutTests/media/media-can-play-av1-expected.txt 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/LayoutTests/media/media-can-play-av1-expected.txt 2020-09-23 14:44:24 UTC (rev 267474)
@@ -3,9 +3,11 @@
These tests may be expected to fail if the WebKit port does not support the format.
-EXPECTED (video.canPlayType('video/mp4; codecs=av1') == '') OK
-EXPECTED (video.canPlayType('video/webm; codecs=av1') == '') OK
-EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == '') OK
-EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == '') OK
+EXPECTED (video.canPlayType('video/mp4; codecs=av1') == 'probably') OK
+EXPECTED (video.canPlayType('video/webm; codecs=av1') == 'probably') OK
+EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == 'probably') OK
+EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == 'probably') OK
+EXPECTED (video.canPlayType('video/webm; codecs=aaaav1') == '') OK
+EXPECTED (video.canPlayType('video/mp4; codecs=bbbav1') == '') OK
END OF TEST
Modified: trunk/LayoutTests/media/media-can-play-av1.html (267473 => 267474)
--- trunk/LayoutTests/media/media-can-play-av1.html 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/LayoutTests/media/media-can-play-av1.html 2020-09-23 14:44:24 UTC (rev 267474)
@@ -6,12 +6,14 @@
function start() {
video = mediaElement = document.getElementsByTagName('video')[0];
- testExpected("video.canPlayType('video/mp4; codecs=av1')", "");
- testExpected("video.canPlayType('video/webm; codecs=av1')", "");
+ testExpected("video.canPlayType('video/mp4; codecs=av1')", "probably");
+ testExpected("video.canPlayType('video/webm; codecs=av1')", "probably");
- testExpected("video.canPlayType('video/mp4; codecs=av01.0.04M.08')", "");
- testExpected("video.canPlayType('video/webm; codecs=av01.0.04M.08')", "");
+ testExpected("video.canPlayType('video/mp4; codecs=av01.0.04M.08')", "probably");
+ testExpected("video.canPlayType('video/webm; codecs=av01.0.04M.08')", "probably");
+ testExpected("video.canPlayType('video/webm; codecs=aaaav1')", "");
+ testExpected("video.canPlayType('video/mp4; codecs=bbbav1')", "");
endTest();
}
</script>
Modified: trunk/LayoutTests/platform/glib/TestExpectations (267473 => 267474)
--- trunk/LayoutTests/platform/glib/TestExpectations 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2020-09-23 14:44:24 UTC (rev 267474)
@@ -262,8 +262,6 @@
webkit.org/b/214031 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video-poster-shown-preload-auto.html [ ImageOnlyFailure ]
-webkit.org/b/207547 media/media-can-play-av1.html [ Failure ]
-
webkit.org/b/214422 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/suspend-after-construct.html [ Failure Pass ]
webkit.org/b/215255 imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/audiobuffersource-multi-channels.html [ Failure ]
Added: trunk/LayoutTests/platform/mac/media/media-can-play-av1-expected.txt (0 => 267474)
--- trunk/LayoutTests/platform/mac/media/media-can-play-av1-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/media/media-can-play-av1-expected.txt 2020-09-23 14:44:24 UTC (rev 267474)
@@ -0,0 +1,13 @@
+
+Test HTMLMediaElement canPlayType() method for the AV1 codec.
+
+These tests may be expected to fail if the WebKit port does not support the format.
+
+EXPECTED (video.canPlayType('video/mp4; codecs=av1') == 'probably'), OBSERVED '' FAIL
+EXPECTED (video.canPlayType('video/webm; codecs=av1') == 'probably'), OBSERVED '' FAIL
+EXPECTED (video.canPlayType('video/mp4; codecs=av01.0.04M.08') == 'probably'), OBSERVED '' FAIL
+EXPECTED (video.canPlayType('video/webm; codecs=av01.0.04M.08') == 'probably'), OBSERVED '' FAIL
+EXPECTED (video.canPlayType('video/webm; codecs=aaaav1') == '') OK
+EXPECTED (video.canPlayType('video/mp4; codecs=bbbav1') == '') OK
+END OF TEST
+
Modified: trunk/Source/WebCore/ChangeLog (267473 => 267474)
--- trunk/Source/WebCore/ChangeLog 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/Source/WebCore/ChangeLog 2020-09-23 14:44:24 UTC (rev 267474)
@@ -1,3 +1,13 @@
+2020-09-23 Philippe Normand <[email protected]>
+
+ media/can-play-av1.html is not spec compliant
+ https://bugs.webkit.org/show_bug.cgi?id=216873
+
+ Reviewed by Eric Carlson.
+
+ * platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
+ (WebCore::GStreamerRegistryScanner::initialize): Add the "av1" codec in the codecs mapping.
+
2020-09-23 Youenn Fablet <[email protected]>
Add support for HTMLMediaElement.setSinkId
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp (267473 => 267474)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp 2020-09-23 14:29:29 UTC (rev 267473)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp 2020-09-23 14:44:24 UTC (rev 267474)
@@ -210,6 +210,7 @@
Vector<String> av1DecodersBlacklist { "av1dec"_s };
if ((matroskaSupported || isContainerTypeSupported("video/mp4")) && hasElementForMediaType(m_videoDecoderFactories, "video/x-av1", false, makeOptional(WTFMove(av1DecodersBlacklist)))) {
m_codecMap.add(AtomString("av01*"), false);
+ m_codecMap.add(AtomString("av1"), false);
m_codecMap.add(AtomString("x-av1"), false);
}
