Title: [267479] trunk
- Revision
- 267479
- Author
- [email protected]
- Date
- 2020-09-23 09:03:59 -0700 (Wed, 23 Sep 2020)
Log Message
Unreviewed, reverting r267403.
Caused 50+ Crashes on iOS Debug
Reverted changeset:
"Move Media in GPU Process flag from internal to experimental"
https://bugs.webkit.org/show_bug.cgi?id=216473
https://trac.webkit.org/changeset/267403
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267478 => 267479)
--- trunk/Source/WebKit/ChangeLog 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Source/WebKit/ChangeLog 2020-09-23 16:03:59 UTC (rev 267479)
@@ -1,3 +1,15 @@
+2020-09-23 Truitt Savell <[email protected]>
+
+ Unreviewed, reverting r267403.
+
+ Caused 50+ Crashes on iOS Debug
+
+ Reverted changeset:
+
+ "Move Media in GPU Process flag from internal to experimental"
+ https://bugs.webkit.org/show_bug.cgi?id=216473
+ https://trac.webkit.org/changeset/267403
+
2020-09-23 Youenn Fablet <[email protected]>
Add support for HTMLMediaElement.setSinkId
Modified: trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml (267478 => 267479)
--- trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Source/WebKit/Shared/WebPreferencesExperimental.yaml 2020-09-23 16:03:59 UTC (rev 267479)
@@ -85,14 +85,6 @@
humanReadableName: "requestIdleCallback"
humanReadableDescription: "Enable requestIdleCallback support"
-UseGPUProcessForMedia:
- type: bool
- defaultValue: defaultUseGPUProcessForMedia()
- condition: ENABLE(GPU_PROCESS)
- humanReadableName: "Use GPU Process for media"
- humanReadableDescription: "Do all media loading and playback in the GPU Process"
- webcoreName: useGPUProcessForMedia
-
MediaRecorderEnabled:
type: bool
defaultValue: defaultMediaRecorderEnabled()
Modified: trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml (267478 => 267479)
--- trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Source/WebKit/Shared/WebPreferencesInternal.yaml 2020-09-23 16:03:59 UTC (rev 267479)
@@ -417,6 +417,14 @@
humanReadableName: "[ITP Repro] 30 Second Timeout For Non-Cookie Data Removal"
humanReadableDescription: "Remove all non-cookie website data after just 30 seconds of no user interaction when Intelligent Tracking Prevention is enabled"
+UseGPUProcessForMedia:
+ type: bool
+ defaultValue: defaultUseGPUProcessForMedia()
+ condition: ENABLE(GPU_PROCESS)
+ humanReadableName: "Use GPU Process for media"
+ humanReadableDescription: "Do all media loading and playback in the GPU Process"
+ webcoreName: useGPUProcessForMedia
+
LiveRangeSelectionEnabled:
type: bool
defaultValue: false
Modified: trunk/Tools/ChangeLog (267478 => 267479)
--- trunk/Tools/ChangeLog 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Tools/ChangeLog 2020-09-23 16:03:59 UTC (rev 267479)
@@ -1,3 +1,15 @@
+2020-09-23 Truitt Savell <[email protected]>
+
+ Unreviewed, reverting r267403.
+
+ Caused 50+ Crashes on iOS Debug
+
+ Reverted changeset:
+
+ "Move Media in GPU Process flag from internal to experimental"
+ https://bugs.webkit.org/show_bug.cgi?id=216473
+ https://trac.webkit.org/changeset/267403
+
2020-09-23 Lauro Moura <[email protected]>
REGRESSION(r267368) [webkitpy] autoinstalled pytest raises ImportError in run-webdriver-tests
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (267478 => 267479)
--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py 2020-09-23 16:03:59 UTC (rev 267479)
@@ -381,7 +381,7 @@
options.additional_expectations.insert(0, host.filesystem.join(host.scm().checkout_root, 'LayoutTests/gpu-process/TestExpectations'))
if not options.internal_feature:
options.internal_feature = []
- options.experimental_feature.append('UseGPUProcessForMedia')
+ options.internal_feature.append('UseGPUProcessForMedia')
options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
options.internal_feature.append('RenderCanvasInGPUProcessEnabled')
if options.result_report_flavor:
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (267478 => 267479)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-23 15:57:11 UTC (rev 267478)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-09-23 16:03:59 UTC (rev 267479)
@@ -837,11 +837,6 @@
WKPreferencesResetTestRunnerOverrides(preferences);
WKPreferencesEnableAllExperimentalFeatures(preferences);
- // All experimental features except:
- static WKStringRef webKitUseGPUProcessForMedia = WKStringCreateWithUTF8CString("UseGPUProcessForMedia");
- WKPreferencesSetExperimentalFeatureForKey(preferences, false, webKitUseGPUProcessForMedia);
- static WKStringRef webRTCPlatformCodecsInGPUProcessEnabled = WKStringCreateWithUTF8CString("WebRTCPlatformCodecsInGPUProcessEnabled");
- WKPreferencesSetExperimentalFeatureForKey(preferences, false, webRTCPlatformCodecsInGPUProcessEnabled);
for (const auto& experimentalFeature : options.experimentalFeatures)
WKPreferencesSetExperimentalFeatureForKey(preferences, experimentalFeature.value, toWK(experimentalFeature.key).get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
