[webkit-changes] [267526] trunk

Thu, 24 Sep 2020 04:55:33 -0700

Title: [267526] trunk
Revision
267526
Author
[email protected]
Date
2020-09-24 04:54:00 -0700 (Thu, 24 Sep 2020)

Log Message

Unreviewed, reverting r267495 and r267512.
https://bugs.webkit.org/show_bug.cgi?id=216924

Broke transform-stream.html test

Reverted changesets:

"Missing scope release in JSDOMBuiltinConstructorBase"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267495

"Unreviewed, we should put it under js/dom since it is not
usable in JSC shell"
https://bugs.webkit.org/show_bug.cgi?id=216851
https://trac.webkit.org/changeset/267512

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (267525 => 267526)


--- trunk/LayoutTests/ChangeLog	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/LayoutTests/ChangeLog	2020-09-24 11:54:00 UTC (rev 267526)
@@ -1,5 +1,23 @@
 2020-09-24  Commit Queue  <[email protected]>
 
+        Unreviewed, reverting r267495 and r267512.
+        https://bugs.webkit.org/show_bug.cgi?id=216924
+
+        Broke transform-stream.html test
+
+        Reverted changesets:
+
+        "Missing scope release in JSDOMBuiltinConstructorBase"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267495
+
+        "Unreviewed, we should put it under js/dom since it is not
+        usable in JSC shell"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267512
+
+2020-09-24  Commit Queue  <[email protected]>
+
         Unreviewed, reverting r267507.
         https://bugs.webkit.org/show_bug.cgi?id=216923

Deleted: trunk/LayoutTests/js/dom/script-tests/transform-stream.js (267525 => 267526)


--- trunk/LayoutTests/js/dom/script-tests/transform-stream.js	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/LayoutTests/js/dom/script-tests/transform-stream.js	2020-09-24 11:54:00 UTC (rev 267526)
@@ -1,4 +0,0 @@
-description(
-"Tests exception checking in JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments."
-);
-new TransformStream();

Deleted: trunk/LayoutTests/js/dom/transform-stream-expected.txt (267525 => 267526)


--- trunk/LayoutTests/js/dom/transform-stream-expected.txt	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/LayoutTests/js/dom/transform-stream-expected.txt	2020-09-24 11:54:00 UTC (rev 267526)
@@ -1,9 +0,0 @@
-Tests exception checking in JSDOMBuiltinConstructorBase::callFunctionWithCurrentArguments.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-

Deleted: trunk/LayoutTests/js/dom/transform-stream.html (267525 => 267526)


--- trunk/LayoutTests/js/dom/transform-stream.html	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/LayoutTests/js/dom/transform-stream.html	2020-09-24 11:54:00 UTC (rev 267526)
@@ -1,10 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><!-- webkit-test-runner [ jscOptions=--validateExceptionChecks=true ] -->
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<script src=""
-<script src=""
-</body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (267525 => 267526)


--- trunk/Source/WebCore/ChangeLog	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/Source/WebCore/ChangeLog	2020-09-24 11:54:00 UTC (rev 267526)
@@ -1,5 +1,23 @@
 2020-09-24  Commit Queue  <[email protected]>
 
+        Unreviewed, reverting r267495 and r267512.
+        https://bugs.webkit.org/show_bug.cgi?id=216924
+
+        Broke transform-stream.html test
+
+        Reverted changesets:
+
+        "Missing scope release in JSDOMBuiltinConstructorBase"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267495
+
+        "Unreviewed, we should put it under js/dom since it is not
+        usable in JSC shell"
+        https://bugs.webkit.org/show_bug.cgi?id=216851
+        https://trac.webkit.org/changeset/267512
+
+2020-09-24  Commit Queue  <[email protected]>
+
         Unreviewed, reverting r267507.
         https://bugs.webkit.org/show_bug.cgi?id=216923

Modified: trunk/Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp (267525 => 267526)


--- trunk/Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp	2020-09-24 11:49:36 UTC (rev 267525)
+++ trunk/Source/WebCore/bindings/js/JSDOMBuiltinConstructorBase.cpp	2020-09-24 11:54:00 UTC (rev 267526)
@@ -42,7 +42,6 @@
         throwOutOfMemoryError(&lexicalGlobalObject, scope);
         return;
     }
-    scope.release();
     JSC::call(&lexicalGlobalObject, &function, callData, &thisObject, arguments);
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to