Title: [267537] trunk/Source/WebCore
Revision
267537
Author
[email protected]
Date
2020-09-24 10:47:53 -0700 (Thu, 24 Sep 2020)

Log Message

Drop AudioNode::reset() and all its overrides
https://bugs.webkit.org/show_bug.cgi?id=216932

Reviewed by Eric Carlson.

Drop AudioNode::reset() and all its overrides. This is dead code.

* Modules/webaudio/AnalyserNode.cpp:
* Modules/webaudio/AnalyserNode.h:
* Modules/webaudio/AudioBasicProcessorNode.cpp:
* Modules/webaudio/AudioBasicProcessorNode.h:
* Modules/webaudio/AudioBufferSourceNode.cpp:
* Modules/webaudio/AudioBufferSourceNode.h:
* Modules/webaudio/AudioDestinationNode.h:
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/ChannelMergerNode.cpp:
* Modules/webaudio/ChannelMergerNode.h:
* Modules/webaudio/ChannelSplitterNode.cpp:
* Modules/webaudio/ChannelSplitterNode.h:
* Modules/webaudio/ConstantSourceNode.h:
* Modules/webaudio/ConvolverNode.cpp:
* Modules/webaudio/ConvolverNode.h:
* Modules/webaudio/DynamicsCompressorNode.cpp:
* Modules/webaudio/DynamicsCompressorNode.h:
* Modules/webaudio/GainNode.cpp:
* Modules/webaudio/GainNode.h:
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
* Modules/webaudio/MediaElementAudioSourceNode.h:
* Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
* Modules/webaudio/MediaStreamAudioDestinationNode.h:
* Modules/webaudio/MediaStreamAudioSourceNode.h:
* Modules/webaudio/OscillatorNode.cpp:
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/PannerNode.cpp:
* Modules/webaudio/PannerNode.h:
* Modules/webaudio/RealtimeAnalyser.cpp:
* Modules/webaudio/RealtimeAnalyser.h:
* Modules/webaudio/ScriptProcessorNode.cpp:
* Modules/webaudio/ScriptProcessorNode.h:
* Modules/webaudio/StereoPannerNode.h:
* Modules/webaudio/WebKitAudioPannerNode.cpp:
* Modules/webaudio/WebKitAudioPannerNode.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (267536 => 267537)


--- trunk/Source/WebCore/ChangeLog	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/ChangeLog	2020-09-24 17:47:53 UTC (rev 267537)
@@ -1,3 +1,48 @@
+2020-09-24  Chris Dumez  <[email protected]>
+
+        Drop AudioNode::reset() and all its overrides
+        https://bugs.webkit.org/show_bug.cgi?id=216932
+
+        Reviewed by Eric Carlson.
+
+        Drop AudioNode::reset() and all its overrides. This is dead code.
+
+        * Modules/webaudio/AnalyserNode.cpp:
+        * Modules/webaudio/AnalyserNode.h:
+        * Modules/webaudio/AudioBasicProcessorNode.cpp:
+        * Modules/webaudio/AudioBasicProcessorNode.h:
+        * Modules/webaudio/AudioBufferSourceNode.cpp:
+        * Modules/webaudio/AudioBufferSourceNode.h:
+        * Modules/webaudio/AudioDestinationNode.h:
+        * Modules/webaudio/AudioNode.h:
+        * Modules/webaudio/ChannelMergerNode.cpp:
+        * Modules/webaudio/ChannelMergerNode.h:
+        * Modules/webaudio/ChannelSplitterNode.cpp:
+        * Modules/webaudio/ChannelSplitterNode.h:
+        * Modules/webaudio/ConstantSourceNode.h:
+        * Modules/webaudio/ConvolverNode.cpp:
+        * Modules/webaudio/ConvolverNode.h:
+        * Modules/webaudio/DynamicsCompressorNode.cpp:
+        * Modules/webaudio/DynamicsCompressorNode.h:
+        * Modules/webaudio/GainNode.cpp:
+        * Modules/webaudio/GainNode.h:
+        * Modules/webaudio/MediaElementAudioSourceNode.cpp:
+        * Modules/webaudio/MediaElementAudioSourceNode.h:
+        * Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
+        * Modules/webaudio/MediaStreamAudioDestinationNode.h:
+        * Modules/webaudio/MediaStreamAudioSourceNode.h:
+        * Modules/webaudio/OscillatorNode.cpp:
+        * Modules/webaudio/OscillatorNode.h:
+        * Modules/webaudio/PannerNode.cpp:
+        * Modules/webaudio/PannerNode.h:
+        * Modules/webaudio/RealtimeAnalyser.cpp:
+        * Modules/webaudio/RealtimeAnalyser.h:
+        * Modules/webaudio/ScriptProcessorNode.cpp:
+        * Modules/webaudio/ScriptProcessorNode.h:
+        * Modules/webaudio/StereoPannerNode.h:
+        * Modules/webaudio/WebKitAudioPannerNode.cpp:
+        * Modules/webaudio/WebKitAudioPannerNode.h:
+
 2020-09-24  Carlos Garcia Campos  <[email protected]>
 
         [GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager

Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -104,11 +104,6 @@
         outputBus->copyFrom(*inputBus);
 }
 
-void AnalyserNode::reset()
-{
-    m_analyser.reset();
-}
-
 ExceptionOr<void> AnalyserNode::setFftSize(unsigned size)
 {
     if (!m_analyser.setFftSize(size))

Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -62,7 +62,6 @@
     AnalyserNode(BaseAudioContext&);
 
     void process(size_t framesToProcess) final;
-    void reset() final;
     void updatePullStatus() final;
 
     double tailTime() const final;

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -102,12 +102,6 @@
     input(0)->pull(output(0)->bus(), framesToProcess);
 }
 
-void AudioBasicProcessorNode::reset()
-{
-    if (processor())
-        processor()->reset();
-}
-
 // As soon as we know the channel count of our input, we can lazily initialize.
 // Sometimes this may be called more than once with different channel counts, in which case we must safely
 // uninitialize and then re-initialize with the new channel count.

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBasicProcessorNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -43,7 +43,6 @@
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) override;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;
 

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -425,12 +425,6 @@
     return true;
 }
 
-
-void AudioBufferSourceNode::reset()
-{
-    m_virtualReadIndex = 0;
-}
-
 ExceptionOr<void> AudioBufferSourceNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
 {
     ASSERT(isMainThread());

Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -49,7 +49,6 @@
 
     // AudioNode
     void process(size_t framesToProcess) final;
-    void reset() final;
 
     // setBuffer() is called on the main thread.  This is the buffer we use for playback.
     ExceptionOr<void> setBuffer(RefPtr<AudioBuffer>&&);

Modified: trunk/Source/WebCore/Modules/webaudio/AudioDestinationNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioDestinationNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioDestinationNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -40,7 +40,6 @@
     
     // AudioNode   
     void process(size_t) override { }; // we're pulled by hardware so this is never called
-    void reset() override { m_currentSampleFrame = 0; }
     
     // The audio hardware calls render() to get the next render quantum of audio into destinationBus.
     // It will optionally give us local/live audio input in sourceBus (if it's not 0).

Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/AudioNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -121,10 +121,6 @@
     // no AudioParams need to be updated.
     virtual void processOnlyAudioParams(size_t) { }
 
-    // Resets DSP processing state (clears delay lines, filter memory, etc.)
-    // Called from context's audio thread.
-    virtual void reset() = 0;
-
     // No significant resources should be allocated until initialize() is called.
     // Processing may not occur until a node is initialized.
     virtual void initialize();

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -106,10 +106,6 @@
     }
 }
 
-void ChannelMergerNode::reset()
-{
-}
-
 ExceptionOr<void> ChannelMergerNode::setChannelCount(unsigned channelCount)
 {
     if (channelCount != 1)

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -42,7 +42,6 @@
     
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     ExceptionOr<void> setChannelCount(unsigned) final;
     ExceptionOr<void> setChannelCountMode(ChannelCountMode) final;

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -93,10 +93,6 @@
     }
 }
 
-void ChannelSplitterNode::reset()
-{
-}
-
 ExceptionOr<void> ChannelSplitterNode::setChannelCount(unsigned channelCount)
 {
     if (channelCount != numberOfOutputs())

Modified: trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -38,7 +38,6 @@
 
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     ExceptionOr<void> setChannelCount(unsigned) final;
     ExceptionOr<void> setChannelCountMode(ChannelCountMode) final;

Modified: trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -43,7 +43,6 @@
     
 private:
     void process(size_t framesToProcess) final;
-    void reset() final { };
 
     ConstantSourceNode(BaseAudioContext&, float);
     

Modified: trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ConvolverNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -116,13 +116,6 @@
     }
 }
 
-void ConvolverNode::reset()
-{
-    auto locker = holdLock(m_processMutex);
-    if (m_reverb)
-        m_reverb->reset();
-}
-
 ExceptionOr<void> ConvolverNode::setBuffer(RefPtr<AudioBuffer>&& buffer)
 {
     ASSERT(isMainThread());

Modified: trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ConvolverNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -58,7 +58,6 @@
     bool requiresTailProcessing() const final;
 
     void process(size_t framesToProcess) final;
-    void reset() final;
     void checkNumberOfChannelsForInput(AudioNodeInput*) final;
 
     std::unique_ptr<Reverb> m_reverb;

Modified: trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -115,11 +115,6 @@
     m_release->calculateSampleAccurateValues(values, framesToProcess);
 }
 
-void DynamicsCompressorNode::reset()
-{
-    m_dynamicsCompressor->reset();
-}
-
 void DynamicsCompressorNode::initialize()
 {
     if (isInitialized())

Modified: trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -44,7 +44,6 @@
     // AudioNode
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;
 

Modified: trunk/Source/WebCore/Modules/webaudio/GainNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/GainNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/GainNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -110,10 +110,6 @@
     m_gain->calculateSampleAccurateValues(values, framesToProcess);
 }
 
-void GainNode::reset()
-{
-}
-
 // FIXME: this can go away when we do mixing with gain directly in summing junction of AudioNodeInput
 //
 // As soon as we know the channel count of our input, we can lazily initialize.

Modified: trunk/Source/WebCore/Modules/webaudio/GainNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/GainNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/GainNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -44,7 +44,6 @@
     // AudioNode
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() override;
 
     // Called in the main thread when the number of channels for the input may have changed.
     void checkNumberOfChannelsForInput(AudioNodeInput*) override;

Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -176,10 +176,6 @@
     }
 }
 
-void MediaElementAudioSourceNode::reset()
-{
-}
-
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)

Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -50,7 +50,6 @@
 
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     
     // AudioSourceProviderClient
     void setFormat(size_t numberOfChannels, float sampleRate) override;

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -74,10 +74,6 @@
     m_source->consumeAudio(*input(0)->bus(), numberOfFrames);
 }
 
-void MediaStreamAudioDestinationNode::reset()
-{
-}
-
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO) && ENABLE(MEDIA_STREAM)

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -47,7 +47,6 @@
 
     // AudioNode.
     void process(size_t framesToProcess) final;
-    void reset() final;
     
 private:
     explicit MediaStreamAudioDestinationNode(BaseAudioContext&);

Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -49,7 +49,6 @@
 
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override { }
 
     // AudioSourceProviderClient
     void setFormat(size_t numberOfChannels, float sampleRate) override;

Modified: trunk/Source/WebCore/Modules/webaudio/OscillatorNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/OscillatorNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/OscillatorNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -436,11 +436,6 @@
     outputBus.clearSilentFlag();
 }
 
-void OscillatorNode::reset()
-{
-    m_virtualReadIndex = 0;
-}
-
 void OscillatorNode::setPeriodicWave(PeriodicWave& periodicWave)
 {
     ALWAYS_LOG(LOGIDENTIFIER, "sample rate = ", periodicWave.sampleRate(), ", wave size = ", periodicWave.periodicWaveSize(), ", rate scale = ", periodicWave.rateScale());

Modified: trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/OscillatorNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -57,7 +57,6 @@
 
 private:
     void process(size_t framesToProcess) final;
-    void reset() final;
 
     double tailTime() const final { return 0; }
     double latencyTime() const final { return 0; }

Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -271,12 +271,6 @@
         || m_orientationZ->automationRate() == AutomationRate::ARate;
 }
 
-void PannerNode::reset()
-{
-    if (m_panner.get())
-        m_panner->reset();
-}
-
 void PannerNode::initialize()
 {
     if (isInitialized())

Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/PannerNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -72,7 +72,6 @@
     void process(size_t framesToProcess) override;
     void processOnlyAudioParams(size_t framesToProcess) final;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;
 

Modified: trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -67,13 +67,6 @@
 
 RealtimeAnalyser::~RealtimeAnalyser() = default;
 
-void RealtimeAnalyser::reset()
-{
-    m_writeIndex = 0;
-    m_inputBuffer.zero();
-    m_magnitudeBuffer.zero();
-}
-
 bool RealtimeAnalyser::setFftSize(size_t size)
 {
     ASSERT(isMainThread());

Modified: trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/RealtimeAnalyser.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -42,8 +42,6 @@
 public:
     RealtimeAnalyser();
     virtual ~RealtimeAnalyser();
-    
-    void reset();
 
     size_t fftSize() const { return m_fftSize; }
     bool setFftSize(size_t);

Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -239,17 +239,6 @@
     }
 }
 
-void ScriptProcessorNode::reset()
-{
-    m_bufferReadWriteIndex = 0;
-    m_doubleBufferIndex = 0;
-
-    for (unsigned i = 0; i < 2; ++i) {
-        m_inputBuffers[i]->zero();
-        m_outputBuffers[i]->zero();
-    }
-}
-
 ExceptionOr<void> ScriptProcessorNode::setChannelCount(unsigned channelCount)
 {
     ASSERT(isMainThread());

Modified: trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/ScriptProcessorNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -60,7 +60,6 @@
 
     // AudioNode
     void process(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;
     void didBecomeMarkedForDeletion() override;

Modified: trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -52,7 +52,6 @@
     // AudioNode
     void process(size_t framesToProcess) final;
     void processOnlyAudioParams(size_t framesToProcess) final;
-    void reset() final { };
     bool requiresTailProcessing() const final { return false; }
 
     ExceptionOr<void> setChannelCount(unsigned) final;

Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.cpp	2020-09-24 17:47:53 UTC (rev 267537)
@@ -135,12 +135,6 @@
     destination->copyWithGainFrom(*destination, totalGain);
 }
 
-void WebKitAudioPannerNode::reset()
-{
-    if (m_panner.get())
-        m_panner->reset();
-}
-
 void WebKitAudioPannerNode::initialize()
 {
     if (isInitialized())

Modified: trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.h (267536 => 267537)


--- trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.h	2020-09-24 16:49:54 UTC (rev 267536)
+++ trunk/Source/WebCore/Modules/webaudio/WebKitAudioPannerNode.h	2020-09-24 17:47:53 UTC (rev 267537)
@@ -66,7 +66,6 @@
     // AudioNode
     void process(size_t framesToProcess) override;
     void pullInputs(size_t framesToProcess) override;
-    void reset() override;
     void initialize() override;
     void uninitialize() override;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to