Title: [267545] trunk/Source/WebKit
- Revision
- 267545
- Author
- [email protected]
- Date
- 2020-09-24 14:36:45 -0700 (Thu, 24 Sep 2020)
Log Message
REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
https://bugs.webkit.org/show_bug.cgi?id=216937
<rdar://problem/69149171>
Reviewed by Darin Adler.
Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
Make sure the aliasing happens for macOS so the command doesn't fail frivolously.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::performInteractionSequence):
Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
This is the case for macOS.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267544 => 267545)
--- trunk/Source/WebKit/ChangeLog 2020-09-24 20:10:05 UTC (rev 267544)
+++ trunk/Source/WebKit/ChangeLog 2020-09-24 21:36:45 UTC (rev 267545)
@@ -1,3 +1,19 @@
+2020-09-24 Brian Burg <[email protected]>
+
+ REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=216937
+ <rdar://problem/69149171>
+
+ Reviewed by Darin Adler.
+
+ Before iOS WebDriver shipped, 'Touch' was unconditionally aliased to 'Mouse.'
+ Make sure the aliasing happens for macOS so the command doesn't fail frivolously.
+
+ * UIProcess/Automation/WebAutomationSession.cpp:
+ (WebKit::WebAutomationSession::performInteractionSequence):
+ Alias 'Touch' to 'Mouse' when touch is not available and mouse is.
+ This is the case for macOS.
+
2020-09-24 Kate Cheney <[email protected]>
CrashTracer: com.apple.WebKit.Networking in NetworkSession::firstPartyHostCNAMEDomain() code
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (267544 => 267545)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-09-24 20:10:05 UTC (rev 267544)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2020-09-24 21:36:45 UTC (rev 267545)
@@ -1855,6 +1855,9 @@
#if !ENABLE(WEBDRIVER_MOUSE_INTERACTIONS) && ENABLE(WEBDRIVER_TOUCH_INTERACTIONS)
if (inputSourceType == SimulatedInputSourceType::Mouse)
inputSourceType = SimulatedInputSourceType::Touch;
+#elif ENABLE(WEBDRIVER_MOUSE_INTERACTIONS) && !ENABLE(WEBDRIVER_TOUCH_INTERACTIONS)
+ if (inputSourceType == SimulatedInputSourceType::Touch)
+ inputSourceType = SimulatedInputSourceType::Mouse;
#endif
#if !ENABLE(WEBDRIVER_MOUSE_INTERACTIONS)
if (inputSourceType == SimulatedInputSourceType::Mouse)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
