Title: [267590] trunk/Source/WebCore
- Revision
- 267590
- Author
- [email protected]
- Date
- 2020-09-25 13:19:39 -0700 (Fri, 25 Sep 2020)
Log Message
Simplify SVGTests.hasExtension idl
https://bugs.webkit.org/show_bug.cgi?id=216984
Patch by Rob Buis <[email protected]> on 2020-09-25
Reviewed by Sam Weinig.
Simplify SVGTests.hasExtension idl by removing optional and default parameter.
Skipping the parameter will now result in the parameter being a null string,
which gives the same behaviour as before as the method just checks
against non null namespaces.
[1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
* page/DOMWindow.idl:
* svg/SVGTests.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (267589 => 267590)
--- trunk/Source/WebCore/ChangeLog 2020-09-25 20:11:48 UTC (rev 267589)
+++ trunk/Source/WebCore/ChangeLog 2020-09-25 20:19:39 UTC (rev 267590)
@@ -1,3 +1,20 @@
+2020-09-25 Rob Buis <[email protected]>
+
+ Simplify SVGTests.hasExtension idl
+ https://bugs.webkit.org/show_bug.cgi?id=216984
+
+ Reviewed by Sam Weinig.
+
+ Simplify SVGTests.hasExtension idl by removing optional and default parameter.
+ Skipping the parameter will now result in the parameter being a null string,
+ which gives the same behaviour as before as the method just checks
+ against non null namespaces.
+
+ [1] https://www.w3.org/TR/SVG11/types.html#__svg__SVGTests__hasExtension
+
+ * page/DOMWindow.idl:
+ * svg/SVGTests.idl:
+
2020-09-25 Chris Dumez <[email protected]>
visibilitychange:hidden doesn't fire during page navigations
Modified: trunk/Source/WebCore/page/DOMWindow.idl (267589 => 267590)
--- trunk/Source/WebCore/page/DOMWindow.idl 2020-09-25 20:11:48 UTC (rev 267589)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2020-09-25 20:19:39 UTC (rev 267590)
@@ -156,7 +156,7 @@
[Replaceable, CustomGetter] readonly attribute Event event;
attribute DOMString defaultStatus;
[ImplementedAs=defaultStatus] attribute DOMString defaultstatus; // For compatibility with legacy content.
- boolean find(optional DOMString string, optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false); // FIXME: Using "undefined" as default parameter value is wrong.
+ boolean find(optional DOMString string, optional boolean caseSensitive = false, optional boolean backwards = false, optional boolean wrap = false, optional boolean wholeWord = false, optional boolean searchInFrames = false, optional boolean showDialog = false);
[Replaceable] readonly attribute boolean offscreenBuffering;
[Replaceable] readonly attribute long screenLeft;
[Replaceable] readonly attribute long screenTop;
Modified: trunk/Source/WebCore/svg/SVGTests.idl (267589 => 267590)
--- trunk/Source/WebCore/svg/SVGTests.idl 2020-09-25 20:11:48 UTC (rev 267589)
+++ trunk/Source/WebCore/svg/SVGTests.idl 2020-09-25 20:19:39 UTC (rev 267590)
@@ -33,6 +33,5 @@
// As of SVG2, the following are no longer part of this interface.
[SameObject] readonly attribute SVGStringList requiredFeatures;
- // FIXME: Using "undefined" as default parameter value is wrong.
- boolean hasExtension(optional DOMString extension = "undefined");
+ boolean hasExtension(DOMString extension);
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
