Title: [267620] trunk/Source/WebCore
- Revision
- 267620
- Author
- [email protected]
- Date
- 2020-09-26 06:51:33 -0700 (Sat, 26 Sep 2020)
Log Message
[SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
https://bugs.webkit.org/show_bug.cgi?id=149551
Reviewed by Michael Catanzaro.
The problem is that we are not including all the cookies in the web socket request. There are two cookies with
the Lax same-site policy set, that are not included for the websocket request.
* Modules/websockets/ThreadableWebSocketChannel.cpp:
(WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (267619 => 267620)
--- trunk/Source/WebCore/ChangeLog 2020-09-26 06:48:32 UTC (rev 267619)
+++ trunk/Source/WebCore/ChangeLog 2020-09-26 13:51:33 UTC (rev 267620)
@@ -1,3 +1,16 @@
+2020-09-26 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Slack.com is not working, new messages do not load due to WebSocket authentication failure issue
+ https://bugs.webkit.org/show_bug.cgi?id=149551
+
+ Reviewed by Michael Catanzaro.
+
+ The problem is that we are not including all the cookies in the web socket request. There are two cookies with
+ the Lax same-site policy set, that are not included for the websocket request.
+
+ * Modules/websockets/ThreadableWebSocketChannel.cpp:
+ (WebCore::ThreadableWebSocketChannel::webSocketConnectRequest): Add same site information to WebSocket requests.
+
2020-09-25 Zalan Bujtas <[email protected]>
[LFC][IFC] Incorrect breaking position when inline box content fits the line but the inline content itself does not.
Modified: trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp (267619 => 267620)
--- trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp 2020-09-26 06:48:32 UTC (rev 267619)
+++ trunk/Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp 2020-09-26 13:51:33 UTC (rev 267620)
@@ -33,6 +33,7 @@
#include "ContentRuleListResults.h"
#include "Document.h"
+#include "FrameLoader.h"
#include "HTTPHeaderValues.h"
#include "Page.h"
#include "RuntimeEnabledFeatures.h"
@@ -120,6 +121,7 @@
request.setAllowCookies(validatedURL->areCookiesAllowed);
request.setFirstPartyForCookies(document.firstPartyForCookies());
request.setHTTPHeaderField(HTTPHeaderName::Origin, document.securityOrigin().toString());
+ FrameLoader::addSameSiteInfoToRequestIfNeeded(request, &document);
// Add no-cache headers to avoid compatibility issue.
// There are some proxies that rewrite "Connection: upgrade"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
