Diff
Modified: trunk/LayoutTests/ChangeLog (267651 => 267652)
--- trunk/LayoutTests/ChangeLog 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/ChangeLog 2020-09-27 07:37:26 UTC (rev 267652)
@@ -1,3 +1,18 @@
+2020-09-27 Rob Buis <[email protected]>
+
+ Clean up type parameter for Event idl
+ https://bugs.webkit.org/show_bug.cgi?id=217013
+
+ Reviewed by Chris Dumez.
+
+ Update improved test results.
+
+ * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+ * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+ * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+ * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+ * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+
2020-09-26 Wenson Hsieh <[email protected]>
Remove support for setting CMYKA fill and stroke colors in 2D canvas
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (267651 => 267652)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-27 07:37:26 UTC (rev 267652)
@@ -1,3 +1,14 @@
+2020-09-27 Rob Buis <[email protected]>
+
+ Clean up type parameter for Event idl
+ https://bugs.webkit.org/show_bug.cgi?id=217013
+
+ Reviewed by Chris Dumez.
+
+ Update improved test result.
+
+ * web-platform-tests/html/dom/idlharness.https-expected.txt:
+
2020-09-26 Darin Adler <[email protected]>
Remove trailing spaces from expected.txt files in web-platform-tests/[A-Za-h] minus css, dom, encoding, and html
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -4881,7 +4881,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, boolean, boolean, DOMString, DOMString, DOMString, USVString, Storage)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -5054,7 +5054,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -5044,7 +5044,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -5054,7 +5054,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -5054,7 +5054,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (267651 => 267652)
--- trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2020-09-27 07:37:26 UTC (rev 267652)
@@ -5054,7 +5054,7 @@
PASS StorageEvent interface: attribute newValue
PASS StorageEvent interface: attribute url
PASS StorageEvent interface: attribute storageArea
-FAIL StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?) assert_equals: property has wrong .length expected 1 but got 0
+PASS StorageEvent interface: operation initStorageEvent(DOMString, optional boolean, optional boolean, optional DOMString?, optional DOMString?, optional DOMString?, optional USVString, optional Storage?)
PASS HTMLMarqueeElement interface: existence and properties of interface object
PASS HTMLMarqueeElement interface object length
PASS HTMLMarqueeElement interface object name
Modified: trunk/Source/WebCore/ChangeLog (267651 => 267652)
--- trunk/Source/WebCore/ChangeLog 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/ChangeLog 2020-09-27 07:37:26 UTC (rev 267652)
@@ -1,3 +1,23 @@
+2020-09-27 Rob Buis <[email protected]>
+
+ Clean up type parameter for Event idl
+ https://bugs.webkit.org/show_bug.cgi?id=217013
+
+ Reviewed by Chris Dumez.
+
+ Clean up type parameter for Event idl files, there is no need to
+ pass "undefined" default value.
+
+ * dom/CompositionEvent.idl:
+ * dom/HashChangeEvent.idl:
+ * dom/KeyboardEvent.idl:
+ * dom/MouseEvent.idl:
+ * dom/MutationEvent.idl:
+ * dom/TextEvent.idl:
+ * dom/TouchEvent.idl:
+ * dom/UIEvent.idl:
+ * storage/StorageEvent.idl:
+
2020-09-26 Zalan Bujtas <[email protected]>
[LFC] Add <wbr> to showLayoutTree
Modified: trunk/Source/WebCore/dom/CompositionEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/CompositionEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/CompositionEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -28,8 +28,7 @@
readonly attribute DOMString data;
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initCompositionEvent(optional DOMString typeArg = "undefined",
+ undefined initCompositionEvent(DOMString typeArg,
optional boolean canBubbleArg = false,
optional boolean cancelableArg = false,
optional WindowProxy? viewArg = null,
Modified: trunk/Source/WebCore/dom/HashChangeEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/HashChangeEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/HashChangeEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -21,8 +21,7 @@
interface HashChangeEvent : Event {
constructor(DOMString type, optional HashChangeEventInit eventInitDict);
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initHashChangeEvent(optional DOMString type = "undefined",
+ undefined initHashChangeEvent(DOMString type,
optional boolean canBubble = false,
optional boolean cancelable = false,
optional USVString oldURL = "undefined",
Modified: trunk/Source/WebCore/dom/KeyboardEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/KeyboardEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/KeyboardEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -49,8 +49,7 @@
readonly attribute unsigned long which;
// FIXME: this does not match the version in the DOM spec.
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initKeyboardEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
+ undefined initKeyboardEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
optional WindowProxy? view = null, optional DOMString keyIdentifier = "undefined", optional unsigned long location = 0,
optional boolean ctrlKey = false, optional boolean altKey = false, optional boolean shiftKey = false, optional boolean metaKey = false, optional boolean altGraphKey = false);
};
Modified: trunk/Source/WebCore/dom/MouseEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/MouseEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/MouseEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -43,9 +43,8 @@
[Conditional=POINTER_LOCK] readonly attribute long movementY;
[Conditional=MOUSE_FORCE_EVENTS, ImplementedAs=force]readonly attribute double webkitForce;
- // FIXME: Using "undefined" as default parameter value is wrong.
// FIXME: relatedTarget should be of type EventTarget? but we need to use any to support a quirk for iAd Producer (rdar://problem/30640101).
- [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(optional DOMString type = "undefined",
+ [CallWith=GlobalObject&ScriptExecutionContext, ImplementedAs=initMouseEventQuirk] undefined initMouseEvent(DOMString type,
optional boolean canBubble = false, optional boolean cancelable = false,
optional WindowProxy? view = null, optional long detail = 0,
optional long screenX = 0, optional long screenY = 0, optional long clientX = 0, optional long clientY = 0,
Modified: trunk/Source/WebCore/dom/MutationEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/MutationEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/MutationEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -29,8 +29,7 @@
readonly attribute DOMString attrName;
readonly attribute unsigned short attrChange;
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initMutationEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
+ undefined initMutationEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false,
optional Node? relatedNode = null, optional DOMString prevValue = "undefined", optional DOMString newValue = "undefined",
optional DOMString attrName = "undefined", optional unsigned short attrChange = 0);
};
Modified: trunk/Source/WebCore/dom/TextEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/TextEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/TextEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -28,8 +28,7 @@
readonly attribute DOMString data;
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initTextEvent(optional DOMString typeArg = "undefined",
+ undefined initTextEvent(DOMString typeArg,
optional boolean canBubbleArg = false,
optional boolean cancelableArg = false,
optional WindowProxy? viewArg = null,
Modified: trunk/Source/WebCore/dom/TouchEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/TouchEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/TouchEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -36,11 +36,10 @@
readonly attribute boolean altKey;
readonly attribute boolean metaKey;
- // FIXME: Using "undefined" as default parameter value is wrong.
undefined initTouchEvent(optional TouchList? touches = null,
optional TouchList? targetTouches = null,
optional TouchList? changedTouches = null,
- optional DOMString type = "undefined",
+ optional DOMString type,
optional WindowProxy? view = null,
optional long screenX = 0,
optional long screenY = 0,
Modified: trunk/Source/WebCore/dom/UIEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/dom/UIEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/dom/UIEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -23,8 +23,7 @@
readonly attribute WindowProxy view;
readonly attribute long detail;
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initUIEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
+ undefined initUIEvent(DOMString type, optional boolean canBubble = false, optional boolean cancelable = false, optional WindowProxy? view = null, optional long detail = 0);
readonly attribute long layerX;
readonly attribute long layerY;
Modified: trunk/Source/WebCore/storage/StorageEvent.idl (267651 => 267652)
--- trunk/Source/WebCore/storage/StorageEvent.idl 2020-09-27 06:30:38 UTC (rev 267651)
+++ trunk/Source/WebCore/storage/StorageEvent.idl 2020-09-27 07:37:26 UTC (rev 267652)
@@ -32,8 +32,7 @@
readonly attribute USVString url;
readonly attribute Storage? storageArea;
- // FIXME: Using "undefined" as default parameter value is wrong.
- undefined initStorageEvent(optional DOMString typeArg = "undefined",
+ undefined initStorageEvent(DOMString typeArg,
optional boolean canBubbleArg = false,
optional boolean cancelableArg = false,
optional DOMString keyArg = "undefined",
