Title: [267656] trunk/LayoutTests/imported/w3c
- Revision
- 267656
- Author
- [email protected]
- Date
- 2020-09-27 05:55:58 -0700 (Sun, 27 Sep 2020)
Log Message
Add support to pause in testdriver.js
https://bugs.webkit.org/show_bug.cgi?id=216933
Reviewed by Darin Adler
While simulating a mouse action, pause in dispatchMouseActions() is needed. Otherwise, the events are sent
without delay, the simulation might not be effective. The patch uses JS setTimeout to simulate a pause.
* web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt:
* web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:
* web-platform-tests/resources/testdriver-vendor.js:
(pause): Use setTimeout to simulate a pause.
(dispatchMouseActions):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (267655 => 267656)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-27 12:45:58 UTC (rev 267655)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-09-27 12:55:58 UTC (rev 267656)
@@ -1,3 +1,19 @@
+2020-09-27 Cathie Chen <[email protected]>
+
+ Add support to pause in testdriver.js
+ https://bugs.webkit.org/show_bug.cgi?id=216933
+
+ Reviewed by Darin Adler
+
+ While simulating a mouse action, pause in dispatchMouseActions() is needed. Otherwise, the events are sent
+ without delay, the simulation might not be effective. The patch uses JS setTimeout to simulate a pause.
+
+ * web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt:
+ * web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:
+ * web-platform-tests/resources/testdriver-vendor.js:
+ (pause): Use setTimeout to simulate a pause.
+ (dispatchMouseActions):
+
2020-09-27 Rob Buis <[email protected]>
Alias WebKitCSSMatrix to DOMMatrix
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt (267655 => 267656)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt 2020-09-27 12:45:58 UTC (rev 267655)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt 2020-09-27 12:55:58 UTC (rev 267656)
@@ -8,5 +8,5 @@
Test passes if the pointer capture is not set when the green rectangle gets the pointer lock.
-FAIL mouse no pointercapture while pointerlock assert_equals: Pointer is unlocked expected 2 but got 0
+FAIL mouse no pointercapture while pointerlock assert_greater_than: More than 1 pointermove has been received after unlocked expected a number greater than 1 but got 0
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt (267655 => 267656)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt 2020-09-27 12:45:58 UTC (rev 267655)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt 2020-09-27 12:55:58 UTC (rev 267656)
@@ -9,12 +9,10 @@
Pointer Lock Pointer Events pointermove on button state changes Tests
-The following pointer types were detected: (none).
+The following pointer types were detected: mouse.
Refresh the page to run the tests again.
-Harness Error (TIMEOUT), message = null
+PASS pointer locked pointermove events received for button state changes
-NOTRUN pointer locked pointermove events received for button state changes
-
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (267655 => 267656)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2020-09-27 12:45:58 UTC (rev 267655)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js 2020-09-27 12:55:58 UTC (rev 267656)
@@ -7,6 +7,14 @@
console.log(callback());
}
+function pause(duration) {
+ return new Promise(resolve => {
+ setTimeout(() => {
+ resolve();
+ }, duration);
+ });
+}
+
function dispatchMouseActions(actions)
{
if (!window.eventSender)
@@ -13,7 +21,7 @@
return Promise.reject(new Error("window.eventSender is undefined."));
return new Promise(resolve => {
- setTimeout(() => {
+ setTimeout(async () => {
eventSender.dragMode = false;
for (let action of actions) {
@@ -38,7 +46,8 @@
eventSender.mouseUp(action.button);
break;
case "pause":
- // FIXME: What should we do here?
+ logDebug(() => `pause(${action.duration})`);
+ await pause(action.duration);
break;
default:
return Promise.reject(new Error(`Unknown action type "${action.type}".`));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
