Title: [267668] trunk/Tools
- Revision
- 267668
- Author
- [email protected]
- Date
- 2020-09-27 11:48:00 -0700 (Sun, 27 Sep 2020)
Log Message
Remove run-webkit-tests code that strips trailing spaces when comparing expected.txt files
https://bugs.webkit.org/show_bug.cgi?id=217041
Reviewed by Sam Weinig.
* Scripts/webkitpy/port/base.py:
(Port.do_text_results_differ): Removed code to strip the expected text before comparing.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (267667 => 267668)
--- trunk/Tools/ChangeLog 2020-09-27 16:45:28 UTC (rev 267667)
+++ trunk/Tools/ChangeLog 2020-09-27 18:48:00 UTC (rev 267668)
@@ -1,3 +1,13 @@
+2020-09-27 Darin Adler <[email protected]>
+
+ Remove run-webkit-tests code that strips trailing spaces when comparing expected.txt files
+ https://bugs.webkit.org/show_bug.cgi?id=217041
+
+ Reviewed by Sam Weinig.
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.do_text_results_differ): Removed code to strip the expected text before comparing.
+
2020-09-25 Darin Adler <[email protected]>
Change dumpAsText to strip trailing spaces
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (267667 => 267668)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-09-27 16:45:28 UTC (rev 267667)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-09-27 18:48:00 UTC (rev 267668)
@@ -300,9 +300,6 @@
return False
def do_text_results_differ(self, expected_text, actual_text):
- # Ignore trailing spaces in expected files. We will remove this code after removing trailing spaces from all expected.txt files.
- if not expected_text.startswith("<?xml"):
- expected_text = re.compile(" +$", re.MULTILINE).sub("", expected_text)
return expected_text != actual_text
def do_audio_results_differ(self, expected_audio, actual_audio):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
