Title: [267676] branches/safari-610-branch/Source/WebCore
Revision
267676
Author
[email protected]
Date
2020-09-27 13:00:23 -0700 (Sun, 27 Sep 2020)

Log Message

Cherry-pick r267198. rdar://problem/69594065

    [iOS] YouTube does not route video to AirPlay the first time
    https://bugs.webkit.org/show_bug.cgi?id=216626
    <rdar://problem/62222846>

    Reviewed by Eric Carlson.

    Difficult to test this, since it requires an live AppleTV device.

    During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
    be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
    which explains the "only initial AirPlay fails" behavior.

    * platform/audio/ios/MediaSessionManagerIOS.mm:
    (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (267675 => 267676)


--- branches/safari-610-branch/Source/WebCore/ChangeLog	2020-09-27 20:00:20 UTC (rev 267675)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog	2020-09-27 20:00:23 UTC (rev 267676)
@@ -1,5 +1,44 @@
 2020-09-27  Alan Coon  <[email protected]>
 
+        Cherry-pick r267198. rdar://problem/69594065
+
+    [iOS] YouTube does not route video to AirPlay the first time
+    https://bugs.webkit.org/show_bug.cgi?id=216626
+    <rdar://problem/62222846>
+    
+    Reviewed by Eric Carlson.
+    
+    Difficult to test this, since it requires an live AppleTV device.
+    
+    During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
+    be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
+    which explains the "only initial AirPlay fails" behavior.
+    
+    * platform/audio/ios/MediaSessionManagerIOS.mm:
+    (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-09-17  Jer Noble  <[email protected]>
+
+            [iOS] YouTube does not route video to AirPlay the first time
+            https://bugs.webkit.org/show_bug.cgi?id=216626
+            <rdar://problem/62222846>
+
+            Reviewed by Eric Carlson.
+
+            Difficult to test this, since it requires an live AppleTV device.
+
+            During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
+            be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
+            which explains the "only initial AirPlay fails" behavior.
+
+            * platform/audio/ios/MediaSessionManagerIOS.mm:
+            (WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
+
+2020-09-27  Alan Coon  <[email protected]>
+
         Cherry-pick r267148. rdar://problem/69594002
 
     [macOS] Limit reported macOS release to 10.15 series

Modified: branches/safari-610-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm (267675 => 267676)


--- branches/safari-610-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm	2020-09-27 20:00:20 UTC (rev 267675)
+++ branches/safari-610-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm	2020-09-27 20:00:23 UTC (rev 267676)
@@ -205,8 +205,8 @@
     if (!nowPlayingSession)
         return;
 
+    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
     nowPlayingSession->setShouldPlayToPlaybackTarget(supportsAirPlayVideo == SupportsAirPlayVideo::Yes);
-    nowPlayingSession->setPlaybackTarget(WTFMove(playbackTarget));
 }
 
 void MediaSessionManageriOS::applicationWillEnterForeground(SuspendedUnderLock isSuspendedUnderLock)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to