Title: [267683] branches/safari-610-branch/Source/WebKit
- Revision
- 267683
- Author
- [email protected]
- Date
- 2020-09-27 13:00:43 -0700 (Sun, 27 Sep 2020)
Log Message
Cherry-pick r267412. rdar://problem/69594162
Crashtracer inside PDFPlugin::createScrollbar.
<rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
Reviewed by Tim Horton.
To quote Tim from r264945:
No new tests; timing is such that I can't reproduce without inserting
intentional delays into the main thread hops, which is further than
I'm willing to go for a test.
This is a speculative fix due to the aforementioned reproducibility issue.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
checks. So put an explicit check here followed by an explicit release assert.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610-branch/Source/WebKit/ChangeLog (267682 => 267683)
--- branches/safari-610-branch/Source/WebKit/ChangeLog 2020-09-27 20:00:40 UTC (rev 267682)
+++ branches/safari-610-branch/Source/WebKit/ChangeLog 2020-09-27 20:00:43 UTC (rev 267683)
@@ -1,5 +1,48 @@
2020-09-27 Alan Coon <[email protected]>
+ Cherry-pick r267412. rdar://problem/69594162
+
+ Crashtracer inside PDFPlugin::createScrollbar.
+ <rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
+
+ Reviewed by Tim Horton.
+
+ To quote Tim from r264945:
+ No new tests; timing is such that I can't reproduce without inserting
+ intentional delays into the main thread hops, which is further than
+ I'm willing to go for a test.
+
+ This is a speculative fix due to the aforementioned reproducibility issue.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
+ the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
+ checks. So put an explicit check here followed by an explicit release assert.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-09-22 Brady Eidson <[email protected]>
+
+ Crashtracer inside PDFPlugin::createScrollbar.
+ <rdar://problem/69256031> and https://bugs.webkit.org/show_bug.cgi?id=216810
+
+ Reviewed by Tim Horton.
+
+ To quote Tim from r264945:
+ No new tests; timing is such that I can't reproduce without inserting
+ intentional delays into the main thread hops, which is further than
+ I'm willing to go for a test.
+
+ This is a speculative fix due to the aforementioned reproducibility issue.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::installPDFDocument): With all the past fixes in place, its apparent
+ the plug-in HAS been torn down, and it's somewhat common to bypass the other "hasBeenDestroyed"
+ checks. So put an explicit check here followed by an explicit release assert.
+
+2020-09-27 Alan Coon <[email protected]>
+
Cherry-pick r267394. rdar://problem/69593980
paper.io ad close buttons cannot be iteracted with via trackpad on iPad
Modified: branches/safari-610-branch/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (267682 => 267683)
--- branches/safari-610-branch/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-09-27 20:00:40 UTC (rev 267682)
+++ branches/safari-610-branch/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-09-27 20:00:43 UTC (rev 267683)
@@ -1571,6 +1571,12 @@
ASSERT(isMainThread());
LOG(IncrementalPDF, "Installing PDF document");
+ if (m_hasBeenDestroyed)
+ return;
+
+ // If we haven't been destroyed yet, there must still be a PluginController
+ RELEASE_ASSERT(controller());
+
#if HAVE(INCREMENTAL_PDF_APIS)
maybeClearHighLatencyDataProviderFlag();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
