Title: [104946] trunk/Source
Revision
104946
Author
[email protected]
Date
2012-01-13 09:51:15 -0800 (Fri, 13 Jan 2012)

Log Message

HWndDC is a better name than HwndDC.
https://bugs.webkit.org/show_bug.cgi?id=76281

Reviewed by Darin Adler.

Source/_javascript_Core:

* _javascript_Core.gyp/_javascript_Core.gyp:
* _javascript_Core.gypi:
* wtf/win/HWndDCWin.h: Renamed from Source/_javascript_Core/wtf/win/HwndDCWin.h.
(WTF::HWndDC::HWndDC):
(WTF::HWndDC::~HWndDC):
(WTF::HWndDC::operator HDC):

Source/WebKit/chromium:

* src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (104945 => 104946)


--- trunk/Source/_javascript_Core/ChangeLog	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-01-13 17:51:15 UTC (rev 104946)
@@ -1,3 +1,17 @@
+2012-01-13  David Levin  <[email protected]>
+
+        HWndDC is a better name than HwndDC.
+        https://bugs.webkit.org/show_bug.cgi?id=76281
+
+        Reviewed by Darin Adler.
+
+        * _javascript_Core.gyp/_javascript_Core.gyp:
+        * _javascript_Core.gypi:
+        * wtf/win/HWndDCWin.h: Renamed from Source/_javascript_Core/wtf/win/HwndDCWin.h.
+        (WTF::HWndDC::HWndDC):
+        (WTF::HWndDC::~HWndDC):
+        (WTF::HWndDC::operator HDC):
+
 2012-01-13  YoungTaeck Song  <[email protected]>
 
         [EFL] Add OwnPtr specialization for Eina_Module.

Modified: trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp (104945 => 104946)


--- trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/_javascript_Core/_javascript_Core.gyp/_javascript_Core.gyp	2012-01-13 17:51:15 UTC (rev 104946)
@@ -173,7 +173,7 @@
             ['include', 'Thread(ing|Specific)Win\\.cpp$'],
             ['exclude', 'OSAllocatorPosix\\.cpp$'],
             ['include', 'OSAllocatorWin\\.cpp$'],
-            ['include', 'win/HwndDCWin\\.h$'],
+            ['include', 'win/HWndDCWin\\.h$'],
           ],
           'include_dirs!': [
             '<(SHARED_INTERMEDIATE_DIR)/webkit',

Modified: trunk/Source/_javascript_Core/_javascript_Core.gypi (104945 => 104946)


--- trunk/Source/_javascript_Core/_javascript_Core.gypi	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/_javascript_Core/_javascript_Core.gypi	2012-01-13 17:51:15 UTC (rev 104946)
@@ -648,7 +648,7 @@
             'wtf/unicode/wince/UnicodeWinCE.cpp',
             'wtf/unicode/wince/UnicodeWinCE.h',
             'wtf/win/MainThreadWin.cpp',
-            'wtf/win/HwndDCWin.h',
+            'wtf/win/HWndDCWin.h',
             'wtf/win/OwnPtrWin.cpp',
             'wtf/wince/FastMallocWinCE.h',
             'wtf/wince/MemoryManager.cpp',

Copied: trunk/Source/_javascript_Core/wtf/win/HWndDCWin.h (from rev 104945, trunk/Source/_javascript_Core/wtf/win/HwndDCWin.h) (0 => 104946)


--- trunk/Source/_javascript_Core/wtf/win/HWndDCWin.h	                        (rev 0)
+++ trunk/Source/_javascript_Core/wtf/win/HWndDCWin.h	2012-01-13 17:51:15 UTC (rev 104946)
@@ -0,0 +1,56 @@
+/*
+ * Copyright (C) 2012 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include <windows.h>
+
+namespace WTF {
+
+class HWndDC {
+public:
+    explicit HWndDC(HWND hwnd)
+        : m_hwnd(hwnd)
+        , m_hdc(::GetDC(hwnd))
+    {
+    }
+
+    ~HWndDC()
+    {
+        if (m_hdc)
+            ::ReleaseDC(m_hwnd, m_hdc);
+    }
+
+    operator HDC()
+    {
+        return m_hdc;
+    }
+
+private:
+    HWND m_hwnd;
+    HDC m_hdc;
+};
+
+}
+
+using WTF::HWndDC;

Property changes: trunk/Source/_javascript_Core/wtf/win/HWndDCWin.h


Added: svn:eol-style

Deleted: trunk/Source/_javascript_Core/wtf/win/HwndDCWin.h (104945 => 104946)


--- trunk/Source/_javascript_Core/wtf/win/HwndDCWin.h	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/_javascript_Core/wtf/win/HwndDCWin.h	2012-01-13 17:51:15 UTC (rev 104946)
@@ -1,56 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
- * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
- * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
- * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
- * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
- * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include <windows.h>
-
-namespace WTF {
-
-class HwndDC {
-public:
-    explicit HwndDC(HWND hwnd)
-        : m_hwnd(hwnd)
-        , m_hdc(::GetDC(hwnd))
-    {
-    }
-
-    ~HwndDC()
-    {
-        if (m_hdc)
-            ::ReleaseDC(m_hwnd, m_hdc);
-    }
-
-    operator HDC()
-    {
-        return m_hdc;
-    }
-
-private:
-    HWND m_hwnd;
-    HDC m_hdc;
-};
-
-}
-
-using WTF::HwndDC;

Modified: trunk/Source/WebKit/chromium/ChangeLog (104945 => 104946)


--- trunk/Source/WebKit/chromium/ChangeLog	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-01-13 17:51:15 UTC (rev 104946)
@@ -1,3 +1,13 @@
+2012-01-13  David Levin  <[email protected]>
+
+        HWndDC is a better name than HwndDC.
+        https://bugs.webkit.org/show_bug.cgi?id=76281
+
+        Reviewed by Darin Adler.
+
+        * src/win/WebScreenInfoFactory.cpp:
+        (WebKit::WebScreenInfoFactory::screenInfo):
+
 2012-01-13  Sheriff Bot  <[email protected]>
 
         Unreviewed.  Rolled DEPS.

Modified: trunk/Source/WebKit/chromium/src/win/WebScreenInfoFactory.cpp (104945 => 104946)


--- trunk/Source/WebKit/chromium/src/win/WebScreenInfoFactory.cpp	2012-01-13 17:43:17 UTC (rev 104945)
+++ trunk/Source/WebKit/chromium/src/win/WebScreenInfoFactory.cpp	2012-01-13 17:51:15 UTC (rev 104946)
@@ -33,7 +33,7 @@
 
 #include "WebScreenInfo.h"
 
-#include <wtf/win/HwndDCWin.h>
+#include <wtf/win/HWndDCWin.h>
 
 #include <windows.h>
 
@@ -62,7 +62,7 @@
     devMode.dmDriverExtra = 0;
     EnumDisplaySettings(monitorInfo.szDevice, ENUM_CURRENT_SETTINGS, &devMode);
 
-    HwndDC hdc(0);
+    HWndDC hdc(0);
     ASSERT(hdc);
 
     WebScreenInfo results;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to