Title: [267691] trunk/Source/WebKit
- Revision
- 267691
- Author
- [email protected]
- Date
- 2020-09-27 21:39:28 -0700 (Sun, 27 Sep 2020)
Log Message
REGRESSION(r267688) [GTK] Many compositing timeouts
https://bugs.webkit.org/show_bug.cgi?id=217044
Reviewed by Darin Adler.
Especulative fix by adding missing finalize step to
updateRendering (or calling isolatedUpdateRendering).
Covered by existing tests.
* WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
Call finalizeUpdateRendering.
(WebKit::DrawingAreaCoordinatedGraphics::display): Ditto.
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
(WebKit::LayerTreeHost::flushAndRenderLayers): Call
isolatedUpdateRendering instead of updateRendering on the corePage().
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (267690 => 267691)
--- trunk/Source/WebKit/ChangeLog 2020-09-28 01:52:17 UTC (rev 267690)
+++ trunk/Source/WebKit/ChangeLog 2020-09-28 04:39:28 UTC (rev 267691)
@@ -1,3 +1,23 @@
+2020-09-27 Lauro Moura <[email protected]>
+
+ REGRESSION(r267688) [GTK] Many compositing timeouts
+ https://bugs.webkit.org/show_bug.cgi?id=217044
+
+ Reviewed by Darin Adler.
+
+ Especulative fix by adding missing finalize step to
+ updateRendering (or calling isolatedUpdateRendering).
+
+ Covered by existing tests.
+
+ * WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
+ (WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
+ Call finalizeUpdateRendering.
+ (WebKit::DrawingAreaCoordinatedGraphics::display): Ditto.
+ * WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
+ (WebKit::LayerTreeHost::flushAndRenderLayers): Call
+ isolatedUpdateRendering instead of updateRendering on the corePage().
+
2020-09-25 Simon Fraser <[email protected]>
WebKitLegacy should call Page::finalizeRenderingUpdate()
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp (267690 => 267691)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-09-28 01:52:17 UTC (rev 267690)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp 2020-09-28 04:39:28 UTC (rev 267691)
@@ -414,6 +414,7 @@
m_webPage.setDeviceScaleFactor(deviceScaleFactor);
m_webPage.setSize(size);
m_webPage.updateRendering();
+ m_webPage.finalizeRenderingUpdate({ });
m_webPage.flushPendingEditorStateUpdate();
m_webPage.scrollMainFrameIfNotAtMaxScrollPosition(scrollOffset);
@@ -751,6 +752,7 @@
ASSERT(!m_webPage.size().isEmpty());
m_webPage.updateRendering();
+ m_webPage.finalizeRenderingUpdate({ });
m_webPage.flushPendingEditorStateUpdate();
// The layout may have put the page into accelerated compositing mode. If the LayerTreeHost is
Modified: trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp (267690 => 267691)
--- trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp 2020-09-28 01:52:17 UTC (rev 267690)
+++ trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp 2020-09-28 04:39:28 UTC (rev 267691)
@@ -196,7 +196,7 @@
if (!enabled())
return;
- m_webPage.corePage()->updateRendering();
+ m_webPage.corePage()->isolatedUpdateRendering();
if (!flushPendingLayerChanges())
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
