Title: [267866] trunk
- Revision
- 267866
- Author
- [email protected]
- Date
- 2020-10-01 23:06:28 -0700 (Thu, 01 Oct 2020)
Log Message
update FormData to latest spec webidl
https://bugs.webkit.org/show_bug.cgi?id=171589
Patch by Rob Buis <[email protected]> on 2020-10-01
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Update improved test result.
* web-platform-tests/xhr/formdata-expected.txt:
Source/WebCore:
Change FormData contructor to not take optional, nullable
parameter.
Test: imported/w3c/web-platform-tests/xhr/formdata.html
* html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData):
* html/DOMFormData.h:
(WebCore::DOMFormData::create):
* html/DOMFormData.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (267865 => 267866)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-10-02 01:42:14 UTC (rev 267865)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-10-02 06:06:28 UTC (rev 267866)
@@ -1,3 +1,14 @@
+2020-10-01 Rob Buis <[email protected]>
+
+ update FormData to latest spec webidl
+ https://bugs.webkit.org/show_bug.cgi?id=171589
+
+ Reviewed by Alex Christensen.
+
+ Update improved test result.
+
+ * web-platform-tests/xhr/formdata-expected.txt:
+
2020-10-01 Alex Christensen <[email protected]>
Non-special URLs are not idempotent
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/formdata-expected.txt (267865 => 267866)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/formdata-expected.txt 2020-10-02 01:42:14 UTC (rev 267865)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/formdata-expected.txt 2020-10-02 06:06:28 UTC (rev 267866)
@@ -2,7 +2,7 @@
-FAIL Constructors should throw a type error assert_throws_js: function "() => { new FormData(null); }" did not throw
+PASS Constructors should throw a type error
PASS empty formdata
PASS formdata with string
PASS formdata with named string
Modified: trunk/Source/WebCore/ChangeLog (267865 => 267866)
--- trunk/Source/WebCore/ChangeLog 2020-10-02 01:42:14 UTC (rev 267865)
+++ trunk/Source/WebCore/ChangeLog 2020-10-02 06:06:28 UTC (rev 267866)
@@ -1,3 +1,21 @@
+2020-10-01 Rob Buis <[email protected]>
+
+ update FormData to latest spec webidl
+ https://bugs.webkit.org/show_bug.cgi?id=171589
+
+ Reviewed by Alex Christensen.
+
+ Change FormData contructor to not take optional, nullable
+ parameter.
+
+ Test: imported/w3c/web-platform-tests/xhr/formdata.html
+
+ * html/DOMFormData.cpp:
+ (WebCore::DOMFormData::DOMFormData):
+ * html/DOMFormData.h:
+ (WebCore::DOMFormData::create):
+ * html/DOMFormData.idl:
+
2020-10-01 Sam Weinig <[email protected]>
[WebIDL] Add support for non-nullable optional wrapper type arguments to operations
Modified: trunk/Source/WebCore/html/DOMFormData.idl (267865 => 267866)
--- trunk/Source/WebCore/html/DOMFormData.idl 2020-10-02 01:42:14 UTC (rev 267865)
+++ trunk/Source/WebCore/html/DOMFormData.idl 2020-10-02 06:06:28 UTC (rev 267866)
@@ -37,7 +37,7 @@
InterfaceName=FormData,
ImplementationLacksVTable,
] interface DOMFormData {
- constructor(optional HTMLFormElement? form);
+ constructor(optional HTMLFormElement form);
undefined append(USVString name, USVString value);
undefined append(USVString name, Blob blobValue, optional USVString filename);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
