Title: [267926] trunk
- Revision
- 267926
- Author
- [email protected]
- Date
- 2020-10-03 09:21:36 -0700 (Sat, 03 Oct 2020)
Log Message
[macOS] Enable date, time, and datetime-local input types
https://bugs.webkit.org/show_bug.cgi?id=217229
<rdar://problem/69882757>
Reviewed by Sam Weinig.
Source/WTF:
* Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
Update test expectations now that these input types no longer fallback
to text fields. Also removed the test for input type=datetime, as it
has been removed from the spec.
* TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
(-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (267925 => 267926)
--- trunk/Source/WTF/ChangeLog 2020-10-03 16:12:16 UTC (rev 267925)
+++ trunk/Source/WTF/ChangeLog 2020-10-03 16:21:36 UTC (rev 267926)
@@ -1,3 +1,13 @@
+2020-10-03 Aditya Keerthi <[email protected]>
+
+ [macOS] Enable date, time, and datetime-local input types
+ https://bugs.webkit.org/show_bug.cgi?id=217229
+ <rdar://problem/69882757>
+
+ Reviewed by Sam Weinig.
+
+ * Scripts/Preferences/WebPreferencesInternal.yaml:
+
2020-10-02 Alex Christensen <[email protected]>
Copy host from base file URL
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (267925 => 267926)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2020-10-03 16:12:16 UTC (rev 267925)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2020-10-03 16:21:36 UTC (rev 267926)
@@ -300,8 +300,8 @@
WebKitLegacy:
default: false
WebKit:
- "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
- default: false
+ "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
+ default: true
InputTypeDateTimeLocalEnabled:
type: bool
@@ -312,8 +312,8 @@
WebKitLegacy:
default: false
WebKit:
- "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
- default: false
+ "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
+ default: true
InputTypeMonthEnabled:
type: bool
@@ -336,8 +336,8 @@
WebKitLegacy:
default: false
WebKit:
- "!PLATFORM(MAC) && !PLATFORM(MACCATALYST) && !PLATFORM(APPLETV)": true
- default: false
+ "PLATFORM(MACCATALYST) || PLATFORM(APPLETV)": false
+ default: true
InputTypeWeekEnabled:
type: bool
Modified: trunk/Tools/ChangeLog (267925 => 267926)
--- trunk/Tools/ChangeLog 2020-10-03 16:12:16 UTC (rev 267925)
+++ trunk/Tools/ChangeLog 2020-10-03 16:21:36 UTC (rev 267926)
@@ -1,3 +1,18 @@
+2020-10-03 Aditya Keerthi <[email protected]>
+
+ [macOS] Enable date, time, and datetime-local input types
+ https://bugs.webkit.org/show_bug.cgi?id=217229
+ <rdar://problem/69882757>
+
+ Reviewed by Sam Weinig.
+
+ Update test expectations now that these input types no longer fallback
+ to text fields. Also removed the test for input type=datetime, as it
+ has been removed from the spec.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
+ (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
+
2020-10-02 Yusuke Suzuki <[email protected]>
std::once_flag must be allocated in static storage
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm (267925 => 267926)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm 2020-10-03 16:12:16 UTC (rev 267925)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm 2020-10-03 16:21:36 UTC (rev 267926)
@@ -60,9 +60,6 @@
NSMutableArray <NSString *> *failedInputTypes = [NSMutableArray array];
- [self verifyTextFieldForHTMLInputType:@"date" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
- [self verifyTextFieldForHTMLInputType:@"datetime" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
- [self verifyTextFieldForHTMLInputType:@"datetime-local" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"email" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"month" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"number" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
@@ -70,7 +67,6 @@
[self verifyTextFieldForHTMLInputType:@"search" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"tel" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"text" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
- [self verifyTextFieldForHTMLInputType:@"time" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"url" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"week" document:document jsContext:jsContext expectedResult:YES failedInputTypes:failedInputTypes];
@@ -78,6 +74,8 @@
#if ENABLE_INPUT_TYPE_COLOR
[self verifyTextFieldForHTMLInputType:@"color" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
#endif
+ [self verifyTextFieldForHTMLInputType:@"date" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
+ [self verifyTextFieldForHTMLInputType:@"datetime-local" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"file" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"hidden" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"image" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
@@ -85,6 +83,7 @@
[self verifyTextFieldForHTMLInputType:@"range" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"reset" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
[self verifyTextFieldForHTMLInputType:@"submit" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
+ [self verifyTextFieldForHTMLInputType:@"time" document:document jsContext:jsContext expectedResult:NO failedInputTypes:failedInputTypes];
if (!failedInputTypes.count) {
[[[browserContextController mainFrame] jsContextForWorld:[WKWebProcessPlugInScriptWorld normalWorld]] evaluateScript:@"alert('isTextField success')"];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
