Title: [268134] trunk/Tools
- Revision
- 268134
- Author
- basuke.suz...@sony.com
- Date
- 2020-10-07 11:04:46 -0700 (Wed, 07 Oct 2020)
Log Message
[build-webkit] Compare with cmakeargs and unhandled to detect configuration change
https://bugs.webkit.org/show_bug.cgi?id=207012
Reviewed by Carlos Alberto Lopez Perez.
Added command line arguments on top of @featureArgs for comparison with previous build
options. This forces regeneration of CMakeCache.txt when any configuration is changed.
* Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (268133 => 268134)
--- trunk/Tools/ChangeLog 2020-10-07 18:02:52 UTC (rev 268133)
+++ trunk/Tools/ChangeLog 2020-10-07 18:04:46 UTC (rev 268134)
@@ -1,3 +1,16 @@
+2020-10-07 Basuke Suzuki <basuke.suz...@sony.com>
+
+ [build-webkit] Compare with cmakeargs and unhandled to detect configuration change
+ https://bugs.webkit.org/show_bug.cgi?id=207012
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ Added command line arguments on top of @featureArgs for comparison with previous build
+ options. This forces regeneration of CMakeCache.txt when any configuration is changed.
+
+ * Scripts/webkitdirs.pm:
+ (shouldRemoveCMakeCache):
+
2020-10-07 Aakash Jain <aakash_j...@apple.com>
[build.webkit.org] Ensure that invalid step names are not allowed
Modified: trunk/Tools/Scripts/webkitdirs.pm (268133 => 268134)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-10-07 18:02:52 UTC (rev 268133)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-10-07 18:04:46 UTC (rev 268134)
@@ -161,6 +161,7 @@
my $xcodeVersion;
my $unknownPortProhibited = 0;
+my @originalArgv = @ARGV;
# Variables for Win32 support
my $programFilesPath;
@@ -2327,7 +2328,7 @@
sub shouldRemoveCMakeCache(@)
{
- my (@buildArgs) = @_;
+ my (@buildArgs) = sort (@_, @originalArgv);
# We check this first, because we always want to create this file for a fresh build.
my $productDir = File::Spec->catdir(baseProductDir(), configuration());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
