Title: [105005] trunk
- Revision
- 105005
- Author
- [email protected]
- Date
- 2012-01-13 15:56:26 -0800 (Fri, 13 Jan 2012)
Log Message
REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254
Reviewed by Anders Carlsson.
Source/WebCore:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.
LayoutTests:
* svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.
Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.
* svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (105004 => 105005)
--- trunk/LayoutTests/ChangeLog 2012-01-13 23:52:14 UTC (rev 105004)
+++ trunk/LayoutTests/ChangeLog 2012-01-13 23:56:26 UTC (rev 105005)
@@ -1,3 +1,15 @@
+2012-01-13 Dan Bernstein <[email protected]>
+
+ REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
+ https://bugs.webkit.org/show_bug.cgi?id=76254
+
+ Reviewed by Anders Carlsson.
+
+ * svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.
+ Otherwise, the WebHTMLView may have zero size, causing the hit test in
+ -[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.
+ * svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.
+
2012-01-13 Nate Chapin <[email protected]>
http/tests/multipart/invalid-image-data.html should no longer
Modified: trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg (105004 => 105005)
--- trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg 2012-01-13 23:52:14 UTC (rev 105004)
+++ trunk/LayoutTests/svg/custom/pointer-events-invalid-fill.svg 2012-01-13 23:56:26 UTC (rev 105005)
@@ -64,6 +64,7 @@
}
function runTest() {
if (window.eventSender) {
+ document.documentElement.offsetLeft;
eventSender.mouseMoveTo(30, 100);
}
}
Modified: trunk/LayoutTests/svg/custom/resources/use-instanceRoot-event-listeners.js (105004 => 105005)
--- trunk/LayoutTests/svg/custom/resources/use-instanceRoot-event-listeners.js 2012-01-13 23:52:14 UTC (rev 105004)
+++ trunk/LayoutTests/svg/custom/resources/use-instanceRoot-event-listeners.js 2012-01-13 23:56:26 UTC (rev 105005)
@@ -171,6 +171,7 @@
// Start tests
if (window.eventSender) {
+ document.documentElement.offsetLeft;
eventSender.mouseMoveTo(115, 55);
driveTests();
} else
Modified: trunk/Source/WebCore/ChangeLog (105004 => 105005)
--- trunk/Source/WebCore/ChangeLog 2012-01-13 23:52:14 UTC (rev 105004)
+++ trunk/Source/WebCore/ChangeLog 2012-01-13 23:56:26 UTC (rev 105005)
@@ -1,3 +1,15 @@
+2012-01-13 Dan Bernstein <[email protected]>
+
+ REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
+ https://bugs.webkit.org/show_bug.cgi?id=76254
+
+ Reviewed by Anders Carlsson.
+
+ * css/CSSFontSelector.cpp:
+ (WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
+ CachedResourceLoader::loadDone() after decrementing the request count. This allows the
+ frame loader to see that the request count is zero and dispatch didFinishLoad.
+
2012-01-13 Jer Noble <[email protected]>
WebAudio: Optimize calculateNormalizationScale().
Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (105004 => 105005)
--- trunk/Source/WebCore/css/CSSFontSelector.cpp 2012-01-13 23:52:14 UTC (rev 105004)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp 2012-01-13 23:56:26 UTC (rev 105005)
@@ -615,6 +615,8 @@
// Balances incrementRequestCount() in beginLoadingFontSoon().
cachedResourceLoader->decrementRequestCount(fontsToBeginLoading[i].get());
}
+ // Ensure that if the request count reaches zero, the frame loader will know about it.
+ cachedResourceLoader->loadDone();
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
