Title: [105007] trunk
Revision
105007
Author
[email protected]
Date
2012-01-13 16:01:56 -0800 (Fri, 13 Jan 2012)

Log Message

noteOn, noteGrainOn and noteOff idl should take doubles
https://bugs.webkit.org/show_bug.cgi?id=76073

Patch by Raymond Toy <[email protected]> on 2012-01-13
Reviewed by Adam Barth.

Source/WebCore:

Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.

* webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and
noteOff take doubles.

LayoutTests:

* webaudio/audiobuffersource-playbackrate-expected.wav: Updated
* webaudio/gain-expected.wav: Updated

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (105006 => 105007)


--- trunk/LayoutTests/ChangeLog	2012-01-13 23:58:22 UTC (rev 105006)
+++ trunk/LayoutTests/ChangeLog	2012-01-14 00:01:56 UTC (rev 105007)
@@ -1,3 +1,13 @@
+2012-01-13  Raymond Toy  <[email protected]>
+
+        noteOn, noteGrainOn and noteOff idl should take doubles
+        https://bugs.webkit.org/show_bug.cgi?id=76073
+
+        Reviewed by Adam Barth.
+
+        * webaudio/audiobuffersource-playbackrate-expected.wav: Updated
+        * webaudio/gain-expected.wav: Updated
+
 2012-01-13  Dan Bernstein  <[email protected]>
 
         REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots

Modified: trunk/LayoutTests/webaudio/audiobuffersource-playbackrate-expected.wav


(Binary files differ)

Modified: trunk/LayoutTests/webaudio/gain-expected.wav


(Binary files differ)

Modified: trunk/Source/WebCore/ChangeLog (105006 => 105007)


--- trunk/Source/WebCore/ChangeLog	2012-01-13 23:58:22 UTC (rev 105006)
+++ trunk/Source/WebCore/ChangeLog	2012-01-14 00:01:56 UTC (rev 105007)
@@ -1,3 +1,16 @@
+2012-01-13  Raymond Toy  <[email protected]>
+
+        noteOn, noteGrainOn and noteOff idl should take doubles
+        https://bugs.webkit.org/show_bug.cgi?id=76073
+
+        Reviewed by Adam Barth.
+
+        Existing audiobuffersource-playbackrate and gain tests cover the
+        noteOn and noteOff changes.
+
+        * webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and
+        noteOff take doubles.
+
 2012-01-13  Beth Dakin  <[email protected]>
 
         https://bugs.webkit.org/show_bug.cgi?id=71230

Modified: trunk/Source/WebCore/webaudio/AudioBufferSourceNode.idl (105006 => 105007)


--- trunk/Source/WebCore/webaudio/AudioBufferSourceNode.idl	2012-01-13 23:58:22 UTC (rev 105006)
+++ trunk/Source/WebCore/webaudio/AudioBufferSourceNode.idl	2012-01-14 00:01:56 UTC (rev 105007)
@@ -37,8 +37,8 @@
         attribute boolean loop; // This is the proper attribute name from the specification.
         attribute boolean looping; // This is an alias for the .loop attribute for backwards compatibility.
 
-        void noteOn(in float when);
-        void noteGrainOn(in float when, in float grainOffset, in float grainDuration);
-        void noteOff(in float when);
+        void noteOn(in double when);
+        void noteGrainOn(in double when, in double grainOffset, in double grainDuration);
+        void noteOff(in double when);
     };
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to