Title: [268278] trunk/Source/WebKit
- Revision
- 268278
- Author
- [email protected]
- Date
- 2020-10-09 12:35:48 -0700 (Fri, 09 Oct 2020)
Log Message
[GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=217491
<rdar://problem/70066087>
Reviewed by Youenn Fablet.
Currently, the creation of the dynamic IOKit sandbox extensions for the WebContent process is incorrectly using the same GPU
runtime settings as when creating Media related dynamic mach-lookup extensions. There are several other GPU runtime flags
that needs to be checked before creating the extensions.
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (268277 => 268278)
--- trunk/Source/WebKit/ChangeLog 2020-10-09 19:34:06 UTC (rev 268277)
+++ trunk/Source/WebKit/ChangeLog 2020-10-09 19:35:48 UTC (rev 268278)
@@ -1,3 +1,18 @@
+2020-10-09 Per Arne Vollan <[email protected]>
+
+ [GPU Process] Use correct GPU runtime settings when creating the dynamic IOKit sandbox extensions for the WebContent process
+ https://bugs.webkit.org/show_bug.cgi?id=217491
+ <rdar://problem/70066087>
+
+ Reviewed by Youenn Fablet.
+
+ Currently, the creation of the dynamic IOKit sandbox extensions for the WebContent process is incorrectly using the same GPU
+ runtime settings as when creating Media related dynamic mach-lookup extensions. There are several other GPU runtime flags
+ that needs to be checked before creating the extensions.
+
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+
2020-10-09 Chris Fleizach <[email protected]>
AX: Mark malware safe browser as a header for VoiceOver
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (268277 => 268278)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-10-09 19:34:06 UTC (rev 268277)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-10-09 19:35:48 UTC (rev 268278)
@@ -479,9 +479,15 @@
if (needWebProcessExtensions) {
// FIXME(207716): The following should be removed when the GPU process is complete.
parameters.mediaExtensionHandles = SandboxExtension::createHandlesForMachLookup(mediaRelatedMachServices(), WTF::nullopt);
- parameters.gpuIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(gpuIOKitClasses(), WTF::nullopt);
}
+ if (!m_defaultPageGroup->preferences().useGPUProcessForMediaEnabled()
+ || (!m_defaultPageGroup->preferences().captureVideoInGPUProcessEnabled() && !m_defaultPageGroup->preferences().captureVideoInUIProcessEnabled())
+ || !m_defaultPageGroup->preferences().useGPUProcessForCanvasRenderingEnabled()
+ || !m_defaultPageGroup->preferences().useGPUProcessForDOMRenderingEnabled()
+ || !m_defaultPageGroup->preferences().useGPUProcessForWebGLEnabled())
+ parameters.gpuIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(gpuIOKitClasses(), WTF::nullopt);
+
#if ENABLE(CFPREFS_DIRECT_MODE) && PLATFORM(IOS_FAMILY)
if (_AXSApplicationAccessibilityEnabled())
parameters.preferencesExtensionHandles = SandboxExtension::createHandlesForMachLookup({ "com.apple.cfprefsd.agent"_s, "com.apple.cfprefsd.daemon"_s }, WTF::nullopt);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
