Title: [268284] trunk/Source/_javascript_Core
Revision
268284
Author
[email protected]
Date
2020-10-09 13:04:13 -0700 (Fri, 09 Oct 2020)

Log Message

Enable WeakRefs/FinalizationRegistries by default.
https://bugs.webkit.org/show_bug.cgi?id=215789

Reviewed by Yusuke Suzuki.

* runtime/OptionsList.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (268283 => 268284)


--- trunk/Source/_javascript_Core/ChangeLog	2020-10-09 20:03:48 UTC (rev 268283)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-10-09 20:04:13 UTC (rev 268284)
@@ -1,5 +1,14 @@
 2020-10-09  Keith Miller  <[email protected]>
 
+        Enable WeakRefs/FinalizationRegistries by default.
+        https://bugs.webkit.org/show_bug.cgi?id=215789
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/OptionsList.h:
+
+2020-10-09  Keith Miller  <[email protected]>
+
         Finalizers shouldn't run if events can't fire
         https://bugs.webkit.org/show_bug.cgi?id=214508
 

Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (268283 => 268284)


--- trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-10-09 20:03:48 UTC (rev 268283)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h	2020-10-09 20:04:13 UTC (rev 268284)
@@ -489,8 +489,7 @@
     v(Bool, useEagerWebAssemblyModuleHashing, false, Normal, "Unnamed WebAssembly modules are identified in backtraces through their hash, if available.") \
     v(Bool, useWebAssemblyReferences, false, Normal, "Allow types from the wasm references spec.") \
     v(Bool, useWebAssemblyMultiValues, true, Normal, "Allow types from the wasm mulit-values spec.") \
-    /* FIXME: We should make sure finalizers don't run for detached windows before enabling WeakRefs by default. https://bugs.webkit.org/show_bug.cgi?id=214508 */ \
-    v(Bool, useWeakRefs, false, Normal, "Expose the WeakRef constructor.") \
+    v(Bool, useWeakRefs, true, Normal, "Expose the WeakRef constructor.") \
     v(Bool, useIntlDateTimeFormatDayPeriod, true, Normal, "Expose the Intl.DateTimeFormat dayPeriod feature.") \
     v(Bool, useArrayAllocationProfiling, true, Normal, "If true, we will use our normal array allocation profiling. If false, the allocation profile will always claim to be undecided.") \
     v(Bool, forcePolyProto, false, Normal, "If true, create_this will always create an object with a poly proto structure.") \
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to