Title: [268328] trunk/Source/WebKit
- Revision
- 268328
- Author
- commit-qu...@webkit.org
- Date
- 2020-10-11 17:16:53 -0700 (Sun, 11 Oct 2020)
Log Message
-Wreorder in MediaPlayerPrivateRemote.cpp
https://bugs.webkit.org/show_bug.cgi?id=217590
Patch by Michael Catanzaro <mcatanz...@gnome.org> on 2020-10-11
Reviewed by Eric Carlson.
Reorder initializer list to avoid misleading initialization order.
It might be nicer to actually reorder the member variables in the class itself, which would
probably be safe, but that would be a behavior change and I'd rather avoid changing
behavior.
* WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (268327 => 268328)
--- trunk/Source/WebKit/ChangeLog 2020-10-11 23:34:10 UTC (rev 268327)
+++ trunk/Source/WebKit/ChangeLog 2020-10-12 00:16:53 UTC (rev 268328)
@@ -1,3 +1,19 @@
+2020-10-11 Michael Catanzaro <mcatanz...@gnome.org>
+
+ -Wreorder in MediaPlayerPrivateRemote.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=217590
+
+ Reviewed by Eric Carlson.
+
+ Reorder initializer list to avoid misleading initialization order.
+
+ It might be nicer to actually reorder the member variables in the class itself, which would
+ probably be safe, but that would be a behavior change and I'd rather avoid changing
+ behavior.
+
+ * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:
+ (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
+
2020-10-11 Luming Yin <luming_...@apple.com>
Ignore deployment suffix and identifier when computing major OS version for macOS
Modified: trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp (268327 => 268328)
--- trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-11 23:34:10 UTC (rev 268327)
+++ trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp 2020-10-12 00:16:53 UTC (rev 268328)
@@ -92,11 +92,13 @@
#if !PLATFORM(COCOA)
MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerIdentifier playerIdentifier, RemoteMediaPlayerManager& manager)
- : m_player(player)
+ :
#if !RELEASE_LOG_DISABLED
- , m_logger(player->mediaPlayerLogger())
+ m_logger(player->mediaPlayerLogger())
, m_logIdentifier(player->mediaPlayerLogIdentifier())
+ ,
#endif
+ m_player(player)
, m_mediaResourceLoader(*player->createResourceLoader())
, m_manager(manager)
, m_remoteEngineIdentifier(engineIdentifier)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
