Title: [268540] branches/safari-610-branch/Source/WebCore
Revision
268540
Author
[email protected]
Date
2020-10-15 11:26:59 -0700 (Thu, 15 Oct 2020)

Log Message

Apply patch. rdar://problem/70321689

Modified Paths


Diff

Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (268539 => 268540)


--- branches/safari-610-branch/Source/WebCore/ChangeLog	2020-10-15 18:21:25 UTC (rev 268539)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog	2020-10-15 18:26:59 UTC (rev 268540)
@@ -1,5 +1,23 @@
 2020-10-15  Russell Epstein  <[email protected]>
 
+        Apply patch. rdar://problem/70321689
+
+    2020-10-15  Youenn Fablet  <[email protected]>
+
+            Improve computation of default audio input and output devices
+            https://bugs.webkit.org/show_bug.cgi?id=217652
+            <rdar://problem/69857857>
+
+            Previously, we were ensuring the default device is the first in the list if the list was not empty.
+            For the first enumeration of devices, we were expecting the default device to be the first in kAudioHardwarePropertyDevices list.
+            But this is not guaranteed, so we should make sure to prepend the default device in the list even for the first enumeration.
+            Manually tested.
+
+            * platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:
+            (WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):
+
+2020-10-15  Russell Epstein  <[email protected]>
+
         Cherry-pick r268308. rdar://problem/70321629
 
     [Mac] AirPlay menu does not show up when AirPlay button is clicked

Modified: branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp (268539 => 268540)


--- branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp	2020-10-15 18:21:25 UTC (rev 268539)
+++ branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp	2020-10-15 18:26:59 UTC (rev 268540)
@@ -190,7 +190,7 @@
 
     auto defaultInputDevice = getDefaultCaptureInputDevice();
     bool haveDeviceChanges = false;
-    if (defaultInputDevice && !m_coreAudioCaptureDevices.isEmpty() && m_coreAudioCaptureDevices.first().deviceID() != defaultInputDevice->deviceID()) {
+    if (defaultInputDevice && (m_coreAudioCaptureDevices.isEmpty() || m_coreAudioCaptureDevices.first().deviceID() != defaultInputDevice->deviceID())) {
         m_coreAudioCaptureDevices = Vector<CoreAudioCaptureDevice>::from(WTFMove(*defaultInputDevice));
         haveDeviceChanges = true;
     }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to