Title: [268557] trunk/Source/WebCore
- Revision
- 268557
- Author
- [email protected]
- Date
- 2020-10-15 15:02:32 -0700 (Thu, 15 Oct 2020)
Log Message
Avoid double zero'ing of AudioArray in DelayDSPKernel constructors
https://bugs.webkit.org/show_bug.cgi?id=217779
Reviewed by Darin Adler.
Avoid double zero'ing of AudioArray in DelayDSPKernel constructors.
The constructors were calling AudioArray::resize() to allocate the
array memory and then AudioArray::zero() to zero-out the memory.
The second step is unnecessary since AudioArray::resize() already
takes care of zeroing out the memory after allocation.
No new tests, no Web-facing behavior change.
* Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::DelayDSPKernel):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (268556 => 268557)
--- trunk/Source/WebCore/ChangeLog 2020-10-15 21:59:52 UTC (rev 268556)
+++ trunk/Source/WebCore/ChangeLog 2020-10-15 22:02:32 UTC (rev 268557)
@@ -1,5 +1,23 @@
2020-10-15 Chris Dumez <[email protected]>
+ Avoid double zero'ing of AudioArray in DelayDSPKernel constructors
+ https://bugs.webkit.org/show_bug.cgi?id=217779
+
+ Reviewed by Darin Adler.
+
+ Avoid double zero'ing of AudioArray in DelayDSPKernel constructors.
+ The constructors were calling AudioArray::resize() to allocate the
+ array memory and then AudioArray::zero() to zero-out the memory.
+ The second step is unnecessary since AudioArray::resize() already
+ takes care of zeroing out the memory after allocation.
+
+ No new tests, no Web-facing behavior change.
+
+ * Modules/webaudio/DelayDSPKernel.cpp:
+ (WebCore::DelayDSPKernel::DelayDSPKernel):
+
+2020-10-15 Chris Dumez <[email protected]>
+
Use std::fill_n() instead of for loops in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=217775
Modified: trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp (268556 => 268557)
--- trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp 2020-10-15 21:59:52 UTC (rev 268556)
+++ trunk/Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp 2020-10-15 22:02:32 UTC (rev 268557)
@@ -47,7 +47,6 @@
return;
m_buffer.resize(bufferLengthForDelay(m_maxDelayTime, processor->sampleRate()));
- m_buffer.zero();
}
DelayDSPKernel::DelayDSPKernel(double maxDelayTime, float sampleRate)
@@ -64,7 +63,6 @@
return;
m_buffer.resize(bufferLength);
- m_buffer.zero();
}
size_t DelayDSPKernel::bufferLengthForDelay(double maxDelayTime, double sampleRate) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
