Title: [268562] trunk/Source/WebKit
- Revision
- 268562
- Author
- [email protected]
- Date
- 2020-10-15 17:06:17 -0700 (Thu, 15 Oct 2020)
Log Message
PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
<https://webkit.org/b/217791>
<rdar://problem/70349804>
Reviewed by Tim Horton.
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
- Use `!!` to convert result to `bool`.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (268561 => 268562)
--- trunk/Source/WebKit/ChangeLog 2020-10-15 23:51:06 UTC (rev 268561)
+++ trunk/Source/WebKit/ChangeLog 2020-10-16 00:06:17 UTC (rev 268562)
@@ -1,3 +1,15 @@
+2020-10-15 David Kilzer <[email protected]>
+
+ PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
+ <https://webkit.org/b/217791>
+ <rdar://problem/70349804>
+
+ Reviewed by Tim Horton.
+
+ * WebProcess/Plugins/PDF/PDFPlugin.mm:
+ (WebKit::PDFPlugin::handleContextMenuEvent):
+ - Use `!!` to convert result to `bool`.
+
2020-10-15 Aditya Keerthi <[email protected]>
Crash in -[WKDateTimePicker setDateTimePickerToInitialValue]
Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (268561 => 268562)
--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-10-15 23:51:06 UTC (rev 268561)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm 2020-10-16 00:06:17 UTC (rev 268562)
@@ -2300,7 +2300,7 @@
auto item = [nsMenu itemAtIndex:i];
if ([item submenu])
continue;
- PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), [item action], i };
+ PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), !![item action], i };
items.append(WTFMove(menuItem));
}
PDFContextMenu contextMenu { point, WTFMove(items) };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
