Title: [268602] trunk
- Revision
- 268602
- Author
- [email protected]
- Date
- 2020-10-16 12:20:41 -0700 (Fri, 16 Oct 2020)
Log Message
[WebAuthn] Remove the "alg" field in the attestation statement
https://bugs.webkit.org/show_bug.cgi?id=217720
<rdar://problem/70349734>
Reviewed by Brent Fulgham.
Source/WebKit:
This old field was used in an unreleased old attestation statement format and is not used by
the final attestation statement format that will be added to the spec:
https://github.com/w3c/webauthn/pull/1491.
Therefore, remove it to resolve confusion.
Covered by existing tests.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
LayoutTests:
* http/wpt/webauthn/public-key-credential-create-success-local.https.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (268601 => 268602)
--- trunk/LayoutTests/ChangeLog 2020-10-16 19:18:37 UTC (rev 268601)
+++ trunk/LayoutTests/ChangeLog 2020-10-16 19:20:41 UTC (rev 268602)
@@ -1,3 +1,13 @@
+2020-10-16 Jiewen Tan <[email protected]>
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+
2020-10-16 Chris Dumez <[email protected]>
Move even more AudioContext-specific logic out of BaseAudioContext
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html (268601 => 268602)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html 2020-10-16 19:18:37 UTC (rev 268601)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html 2020-10-16 19:20:41 UTC (rev 268602)
@@ -38,7 +38,6 @@
if (isNoneAttestation)
assert_object_equals(attestationObject.attStmt, { });
else {
- assert_equals(attestationObject.attStmt.alg, -7);
assert_equals(attestationObject.attStmt.x5c.length, 2);
assert_array_equals(attestationObject.attStmt.x5c[0], Base64URL.parse(testAttestationCertificateBase64));
assert_array_equals(attestationObject.attStmt.x5c[1], Base64URL.parse(testAttestationIssuingCACertificateBase64));
Modified: trunk/Source/WebKit/ChangeLog (268601 => 268602)
--- trunk/Source/WebKit/ChangeLog 2020-10-16 19:18:37 UTC (rev 268601)
+++ trunk/Source/WebKit/ChangeLog 2020-10-16 19:20:41 UTC (rev 268602)
@@ -1,3 +1,22 @@
+2020-10-16 Jiewen Tan <[email protected]>
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ This old field was used in an unreleased old attestation statement format and is not used by
+ the final attestation statement format that will be added to the spec:
+ https://github.com/w3c/webauthn/pull/1491.
+
+ Therefore, remove it to resolve confusion.
+
+ Covered by existing tests.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+
2020-10-16 Youenn Fablet <[email protected]>
Add support for GPUProcess WebAudio media element providers
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (268601 => 268602)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2020-10-16 19:18:37 UTC (rev 268601)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2020-10-16 19:20:41 UTC (rev 268602)
@@ -402,7 +402,6 @@
// https://www.w3.org/TR/webauthn/#attestation-object
cbor::CBORValue::MapValue attestationStatementMap;
{
- attestationStatementMap[cbor::CBORValue("alg")] = cbor::CBORValue(COSE::ES256);
Vector<cbor::CBORValue> cborArray;
for (size_t i = 0; i < [certificates count]; i++)
cborArray.append(cbor::CBORValue(toVector((NSData *)adoptCF(SecCertificateCopyData((__bridge SecCertificateRef)certificates[i])).get())));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
