Title: [105055] trunk/Source/WebCore
Revision
105055
Author
[email protected]
Date
2012-01-16 04:57:00 -0800 (Mon, 16 Jan 2012)

Log Message

CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
<http://webkit.org/b/76374>

Reviewed by Antti Koivisto.

Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".

* css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (105054 => 105055)


--- trunk/Source/WebCore/ChangeLog	2012-01-16 12:25:55 UTC (rev 105054)
+++ trunk/Source/WebCore/ChangeLog	2012-01-16 12:57:00 UTC (rev 105055)
@@ -1,3 +1,16 @@
+2012-01-16  Andreas Kling  <[email protected]>
+
+        CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
+        <http://webkit.org/b/76374>
+
+        Reviewed by Antti Koivisto.
+
+        Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::leftToRightDeclaration):
+        (WebCore::rightToLeftDeclaration):
+
 2012-01-16  Carlos Garcia Campos  <[email protected]>
 
         Unreviewed. Fix make distcheck.

Modified: trunk/Source/WebCore/css/CSSStyleSelector.cpp (105054 => 105055)


--- trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-01-16 12:25:55 UTC (rev 105054)
+++ trunk/Source/WebCore/css/CSSStyleSelector.cpp	2012-01-16 12:57:00 UTC (rev 105055)
@@ -313,20 +313,16 @@
 static CSSMutableStyleDeclaration* leftToRightDeclaration()
 {
     DEFINE_STATIC_LOCAL(RefPtr<CSSMutableStyleDeclaration>, leftToRightDecl, (CSSMutableStyleDeclaration::create()));
-    if (!leftToRightDecl->length()) {
-        leftToRightDecl->setProperty(CSSPropertyDirection, "ltr", false);
-        leftToRightDecl->setStrictParsing(false);
-    }
+    if (!leftToRightDecl->length())
+        leftToRightDecl->setProperty(CSSPropertyDirection, CSSValueLtr);
     return leftToRightDecl.get();
 }
 
 static CSSMutableStyleDeclaration* rightToLeftDeclaration()
 {
     DEFINE_STATIC_LOCAL(RefPtr<CSSMutableStyleDeclaration>, rightToLeftDecl, (CSSMutableStyleDeclaration::create()));
-    if (!rightToLeftDecl->length()) {
-        rightToLeftDecl->setProperty(CSSPropertyDirection, "rtl", false);
-        rightToLeftDecl->setStrictParsing(false);
-    }
+    if (!rightToLeftDecl->length())
+        rightToLeftDecl->setProperty(CSSPropertyDirection, CSSValueRtl);
     return rightToLeftDecl.get();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to