Title: [105070] trunk
- Revision
- 105070
- Author
- [email protected]
- Date
- 2012-01-16 09:24:28 -0800 (Mon, 16 Jan 2012)
Log Message
Web Inspector: styles sidebar rendering is broken
https://bugs.webkit.org/show_bug.cgi?id=76065
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
* inspector/front-end/elementsPanel.css:
(.styles-section .header .subtitle):
(.styles-section .properties):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (105069 => 105070)
--- trunk/LayoutTests/ChangeLog 2012-01-16 17:18:21 UTC (rev 105069)
+++ trunk/LayoutTests/ChangeLog 2012-01-16 17:24:28 UTC (rev 105070)
@@ -1,3 +1,13 @@
+2012-01-13 Alexander Pavlov <[email protected]>
+
+ Web Inspector: styles sidebar rendering is broken
+ https://bugs.webkit.org/show_bug.cgi?id=76065
+
+ Reviewed by Pavel Feldman.
+
+ * http/tests/inspector/elements-test.js:
+ (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.
+
2012-01-16 Pavel Feldman <[email protected]>
Web Inspector: do not merge iframes into a single DOM hierarchy.
Modified: trunk/LayoutTests/http/tests/inspector/elements-test.js (105069 => 105070)
--- trunk/LayoutTests/http/tests/inspector/elements-test.js 2012-01-16 17:18:21 UTC (rev 105069)
+++ trunk/LayoutTests/http/tests/inspector/elements-test.js 2012-01-16 17:24:28 UTC (rev 105070)
@@ -132,11 +132,10 @@
var chainEntries = section.titleElement.children;
for (var j = 0; j < chainEntries.length; ++j) {
var chainEntry = chainEntries[j];
- var entryLine = chainEntry.children[0].textContent;
+ var entryLine = chainEntry.children[1].textContent;
if (chainEntry.children[2])
- entryLine += " " + chainEntry.children[1].textContent;
- if (chainEntry.children.length > 1)
- entryLine += " (" + extractText(chainEntry.lastChild) + ")";
+ entryLine += " " + chainEntry.children[2].textContent;
+ entryLine += " (" + extractText(chainEntry.children[0]) + ")";
InspectorTest.addResult(entryLine);
}
section.expand();
Modified: trunk/Source/WebCore/ChangeLog (105069 => 105070)
--- trunk/Source/WebCore/ChangeLog 2012-01-16 17:18:21 UTC (rev 105069)
+++ trunk/Source/WebCore/ChangeLog 2012-01-16 17:24:28 UTC (rev 105070)
@@ -1,3 +1,16 @@
+2012-01-13 Alexander Pavlov <[email protected]>
+
+ Web Inspector: styles sidebar rendering is broken
+ https://bugs.webkit.org/show_bug.cgi?id=76065
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.StylePropertiesSection):
+ * inspector/front-end/elementsPanel.css:
+ (.styles-section .header .subtitle):
+ (.styles-section .properties):
+
2012-01-16 Csaba Osztrogonác <[email protected]>
[Qt] Inremental build problem revealed by https://bugs.webkit.org/show_bug.cgi?id=74455
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (105069 => 105070)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-01-16 17:18:21 UTC (rev 105069)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-01-16 17:24:28 UTC (rev 105070)
@@ -873,16 +873,16 @@
break;
}
- var mediaTextElement = mediaDataElement.createChild("span");
- mediaTextElement.textContent = mediaText;
- mediaTextElement.title = media.text;
-
if (media.sourceURL) {
var refElement = mediaDataElement.createChild("div", "subtitle");
var anchor = WebInspector.linkifyResourceAsNode(media.sourceURL, media.sourceLine < 0 ? undefined : media.sourceLine, "subtitle");
anchor.style.float = "right";
refElement.appendChild(anchor);
}
+
+ var mediaTextElement = mediaDataElement.createChild("span");
+ mediaTextElement.textContent = mediaText;
+ mediaTextElement.title = media.text;
}
}
@@ -920,7 +920,7 @@
this._selectorRefElement = document.createElement("div");
this._selectorRefElement.className = "subtitle";
this._selectorRefElement.appendChild(this._createRuleOriginNode());
- selectorContainer.appendChild(this._selectorRefElement);
+ selectorContainer.insertBefore(this._selectorRefElement, selectorContainer.firstChild);
this.titleElement.appendChild(selectorContainer);
if (isInherited)
Modified: trunk/Source/WebCore/inspector/front-end/elementsPanel.css (105069 => 105070)
--- trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2012-01-16 17:18:21 UTC (rev 105069)
+++ trunk/Source/WebCore/inspector/front-end/elementsPanel.css 2012-01-16 17:24:28 UTC (rev 105070)
@@ -275,7 +275,7 @@
color: rgb(85, 85, 85);
float: right;
margin-left: 5px;
- max-width: 65%;
+ max-width: 100%;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
@@ -299,6 +299,7 @@
margin: 0;
padding: 2px 4px 0 8px;
list-style: none;
+ clear: both;
}
.styles-section.no-affect .properties li {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
