Title: [268834] branches/safari-610-branch
- Revision
- 268834
- Author
- [email protected]
- Date
- 2020-10-21 15:15:58 -0700 (Wed, 21 Oct 2020)
Log Message
Cherry-pick r268602. rdar://problem/70541712
[WebAuthn] Remove the "alg" field in the attestation statement
https://bugs.webkit.org/show_bug.cgi?id=217720
<rdar://problem/70349734>
Reviewed by Brent Fulgham.
Source/WebKit:
This old field was used in an unreleased old attestation statement format and is not used by
the final attestation statement format that will be added to the spec:
https://github.com/w3c/webauthn/pull/1491.
Therefore, remove it to resolve confusion.
Covered by existing tests.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
LayoutTests:
* http/wpt/webauthn/public-key-credential-create-success-local.https.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610-branch/LayoutTests/ChangeLog (268833 => 268834)
--- branches/safari-610-branch/LayoutTests/ChangeLog 2020-10-21 22:15:55 UTC (rev 268833)
+++ branches/safari-610-branch/LayoutTests/ChangeLog 2020-10-21 22:15:58 UTC (rev 268834)
@@ -1,3 +1,43 @@
+2020-10-21 Russell Epstein <[email protected]>
+
+ Cherry-pick r268602. rdar://problem/70541712
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ Source/WebKit:
+
+ This old field was used in an unreleased old attestation statement format and is not used by
+ the final attestation statement format that will be added to the spec:
+ https://github.com/w3c/webauthn/pull/1491.
+
+ Therefore, remove it to resolve confusion.
+
+ Covered by existing tests.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+
+ LayoutTests:
+
+ * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-10-16 Jiewen Tan <[email protected]>
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+
2020-10-08 Russell Epstein <[email protected]>
Cherry-pick r266909. rdar://problem/69101091
Modified: branches/safari-610-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html (268833 => 268834)
--- branches/safari-610-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html 2020-10-21 22:15:55 UTC (rev 268833)
+++ branches/safari-610-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html 2020-10-21 22:15:58 UTC (rev 268834)
@@ -38,7 +38,6 @@
if (isNoneAttestation)
assert_object_equals(attestationObject.attStmt, { });
else {
- assert_equals(attestationObject.attStmt.alg, -7);
assert_equals(attestationObject.attStmt.x5c.length, 2);
assert_array_equals(attestationObject.attStmt.x5c[0], Base64URL.parse(testAttestationCertificateBase64));
assert_array_equals(attestationObject.attStmt.x5c[1], Base64URL.parse(testAttestationIssuingCACertificateBase64));
Modified: branches/safari-610-branch/Source/WebKit/ChangeLog (268833 => 268834)
--- branches/safari-610-branch/Source/WebKit/ChangeLog 2020-10-21 22:15:55 UTC (rev 268833)
+++ branches/safari-610-branch/Source/WebKit/ChangeLog 2020-10-21 22:15:58 UTC (rev 268834)
@@ -1,5 +1,54 @@
2020-10-21 Russell Epstein <[email protected]>
+ Cherry-pick r268602. rdar://problem/70541712
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ Source/WebKit:
+
+ This old field was used in an unreleased old attestation statement format and is not used by
+ the final attestation statement format that will be added to the spec:
+ https://github.com/w3c/webauthn/pull/1491.
+
+ Therefore, remove it to resolve confusion.
+
+ Covered by existing tests.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+
+ LayoutTests:
+
+ * http/wpt/webauthn/public-key-credential-create-success-local.https.html:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@268602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-10-16 Jiewen Tan <[email protected]>
+
+ [WebAuthn] Remove the "alg" field in the attestation statement
+ https://bugs.webkit.org/show_bug.cgi?id=217720
+ <rdar://problem/70349734>
+
+ Reviewed by Brent Fulgham.
+
+ This old field was used in an unreleased old attestation statement format and is not used by
+ the final attestation statement format that will be added to the spec:
+ https://github.com/w3c/webauthn/pull/1491.
+
+ Therefore, remove it to resolve confusion.
+
+ Covered by existing tests.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested):
+
+2020-10-21 Russell Epstein <[email protected]>
+
Cherry-pick r268507. rdar://problem/70541950
[iOS] Allow additional sysctl reads needed by image decoding
Modified: branches/safari-610-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (268833 => 268834)
--- branches/safari-610-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2020-10-21 22:15:55 UTC (rev 268833)
+++ branches/safari-610-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2020-10-21 22:15:58 UTC (rev 268834)
@@ -402,7 +402,6 @@
// https://www.w3.org/TR/webauthn/#attestation-object
cbor::CBORValue::MapValue attestationStatementMap;
{
- attestationStatementMap[cbor::CBORValue("alg")] = cbor::CBORValue(COSE::ES256);
Vector<cbor::CBORValue> cborArray;
for (size_t i = 0; i < [certificates count]; i++)
cborArray.append(cbor::CBORValue(toVector((NSData *)adoptCF(SecCertificateCopyData((__bridge SecCertificateRef)certificates[i])).get())));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
