Title: [268859] trunk/Source/WebCore
- Revision
- 268859
- Author
- [email protected]
- Date
- 2020-10-22 03:00:32 -0700 (Thu, 22 Oct 2020)
Log Message
[GStreamer] Restrict ImageDecoder to WebProcess
https://bugs.webkit.org/show_bug.cgi?id=218023
Patch by Philippe Normand <[email protected]> on 2020-10-22
Reviewed by Carlos Garcia Campos.
Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
should be the only process where GStreamer has been runtime initialized. This is a step
towards a GStreamer-free GTK/WPE UIProcess.
* platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
(WebCore::ImageDecoderGStreamer::supportsContainerType):
(WebCore::ImageDecoderGStreamer::canDecodeType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (268858 => 268859)
--- trunk/Source/WebCore/ChangeLog 2020-10-22 09:42:22 UTC (rev 268858)
+++ trunk/Source/WebCore/ChangeLog 2020-10-22 10:00:32 UTC (rev 268859)
@@ -1,3 +1,18 @@
+2020-10-22 Philippe Normand <[email protected]>
+
+ [GStreamer] Restrict ImageDecoder to WebProcess
+ https://bugs.webkit.org/show_bug.cgi?id=218023
+
+ Reviewed by Carlos Garcia Campos.
+
+ Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+ should be the only process where GStreamer has been runtime initialized. This is a step
+ towards a GStreamer-free GTK/WPE UIProcess.
+
+ * platform/graphics/gstreamer/ImageDecoderGStreamer.cpp:
+ (WebCore::ImageDecoderGStreamer::supportsContainerType):
+ (WebCore::ImageDecoderGStreamer::canDecodeType):
+
2020-10-22 Martin Robinson <[email protected]>
Scroll snap: don't create implicit snap points at scrollmin/scrollmax
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp (268858 => 268859)
--- trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp 2020-10-22 09:42:22 UTC (rev 268858)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp 2020-10-22 10:00:32 UTC (rev 268859)
@@ -98,11 +98,21 @@
bool ImageDecoderGStreamer::supportsContainerType(const String& type)
{
+ // Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+ // should be the only process where GStreamer has been runtime initialized.
+ if (!gst_is_initialized())
+ return false;
+
return GStreamerRegistryScanner::singleton().isContainerTypeSupported(GStreamerRegistryScanner::Configuration::Decoding, type);
}
bool ImageDecoderGStreamer::canDecodeType(const String& mimeType)
{
+ // Ideally this decoder should operate only from the WebProcess (or from the GPUProcess) which
+ // should be the only process where GStreamer has been runtime initialized.
+ if (!gst_is_initialized())
+ return false;
+
if (mimeType.isEmpty())
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
