Title: [268862] trunk
- Revision
- 268862
- Author
- [email protected]
- Date
- 2020-10-22 06:22:32 -0700 (Thu, 22 Oct 2020)
Log Message
[LFC][Integration] Lines with outline should be marked having visual overflow
https://bugs.webkit.org/show_bug.cgi?id=218071
Reviewed by Zalan Bujtas.
Source/WebCore:
Seen in fast/repaint/focus-ring-repaint.html
We may fail to paint newly added outlines correctly. This is a legacy line layout bug exposed by IFC integration.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
Mark when adding content to line.
LayoutTests:
* fast/repaint/focus-ring-repaint-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (268861 => 268862)
--- trunk/LayoutTests/ChangeLog 2020-10-22 13:02:45 UTC (rev 268861)
+++ trunk/LayoutTests/ChangeLog 2020-10-22 13:22:32 UTC (rev 268862)
@@ -1,3 +1,12 @@
+2020-10-22 Antti Koivisto <[email protected]>
+
+ [LFC][Integration] Lines with outline should be marked having visual overflow
+ https://bugs.webkit.org/show_bug.cgi?id=218071
+
+ Reviewed by Zalan Bujtas.
+
+ * fast/repaint/focus-ring-repaint-expected.txt:
+
2020-10-22 Diego Pino Garcia <[email protected]>
[GLIB][GTK] Unreviewed test gardening. Gardened some of the latest flaky failures.
Modified: trunk/LayoutTests/fast/repaint/focus-ring-repaint-expected.txt (268861 => 268862)
--- trunk/LayoutTests/fast/repaint/focus-ring-repaint-expected.txt 2020-10-22 13:02:45 UTC (rev 268861)
+++ trunk/LayoutTests/fast/repaint/focus-ring-repaint-expected.txt 2020-10-22 13:22:32 UTC (rev 268862)
@@ -6,25 +6,27 @@
(repaint rects
- (rect 5 457 103 67)
(rect 5 457 106 70)
+ (rect 5 457 106 70)
(rect 5 542 106 70)
(rect 15 62 36 40)
(rect 18 65 30 34)
- (rect 5 89 56 10)
- (rect 5 35 56 64)
+ (rect 5 92 56 10)
+ (rect 5 35 56 67)
(rect 5 117 36 60)
(rect 8 120 30 54)
(rect 5 117 36 86)
(rect 8 120 30 80)
- (rect 5 174 56 30)
- (rect 5 120 56 84)
+ (rect 5 177 56 30)
+ (rect 5 120 56 87)
(rect 5 205 56 37)
(rect 5 375 56 37)
- (rect 5 457 103 67)
+ (rect 5 457 106 70)
(rect 8 460 100 64)
(rect 8 545 100 64)
- (rect 5 542 103 67)
+ (rect 5 542 106 70)
+ (rect 5 609 772 3)
+ (rect 0 609 785 3)
(rect 45 212 36 40)
(rect 48 215 30 34)
(rect 155 212 36 40)
Modified: trunk/Source/WebCore/ChangeLog (268861 => 268862)
--- trunk/Source/WebCore/ChangeLog 2020-10-22 13:02:45 UTC (rev 268861)
+++ trunk/Source/WebCore/ChangeLog 2020-10-22 13:22:32 UTC (rev 268862)
@@ -1,3 +1,19 @@
+2020-10-22 Antti Koivisto <[email protected]>
+
+ [LFC][Integration] Lines with outline should be marked having visual overflow
+ https://bugs.webkit.org/show_bug.cgi?id=218071
+
+ Reviewed by Zalan Bujtas.
+
+ Seen in fast/repaint/focus-ring-repaint.html
+
+ We may fail to paint newly added outlines correctly. This is a legacy line layout bug exposed by IFC integration.
+
+ * rendering/InlineFlowBox.cpp:
+ (WebCore::InlineFlowBox::addToLine):
+
+ Mark when adding content to line.
+
2020-10-22 Cathie Chen <[email protected]>
ResizeObserver is not properly garbage collected
Modified: trunk/Source/WebCore/rendering/InlineFlowBox.cpp (268861 => 268862)
--- trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2020-10-22 13:02:45 UTC (rev 268861)
+++ trunk/Source/WebCore/rendering/InlineFlowBox.cpp 2020-10-22 13:22:32 UTC (rev 268862)
@@ -175,6 +175,9 @@
child->clearKnownToHaveNoOverflow();
else if (childStyle.hasOutlineInVisualOverflow())
child->clearKnownToHaveNoOverflow();
+
+ if (lineStyle().hasOutlineInVisualOverflow())
+ clearKnownToHaveNoOverflow();
if (knownToHaveNoOverflow() && is<InlineFlowBox>(*child) && !downcast<InlineFlowBox>(*child).knownToHaveNoOverflow())
clearKnownToHaveNoOverflow();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
