Title: [268918] trunk/Source/_javascript_Core
- Revision
- 268918
- Author
- [email protected]
- Date
- 2020-10-23 02:44:14 -0700 (Fri, 23 Oct 2020)
Log Message
[JSC] Fix argument order for double and/or ops on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=218118
Patch by Angelos Oikonomopoulos <[email protected]> on 2020-10-23
Reviewed by Adrian Perez de Castro.
The andDouble and orDouble macro assembler methods for ARMv7
incorrectly pass the destination register as the last argument,
whereas the assembler expects the destination to be the first
argument.
This fixes a failing testmasm test.
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::andDouble):
(JSC::MacroAssemblerARMv7::orDouble):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (268917 => 268918)
--- trunk/Source/_javascript_Core/ChangeLog 2020-10-23 09:23:49 UTC (rev 268917)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-10-23 09:44:14 UTC (rev 268918)
@@ -1,3 +1,21 @@
+2020-10-23 Angelos Oikonomopoulos <[email protected]>
+
+ [JSC] Fix argument order for double and/or ops on ARMv7
+ https://bugs.webkit.org/show_bug.cgi?id=218118
+
+ Reviewed by Adrian Perez de Castro.
+
+ The andDouble and orDouble macro assembler methods for ARMv7
+ incorrectly pass the destination register as the last argument,
+ whereas the assembler expects the destination to be the first
+ argument.
+
+ This fixes a failing testmasm test.
+
+ * assembler/MacroAssemblerARMv7.h:
+ (JSC::MacroAssemblerARMv7::andDouble):
+ (JSC::MacroAssemblerARMv7::orDouble):
+
2020-10-22 Robin Morisset <[email protected]>
Use operand names when dumping Bytecode
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h (268917 => 268918)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2020-10-23 09:23:49 UTC (rev 268917)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h 2020-10-23 09:44:14 UTC (rev 268918)
@@ -1187,12 +1187,12 @@
void andDouble(FPRegisterID op1, FPRegisterID op2, FPRegisterID dest)
{
- m_assembler.vand(op1, op2, dest);
+ m_assembler.vand(dest, op1, op2);
}
void orDouble(FPRegisterID op1, FPRegisterID op2, FPRegisterID dest)
{
- m_assembler.vorr(op1, op2, dest);
+ m_assembler.vorr(dest, op1, op2);
}
void sqrtDouble(FPRegisterID src, FPRegisterID dest)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
