Title: [268926] trunk
- Revision
- 268926
- Author
- [email protected]
- Date
- 2020-10-23 09:22:58 -0700 (Fri, 23 Oct 2020)
Log Message
AnalyserNode's output should only have one channel
https://bugs.webkit.org/show_bug.cgi?id=218125
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
* web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt:
Source/WebCore:
AnalyserNode's output should only have one channel. We were using 2 channels, which
was inconsistent with Blink and Gecko.
No new tests, rebaselined existing test.
* Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
LayoutTests:
Unskip test that is no longer flaky, now that it passes.
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (268925 => 268926)
--- trunk/LayoutTests/ChangeLog 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/LayoutTests/ChangeLog 2020-10-23 16:22:58 UTC (rev 268926)
@@ -1,3 +1,14 @@
+2020-10-23 Chris Dumez <[email protected]>
+
+ AnalyserNode's output should only have one channel
+ https://bugs.webkit.org/show_bug.cgi?id=218125
+
+ Reviewed by Eric Carlson.
+
+ Unskip test that is no longer flaky, now that it passes.
+
+ * TestExpectations:
+
2020-10-23 Miguel Gomez <[email protected]>
[GTK][WPE] Implement antialiased rounded rectangle clipping in TextureMapper
Modified: trunk/LayoutTests/TestExpectations (268925 => 268926)
--- trunk/LayoutTests/TestExpectations 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/LayoutTests/TestExpectations 2020-10-23 16:22:58 UTC (rev 268926)
@@ -331,7 +331,6 @@
# Webaudio tests that are flaky.
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-stereo-panner.html [ Pass Failure ]
-imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output.html [ Pass Failure ]
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/cors-check.https.html [ Pass Failure ]
# This test is passing but the printed SNR value differs from machine to machine.
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (268925 => 268926)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-10-23 16:22:58 UTC (rev 268926)
@@ -1,3 +1,14 @@
+2020-10-23 Chris Dumez <[email protected]>
+
+ AnalyserNode's output should only have one channel
+ https://bugs.webkit.org/show_bug.cgi?id=218125
+
+ Reviewed by Eric Carlson.
+
+ Rebaseline WPT test that is now passing.
+
+ * web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt:
+
2020-10-22 Martin Robinson <[email protected]>
Rename scroll-snap-margin to scroll-margin
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt (268925 => 268926)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-output-expected.txt 2020-10-23 16:22:58 UTC (rev 268926)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: Error: assert_equals: maxDifference: 1.5293363332748413, first bad index: 0 with test-data offset 0 and expected-data offset 0; corresponding values 0.9855409860610962 and 0 --- differences expected 0 but got 2042
-FAIL AnalyserNode output Error: assert_equals: maxDifference: 1.5293363332748413, first bad index: 0 with test-data offset 0 and expected-data offset 0; corresponding values 0.9855409860610962 and 0 --- differences expected 0 but got 2042
+PASS AnalyserNode output
Modified: trunk/Source/WebCore/ChangeLog (268925 => 268926)
--- trunk/Source/WebCore/ChangeLog 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/Source/WebCore/ChangeLog 2020-10-23 16:22:58 UTC (rev 268926)
@@ -1,3 +1,18 @@
+2020-10-23 Chris Dumez <[email protected]>
+
+ AnalyserNode's output should only have one channel
+ https://bugs.webkit.org/show_bug.cgi?id=218125
+
+ Reviewed by Eric Carlson.
+
+ AnalyserNode's output should only have one channel. We were using 2 channels, which
+ was inconsistent with Blink and Gecko.
+
+ No new tests, rebaselined existing test.
+
+ * Modules/webaudio/AnalyserNode.cpp:
+ (WebCore::AnalyserNode::AnalyserNode):
+
2020-10-23 Zalan Bujtas <[email protected]>
[LFC][IFC] Add initial support for vertical-align: <length> and <percentage>
Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp (268925 => 268926)
--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp 2020-10-23 16:13:28 UTC (rev 268925)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp 2020-10-23 16:22:58 UTC (rev 268926)
@@ -62,7 +62,7 @@
AnalyserNode::AnalyserNode(BaseAudioContext& context)
: AudioBasicInspectorNode(context, NodeTypeAnalyser)
{
- addOutput(2);
+ addOutput(1);
initialize();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
