Title: [268968] trunk/Source/WebCore
- Revision
- 268968
- Author
- [email protected]
- Date
- 2020-10-26 04:56:12 -0700 (Mon, 26 Oct 2020)
Log Message
[EME][Thunder][GStreamer] Assert on 0 length messages from Thunder
https://bugs.webkit.org/show_bug.cgi?id=218173
Reviewed by Philippe Normand.
* platform/graphics/gstreamer/eme/CDMThunder.cpp:
(WebCore::CDMInstanceSessionThunder::CDMInstanceSessionThunder):
Assert on 0 length messages to get a crash and be able to analyze
why.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (268967 => 268968)
--- trunk/Source/WebCore/ChangeLog 2020-10-26 11:33:59 UTC (rev 268967)
+++ trunk/Source/WebCore/ChangeLog 2020-10-26 11:56:12 UTC (rev 268968)
@@ -1,3 +1,15 @@
+2020-10-26 Xabier Rodriguez Calvar <[email protected]>
+
+ [EME][Thunder][GStreamer] Assert on 0 length messages from Thunder
+ https://bugs.webkit.org/show_bug.cgi?id=218173
+
+ Reviewed by Philippe Normand.
+
+ * platform/graphics/gstreamer/eme/CDMThunder.cpp:
+ (WebCore::CDMInstanceSessionThunder::CDMInstanceSessionThunder):
+ Assert on 0 length messages to get a crash and be able to analyze
+ why.
+
2020-10-26 Emilio Cobos Álvarez <[email protected]>
Drop sorting and deduplication of media queries.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp (268967 => 268968)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp 2020-10-26 11:33:59 UTC (rev 268967)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp 2020-10-26 11:56:12 UTC (rev 268968)
@@ -259,7 +259,8 @@
ASSERT(isMainThread());
m_thunderSessionCallbacks.process_challenge_callback = [](OpenCDMSession*, void* userData, const char[], const uint8_t challenge[],
const uint16_t challengeLength) {
- GST_DEBUG("Got 'challenge' OCDM notification");
+ GST_DEBUG("Got 'challenge' OCDM notification with length %hu", challengeLength);
+ ASSERT(challengeLength > 0);
callOnMainThread([session = makeWeakPtr(static_cast<CDMInstanceSessionThunder*>(userData)), buffer = WebCore::SharedBuffer::create(challenge,
challengeLength)]() mutable {
if (!session)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
