Title: [268981] trunk/Source/WebInspectorUI
- Revision
- 268981
- Author
- [email protected]
- Date
- 2020-10-26 10:25:23 -0700 (Mon, 26 Oct 2020)
Log Message
Web Inspector: Change minimum width of #tab-browser to a more reasonable value
https://bugs.webkit.org/show_bug.cgi?id=217998
Patch by Patrick Angle <[email protected]> on 2020-10-26
Reviewed by Brian Burg.
Adjusted the minimum width of the #tab-browser to be 200px, which is a more reasonable minimum usable width.
Additionally, adjusted the threshold for which multiple sidebars are shown by 50px so that the size of the
#tab-browser does not have to become its minimum width before hiding the additional sidebars.
* UserInterface/Base/Main.js:
* UserInterface/Views/Main.css:
(#tab-browser):
* UserInterface/Views/MultiSidebar.js:
(WI.MultiSidebar.prototype._updateMinimumWidthForMultipleSidebars):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (268980 => 268981)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-26 17:02:39 UTC (rev 268980)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-26 17:25:23 UTC (rev 268981)
@@ -1,3 +1,20 @@
+2020-10-26 Patrick Angle <[email protected]>
+
+ Web Inspector: Change minimum width of #tab-browser to a more reasonable value
+ https://bugs.webkit.org/show_bug.cgi?id=217998
+
+ Reviewed by Brian Burg.
+
+ Adjusted the minimum width of the #tab-browser to be 200px, which is a more reasonable minimum usable width.
+ Additionally, adjusted the threshold for which multiple sidebars are shown by 50px so that the size of the
+ #tab-browser does not have to become its minimum width before hiding the additional sidebars.
+
+ * UserInterface/Base/Main.js:
+ * UserInterface/Views/Main.css:
+ (#tab-browser):
+ * UserInterface/Views/MultiSidebar.js:
+ (WI.MultiSidebar.prototype._updateMinimumWidthForMultipleSidebars):
+
2020-10-23 Nikita Vasilyev <[email protected]>
Web Inspector: Typo in experimentalEnableStyelsJumpToVariableDeclaration
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (268980 => 268981)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-10-26 17:02:39 UTC (rev 268980)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2020-10-26 17:25:23 UTC (rev 268981)
@@ -1323,7 +1323,7 @@
{
console.assert(sidebar instanceof WI.Sidebar);
- const minimumContentBrowserWidth = 100; // Keep in sync with `#tab-browser`
+ const minimumContentBrowserWidth = 200; // Keep in sync with `#tab-browser`
let minimumWidth = window.innerWidth - minimumContentBrowserWidth;
let tabContentView = WI.tabBrowser.selectedTabContentView;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (268980 => 268981)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2020-10-26 17:02:39 UTC (rev 268980)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2020-10-26 17:25:23 UTC (rev 268981)
@@ -182,7 +182,7 @@
#tab-browser {
flex: 1;
- min-width: 100px; /* Keep in sync with `WI.getMaximumSidebarWidth(...) -> const minimumContentBrowserWidth` */
+ min-width: 200px; /* Keep in sync with `WI.getMaximumSidebarWidth(...) -> const minimumContentBrowserWidth` */
}
#details-sidebar {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MultiSidebar.js (268980 => 268981)
--- trunk/Source/WebInspectorUI/UserInterface/Views/MultiSidebar.js 2020-10-26 17:02:39 UTC (rev 268980)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MultiSidebar.js 2020-10-26 17:25:23 UTC (rev 268981)
@@ -186,7 +186,12 @@
_updateMinimumWidthForMultipleSidebars()
{
- let requiredMinimumWidth = this.primarySidebar.minimumWidth;
+ // A 50px of additional required space helps make sure we collapse the multiple sidebars at an appropriate width
+ // without preventing the user from sizing the single sidebar to fill up to the minimum width of the
+ // #tab-browser once the sidebars are collapsed.
+ const minimumWidthEasement = 50;
+
+ let requiredMinimumWidth = this.primarySidebar.minimumWidth + minimumWidthEasement;
for (let sidebarPanel of this.sidebarPanels) {
if (sidebarPanel.allowExclusivePresentation)
requiredMinimumWidth += Math.max(WI.Sidebar.AbsoluteMinimumWidth, sidebarPanel.minimumWidth);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
