Title: [269003] trunk/LayoutTests
- Revision
- 269003
- Author
- [email protected]
- Date
- 2020-10-26 17:30:29 -0700 (Mon, 26 Oct 2020)
Log Message
REGRESSION (r268865): [macOS WK2] media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=218208
Reviewed by Darin Adler.
Fix the flakiness by holding a video presentation mode change until the ongoing
mode change is completed.
* media/modern-media-controls/placard-support/placard-support-pip-expected.txt:
* media/modern-media-controls/placard-support/placard-support-pip.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (269002 => 269003)
--- trunk/LayoutTests/ChangeLog 2020-10-26 23:55:06 UTC (rev 269002)
+++ trunk/LayoutTests/ChangeLog 2020-10-27 00:30:29 UTC (rev 269003)
@@ -1,3 +1,16 @@
+2020-10-26 Peng Liu <[email protected]>
+
+ REGRESSION (r268865): [macOS WK2] media/modern-media-controls/placard-support/placard-support-pip.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=218208
+
+ Reviewed by Darin Adler.
+
+ Fix the flakiness by holding a video presentation mode change until the ongoing
+ mode change is completed.
+
+ * media/modern-media-controls/placard-support/placard-support-pip-expected.txt:
+ * media/modern-media-controls/placard-support/placard-support-pip.html:
+
2020-10-26 Simon Fraser <[email protected]>
REGRESSION (r260276): Unable to click on image and text link at the bottom of https://www.nytimes.com/ article
Modified: trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip-expected.txt (269002 => 269003)
--- trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip-expected.txt 2020-10-26 23:55:06 UTC (rev 269002)
+++ trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip-expected.txt 2020-10-27 00:30:29 UTC (rev 269003)
@@ -3,9 +3,11 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS internals.isChangingPresentationMode(media) became false
PASS media.webkitDisplayingFullscreen became true
PASS mediaController.controls.placard is mediaController.controls.pipPlacard
PASS mediaController.controls.children.includes(mediaController.controls.pipPlacard) is true
+PASS internals.isChangingPresentationMode(media) became false
PASS media.webkitDisplayingFullscreen became false
PASS mediaController.controls.placard is null
PASS mediaController.controls.children.includes(mediaController.controls.pipPlacard) is false
Modified: trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html (269002 => 269003)
--- trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html 2020-10-26 23:55:06 UTC (rev 269002)
+++ trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html 2020-10-27 00:30:29 UTC (rev 269003)
@@ -38,7 +38,13 @@
button.innerText = "Enter picture-in-picture";
button.addEventListener("click", togglePiP);
-media.addEventListener("webkitpresentationmodechanged", () => {
+media.addEventListener("webkitpresentationmodechanged", async () => {
+ if (window.internals) {
+ await new Promise(resolve => shouldBecomeEqual("internals.isChangingPresentationMode(media)", "false", () => {
+ resolve();
+ }));
+ }
+
if (media.webkitPresentationMode == "picture-in-picture") {
shouldBecomeEqual("media.webkitDisplayingFullscreen", "true", () => {
shouldBe("mediaController.controls.placard", "mediaController.controls.pipPlacard");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
