Title: [269031] trunk/Source/WebCore
- Revision
- 269031
- Author
- [email protected]
- Date
- 2020-10-27 04:40:56 -0700 (Tue, 27 Oct 2020)
Log Message
[EME][GStreamer] Fix logging in utilities
https://bugs.webkit.org/show_bug.cgi?id=218174
Reviewed by Philippe Normand.
There is some logging in GStreamerEMEUtilities.h that was not
using debugging categories properly. It does now.
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
(WebCore::InitData::InitData):
* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269030 => 269031)
--- trunk/Source/WebCore/ChangeLog 2020-10-27 11:24:48 UTC (rev 269030)
+++ trunk/Source/WebCore/ChangeLog 2020-10-27 11:40:56 UTC (rev 269031)
@@ -1,5 +1,19 @@
2020-10-27 Xabier Rodriguez Calvar <[email protected]>
+ [EME][GStreamer] Fix logging in utilities
+ https://bugs.webkit.org/show_bug.cgi?id=218174
+
+ Reviewed by Philippe Normand.
+
+ There is some logging in GStreamerEMEUtilities.h that was not
+ using debugging categories properly. It does now.
+
+ * platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
+ (WebCore::InitData::InitData):
+ * platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
+
+2020-10-27 Xabier Rodriguez Calvar <[email protected]>
+
[EME][GStreamer][Thunder] Make response parsing message more robust
https://bugs.webkit.org/show_bug.cgi?id=218172
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h (269030 => 269031)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h 2020-10-27 11:24:48 UTC (rev 269030)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h 2020-10-27 11:40:56 UTC (rev 269031)
@@ -33,6 +33,8 @@
#define WEBCORE_GSTREAMER_EME_UTILITIES_WIDEVINE_UUID "edef8ba9-79d6-4ace-a3c8-27dcd51d21ed"
#endif
+GST_DEBUG_CATEGORY_EXTERN(webkit_media_common_encryption_decrypt_debug_category);
+
namespace WebCore {
class InitData {
public:
@@ -45,7 +47,7 @@
{
auto mappedInitData = GstMappedOwnedBuffer::create(initData);
if (!mappedInitData) {
- GST_ERROR("cannot map %s protection data", systemId.utf8().data());
+ GST_CAT_LEVEL_LOG(webkit_media_common_encryption_decrypt_debug_category, GST_LEVEL_ERROR, nullptr, "cannot map %s protection data", systemId.utf8().data());
ASSERT_NOT_REACHED();
}
m_payload = mappedInitData->createSharedBuffer();
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp (269030 => 269031)
--- trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp 2020-10-27 11:24:48 UTC (rev 269030)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp 2020-10-27 11:40:56 UTC (rev 269031)
@@ -53,7 +53,7 @@
static gboolean sinkEventHandler(GstBaseTransform*, GstEvent*);
static void setContext(GstElement*, GstContext*);
-GST_DEBUG_CATEGORY_STATIC(webkit_media_common_encryption_decrypt_debug_category);
+GST_DEBUG_CATEGORY(webkit_media_common_encryption_decrypt_debug_category);
#define GST_CAT_DEFAULT webkit_media_common_encryption_decrypt_debug_category
#define webkit_media_common_encryption_decrypt_parent_class parent_class
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
