Title: [269038] trunk/Source/WebCore
- Revision
- 269038
- Author
- [email protected]
- Date
- 2020-10-27 06:56:30 -0700 (Tue, 27 Oct 2020)
Log Message
Assert in BoxTree::layoutBoxForRenderer() under RenderLayer::updateScrollCornerStyle()
https://bugs.webkit.org/show_bug.cgi?id=218205
<rdar://problem/70694256>
Reviewed by Zalan Bujtas.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::containing):
Similar to RenderReplica, RenderScrollbarPart is a fake renderer that is not in the tree even
though it has the parent pointer set.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (269037 => 269038)
--- trunk/Source/WebCore/ChangeLog 2020-10-27 13:28:41 UTC (rev 269037)
+++ trunk/Source/WebCore/ChangeLog 2020-10-27 13:56:30 UTC (rev 269038)
@@ -1,3 +1,17 @@
+2020-10-27 Antti Koivisto <[email protected]>
+
+ Assert in BoxTree::layoutBoxForRenderer() under RenderLayer::updateScrollCornerStyle()
+ https://bugs.webkit.org/show_bug.cgi?id=218205
+ <rdar://problem/70694256>
+
+ Reviewed by Zalan Bujtas.
+
+ * layout/integration/LayoutIntegrationLineLayout.cpp:
+ (WebCore::LayoutIntegration::LineLayout::containing):
+
+ Similar to RenderReplica, RenderScrollbarPart is a fake renderer that is not in the tree even
+ though it has the parent pointer set.
+
2020-10-27 Zalan Bujtas <[email protected]>
RenderStyle::resetPadding sets incorrect computed value (auto)
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (269037 => 269038)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-10-27 13:28:41 UTC (rev 269037)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2020-10-27 13:56:30 UTC (rev 269038)
@@ -71,7 +71,8 @@
if (!renderer.isInline())
return nullptr;
- if (renderer.isReplica())
+ // FIXME: These fake renderers have their parent set but are not actually in the tree.
+ if (renderer.isReplica() || renderer.isRenderScrollbarPart())
return nullptr;
if (auto* parent = renderer.parent()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
