- Revision
- 269048
- Author
- [email protected]
- Date
- 2020-10-27 10:25:58 -0700 (Tue, 27 Oct 2020)
Log Message
Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
https://bugs.webkit.org/show_bug.cgi?id=218240
Reviewed by Darin Adler.
Source/WebKit:
Addresses feedback from initial naming to make it clear what they are used
for and for consistency with WebKitLegacy.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBoolValueForKeyForTesting):
(WKPreferencesSetDoubleValueForKeyForTesting):
(WKPreferencesSetUInt32ValueForKeyForTesting):
(WKPreferencesSetStringValueForKeyForTesting):
(WKPreferencesSetBoolValueForKey): Deleted.
(WKPreferencesSetDoubleValueForKey): Deleted.
(WKPreferencesSetUInt32ValueForKey): Deleted.
(WKPreferencesSetStringValueForKey): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
Tools:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Update for renamed function names.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (269047 => 269048)
--- trunk/Source/WebKit/ChangeLog 2020-10-27 17:09:34 UTC (rev 269047)
+++ trunk/Source/WebKit/ChangeLog 2020-10-27 17:25:58 UTC (rev 269048)
@@ -1,3 +1,24 @@
+2020-10-27 Sam Weinig <[email protected]>
+
+ Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
+ https://bugs.webkit.org/show_bug.cgi?id=218240
+
+ Reviewed by Darin Adler.
+
+ Addresses feedback from initial naming to make it clear what they are used
+ for and for consistency with WebKitLegacy.
+
+ * UIProcess/API/C/WKPreferences.cpp:
+ (WKPreferencesSetBoolValueForKeyForTesting):
+ (WKPreferencesSetDoubleValueForKeyForTesting):
+ (WKPreferencesSetUInt32ValueForKeyForTesting):
+ (WKPreferencesSetStringValueForKeyForTesting):
+ (WKPreferencesSetBoolValueForKey): Deleted.
+ (WKPreferencesSetDoubleValueForKey): Deleted.
+ (WKPreferencesSetUInt32ValueForKey): Deleted.
+ (WKPreferencesSetStringValueForKey): Deleted.
+ * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
2020-10-27 Carlos Garcia Campos <[email protected]>
WebDriver: sequence of char key press is not supported
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (269047 => 269048)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-10-27 17:09:34 UTC (rev 269047)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp 2020-10-27 17:25:58 UTC (rev 269048)
@@ -78,22 +78,22 @@
toImpl(preferencesRef)->setInternalDebugFeatureEnabledForKey(toWTFString(internalDebugFeatureKey), value);
}
-void WKPreferencesSetBoolValueForKey(WKPreferencesRef preferencesRef, bool value, WKStringRef key)
+void WKPreferencesSetBoolValueForKeyForTesting(WKPreferencesRef preferencesRef, bool value, WKStringRef key)
{
toImpl(preferencesRef)->setBoolValueForKey(toWTFString(key), value);
}
-void WKPreferencesSetDoubleValueForKey(WKPreferencesRef preferencesRef, double value, WKStringRef key)
+void WKPreferencesSetDoubleValueForKeyForTesting(WKPreferencesRef preferencesRef, double value, WKStringRef key)
{
toImpl(preferencesRef)->setBoolValueForKey(toWTFString(key), value);
}
-void WKPreferencesSetUInt32ValueForKey(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key)
+void WKPreferencesSetUInt32ValueForKeyForTesting(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key)
{
toImpl(preferencesRef)->setUInt32ValueForKey(toWTFString(key), value);
}
-void WKPreferencesSetStringValueForKey(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key)
+void WKPreferencesSetStringValueForKeyForTesting(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key)
{
toImpl(preferencesRef)->setStringValueForKey(toWTFString(key), toWTFString(value));
}
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h (269047 => 269048)
--- trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-10-27 17:09:34 UTC (rev 269047)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h 2020-10-27 17:25:58 UTC (rev 269048)
@@ -56,10 +56,10 @@
WK_EXPORT void WKPreferencesSetInternalDebugFeatureForKey(WKPreferencesRef, bool, WKStringRef);
// The following generic setter functions are only intended for use by testing infrastructure.
-WK_EXPORT void WKPreferencesSetBoolValueForKey(WKPreferencesRef preferencesRef, bool value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetDoubleValueForKey(WKPreferencesRef preferencesRef, double value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetUInt32ValueForKey(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key);
-WK_EXPORT void WKPreferencesSetStringValueForKey(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetBoolValueForKeyForTesting(WKPreferencesRef preferencesRef, bool value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetDoubleValueForKeyForTesting(WKPreferencesRef preferencesRef, double value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetUInt32ValueForKeyForTesting(WKPreferencesRef preferencesRef, uint32_t value, WKStringRef key);
+WK_EXPORT void WKPreferencesSetStringValueForKeyForTesting(WKPreferencesRef preferencesRef, WKStringRef value, WKStringRef key);
// For Test Runner Use only.
WK_EXPORT void WKPreferencesResetTestRunnerOverrides(WKPreferencesRef preferencesRef);
Modified: trunk/Tools/ChangeLog (269047 => 269048)
--- trunk/Tools/ChangeLog 2020-10-27 17:09:34 UTC (rev 269047)
+++ trunk/Tools/ChangeLog 2020-10-27 17:25:58 UTC (rev 269048)
@@ -1,3 +1,14 @@
+2020-10-27 Sam Weinig <[email protected]>
+
+ Rename WKPreferencesSet*ValueForKey SPI to WKPreferencesSet*ValueForKeyForTesting
+ https://bugs.webkit.org/show_bug.cgi?id=218240
+
+ Reviewed by Darin Adler.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+ Update for renamed function names.
+
2020-10-27 Carlos Alberto Lopez Perez <[email protected]>
[GTK] Move step for generating the JSC bundle back to the release build bot
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (269047 => 269048)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-10-27 17:09:34 UTC (rev 269047)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-10-27 17:25:58 UTC (rev 269048)
@@ -921,17 +921,16 @@
platformResetPreferencesToConsistentValues();
for (const auto& [key, value] : options.boolWebPreferenceFeatures())
- WKPreferencesSetBoolValueForKey(preferences, value, toWK(key).get());
+ WKPreferencesSetBoolValueForKeyForTesting(preferences, value, toWK(key).get());
for (const auto& [key, value] : options.doubleWebPreferenceFeatures())
- WKPreferencesSetDoubleValueForKey(preferences, value, toWK(key).get());
+ WKPreferencesSetDoubleValueForKeyForTesting(preferences, value, toWK(key).get());
for (const auto& [key, value] : options.uint32WebPreferenceFeatures())
- WKPreferencesSetUInt32ValueForKey(preferences, value, toWK(key).get());
+ WKPreferencesSetUInt32ValueForKeyForTesting(preferences, value, toWK(key).get());
for (const auto& [key, value] : options.stringWebPreferenceFeatures())
- WKPreferencesSetStringValueForKey(preferences, toWK(value).get(), toWK(key).get());
-
+ WKPreferencesSetStringValueForKeyForTesting(preferences, toWK(value).get(), toWK(key).get());
}
bool TestController::resetStateToConsistentValues(const TestOptions& options, ResetStage resetStage)
