Title: [269067] trunk/LayoutTests
- Revision
- 269067
- Author
- [email protected]
- Date
- 2020-10-27 13:22:10 -0700 (Tue, 27 Oct 2020)
Log Message
REGRESSION (r265515): fast/events/touch/ios/touch-events-with-modifiers.html is a frequent failure
https://bugs.webkit.org/show_bug.cgi?id=218249
<rdar://problem/67079948>
Reviewed by Wenson Hsieh.
* fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html:
Don't notifyDone until both the scroll event happen and the event stream is done being dispatched.
Otherwise, we can move on and then send part of our event stream to the next page.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (269066 => 269067)
--- trunk/LayoutTests/ChangeLog 2020-10-27 19:53:43 UTC (rev 269066)
+++ trunk/LayoutTests/ChangeLog 2020-10-27 20:22:10 UTC (rev 269067)
@@ -1,3 +1,15 @@
+2020-10-27 Tim Horton <[email protected]>
+
+ REGRESSION (r265515): fast/events/touch/ios/touch-events-with-modifiers.html is a frequent failure
+ https://bugs.webkit.org/show_bug.cgi?id=218249
+ <rdar://problem/67079948>
+
+ Reviewed by Wenson Hsieh.
+
+ * fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html:
+ Don't notifyDone until both the scroll event happen and the event stream is done being dispatched.
+ Otherwise, we can move on and then send part of our event stream to the next page.
+
2020-10-27 Tetsuharu Ohzeki <[email protected]>
Accessory bar next/previous buttons do not work on inputs in shadow roots
Modified: trunk/LayoutTests/fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html (269066 => 269067)
--- trunk/LayoutTests/fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html 2020-10-27 19:53:43 UTC (rev 269066)
+++ trunk/LayoutTests/fast/events/touch/ios/resources/finish-test-after-scrolling-with-touch-event-handlers.html 2020-10-27 20:22:10 UTC (rev 269067)
@@ -23,6 +23,14 @@
}
</style>
<script>
+ var scrolled = false;
+ var finishedSendingEventStream = false;
+
+ function maybeNotifyDone() {
+ if (scrolled && finishedSendingEventStream)
+ testRunner.notifyDone();
+ }
+
async function finishTest() {
const scroller = document.getElementById("scroller");
scroller.addEventListener("touchstart", () => { });
@@ -29,7 +37,8 @@
scroller.addEventListener("touchend", () => { });
scroller.addEventListener("scroll", () => {
content.textContent = "Scrolled!";
- testRunner.notifyDone()
+ scrolled = true;
+ maybeNotifyDone();
}, { once : true });
const eventStreamData = new UIHelper.EventStreamBuilder()
@@ -41,6 +50,9 @@
.takeResult();
await UIHelper.sendEventStream(eventStreamData);
+
+ finishedSendingEventStream = true;
+ maybeNotifyDone();
}
addEventListener("load", finishTest);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
