Title: [269147] trunk/Source/ThirdParty/libwebrtc
- Revision
- 269147
- Author
- [email protected]
- Date
- 2020-10-29 07:29:52 -0700 (Thu, 29 Oct 2020)
Log Message
Disable VP9 VTB hardware decoding
https://bugs.webkit.org/show_bug.cgi?id=218326
Reviewed by Alex Christensen.
VP9 hardware decoder does not work properly yet as used in WebRTC pipeline.
Disable hardware support for now and use software based VP9 through VTB.
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:
(-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (269146 => 269147)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-10-29 14:21:34 UTC (rev 269146)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-10-29 14:29:52 UTC (rev 269147)
@@ -1,3 +1,16 @@
+2020-10-29 Youenn Fablet <[email protected]>
+
+ Disable VP9 VTB hardware decoding
+ https://bugs.webkit.org/show_bug.cgi?id=218326
+
+ Reviewed by Alex Christensen.
+
+ VP9 hardware decoder does not work properly yet as used in WebRTC pipeline.
+ Disable hardware support for now and use software based VP9 through VTB.
+
+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm:
+ (-[RTCVideoDecoderVTBVP9 resetDecompressionSession]):
+
2020-10-26 Youenn Fablet <[email protected]>
Add support for VP9 Profile 2 (10-bit color) in WebRTC
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm (269146 => 269147)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm 2020-10-29 14:21:34 UTC (rev 269146)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoDecoderVTBVP9.mm 2020-10-29 14:29:52 UTC (rev 269147)
@@ -260,11 +260,19 @@
CFRelease(pixelFormat);
pixelFormat = nullptr;
}
+
+ // rdar://problem/70701816. Disable hardware decoding until working properly.
+ auto videoDecoderSpecification = @{
+#if !defined(WEBRTC_IOS)
+ (__bridge NSString *)kVTVideoDecoderSpecification_EnableHardwareAcceleratedVideoDecoder: @NO
+#endif
+ };
+
VTDecompressionOutputCallbackRecord record = {
vp9DecompressionOutputCallback, (__bridge void *)self,
};
OSStatus status = VTDecompressionSessionCreate(
- nullptr, _videoFormat, nullptr, attributes, &record, &_decompressionSession);
+ nullptr, _videoFormat, (__bridge CFDictionaryRef)videoDecoderSpecification, attributes, &record, &_decompressionSession);
CFRelease(attributes);
if (status != noErr) {
RTC_LOG(LS_ERROR) << "Failed to create decompression session: " << status;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
